summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorScott Moser <smoser@brickies.net>2017-11-07 17:02:22 -0500
committerScott Moser <smoser@brickies.net>2017-11-07 17:02:22 -0500
commit7bb01ea3a04891bcfcdd8ffbbc6c799a923d8fb3 (patch)
tree0300acc3f0f5f7b2de632934eca996be15021d70
parent8622491c29f30862a1a1d7ad2cba023981acc8ce (diff)
downloadvyos-cloud-init-7bb01ea3a04891bcfcdd8ffbbc6c799a923d8fb3.tar.gz
vyos-cloud-init-7bb01ea3a04891bcfcdd8ffbbc6c799a923d8fb3.zip
tests: address some minor feedback missed in last merge.
3 things here: a.) link to a bug that we opened to track what made us add dns entries for hostname of our guests. b.) spelling fix. c.) raise an instance of a NotImplementedError not the class.
-rw-r--r--tests/cloud_tests/instances/nocloudkvm.py3
-rw-r--r--tests/cloud_tests/util.py2
2 files changed, 3 insertions, 2 deletions
diff --git a/tests/cloud_tests/instances/nocloudkvm.py b/tests/cloud_tests/instances/nocloudkvm.py
index fbb04aa2..2427c856 100644
--- a/tests/cloud_tests/instances/nocloudkvm.py
+++ b/tests/cloud_tests/instances/nocloudkvm.py
@@ -15,8 +15,9 @@ from tests.cloud_tests import util
# This domain contains reverse lookups for hostnames that are used.
# The primary reason is so sudo will return quickly when it attempts
# to look up the hostname. i9n is just short for 'integration'.
-# use i9n.brickies.net until i9n.cloud-init.io is popualted:
+# use i9n.brickies.net until i9n.cloud-init.io is populated:
# https://portal.admin.canonical.com/107125
+# see also bug 1730744 for why we had to do this.
CI_DOMAIN = "i9n.brickies.net"
diff --git a/tests/cloud_tests/util.py b/tests/cloud_tests/util.py
index 92c31c3a..c5cd6974 100644
--- a/tests/cloud_tests/util.py
+++ b/tests/cloud_tests/util.py
@@ -345,7 +345,7 @@ class TargetBase(object):
This is intended to be implemented by the Image or Instance.
Many callers will use the higher level 'execute'."""
- raise NotImplementedError
+ raise NotImplementedError("_execute must be implemented by subclass.")
def read_data(self, remote_path, decode=False):
"""Read data from instance filesystem.