diff options
| author | Daniel Watkins <oddbloke@ubuntu.com> | 2020-04-24 09:26:51 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-24 09:26:51 -0400 |
| commit | 38a7e6e9756fdab31264c0d6e93d20432ed111ac (patch) | |
| tree | c71a79b98c883cf3657eaac6e6b2267dfb50f277 /cloudinit/net/tests/test_init.py | |
| parent | 7276aa5240b8cb84671a56d795d811f15dfba8e2 (diff) | |
| download | vyos-cloud-init-38a7e6e9756fdab31264c0d6e93d20432ed111ac.tar.gz vyos-cloud-init-38a7e6e9756fdab31264c0d6e93d20432ed111ac.zip | |
cloudinit: drop dependencies on unittest2 and contextlib2 (#322)
These libraries provide backports of Python 3's stdlib components to Python 2. As we only support Python 3, we can simply use the stdlib now. This pull request does the following:
* removes some unneeded compatibility code for the old spelling of `assertRaisesRegex`
* replaces invocations of the Python 2-only `assertItemsEqual` with its new name, `assertCountEqual`
* replaces all usage of `unittest2` with `unittest`
* replaces all usage of `contextlib2` with `contextlib`
* drops `unittest2` and `contextlib2` from requirements files and tox.ini
It also rewrites some `test_azure` helpers to use bare asserts. We were seeing a strange error in xenial builds of this branch which appear to be stemming from the AssertionError that pytest produces being _different_ from the standard AssertionError. This means that the modified helpers weren't behaving correctly, because they weren't catching AssertionErrors as one would expect. (I believe this is related, in some way, to https://github.com/pytest-dev/pytest/issues/645, but the only version of pytest where we're affected is so far in the past that it's not worth pursuing it any further as we have a workaround.)
Diffstat (limited to 'cloudinit/net/tests/test_init.py')
| -rw-r--r-- | cloudinit/net/tests/test_init.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cloudinit/net/tests/test_init.py b/cloudinit/net/tests/test_init.py index 32e70b4c..835ed807 100644 --- a/cloudinit/net/tests/test_init.py +++ b/cloudinit/net/tests/test_init.py @@ -397,7 +397,7 @@ class TestGetDeviceList(CiTestCase): """get_devicelist returns a directory listing for SYS_CLASS_NET.""" write_file(os.path.join(self.sysdir, 'eth0', 'operstate'), 'up') write_file(os.path.join(self.sysdir, 'eth1', 'operstate'), 'up') - self.assertItemsEqual(['eth0', 'eth1'], net.get_devicelist()) + self.assertCountEqual(['eth0', 'eth1'], net.get_devicelist()) class TestGetInterfaceMAC(CiTestCase): |