Add Strict Metaschema Validation (#1101)

Improve schema validation.

This adds strict validation of config module definitions at testing
time, with plumbing included for future runtime validation. This
eliminates a class of bugs resulting from schemas that have definitions
that are incorrect, but get interpreted by jsonschema as
"additionalProperties" that are therefore ignored.

- Add strict meta-schema for jsonschema unit test validation
- Separate schema from module metadata structure
- Improve type annotations for various functions and data types

Cleanup:
- Remove unused jsonschema "required" elements 
- Eliminate manual memoization in schema.py:get_schema(),
        reference module.__doc__ directly

1 files changed, 2 insertions, 2 deletions

diff --git a/tests/unittests/cmd/test_cloud_id.py b/tests/unittests/cmd/test_cloud_id.py
index 12fc80e8..9a010402 100644
--- a/tests/unittests/cmd/test_cloud_id.py
+++ b/tests/unittests/cmd/test_cloud_id.py
@@ -51,7 +51,7 @@ class TestCloudId(CiTestCase):
                     cloud_id.main()
         self.assertEqual(1, context_manager.exception.code)
         self.assertIn(
-            "ERROR: File not found '%s'" % self.instance_data,
+            "Error:\nFile not found '%s'" % self.instance_data,
             m_stderr.getvalue())
 
     def test_cloud_id_non_json_instance_data(self):
@@ -64,7 +64,7 @@ class TestCloudId(CiTestCase):
                     cloud_id.main()
         self.assertEqual(1, context_manager.exception.code)
         self.assertIn(
-            "ERROR: File '%s' is not valid json." % self.instance_data,
+            "Error:\nFile '%s' is not valid json." % self.instance_data,
             m_stderr.getvalue())
 
     def test_cloud_id_from_cloud_name_in_instance_data(self):