Adopt Black and isort (SC-700) (#1157)

Applied Black and isort, fixed any linting issues, updated tox.ini
and CI.

2 files changed, 103 insertions, 78 deletions

diff --git a/tests/unittests/runs/test_merge_run.py b/tests/unittests/runs/test_merge_run.py
index 29439c8a..1b1b5595 100644
--- a/tests/unittests/runs/test_merge_run.py
+++ b/tests/unittests/runs/test_merge_run.py
@@ -4,12 +4,9 @@ import os
 import shutil
 import tempfile
 
-from tests.unittests import helpers
-
+from cloudinit import safeyaml, stages, util
 from cloudinit.settings import PER_INSTANCE
-from cloudinit import safeyaml
-from cloudinit import stages
-from cloudinit import util
+from tests.unittests import helpers
 
 
 class TestMergeRun(helpers.FilesystemMockingTestCase):
@@ -20,17 +17,18 @@ class TestMergeRun(helpers.FilesystemMockingTestCase):
     def test_none_ds(self):
         new_root = tempfile.mkdtemp()
         self.addCleanup(shutil.rmtree, new_root)
-        self.replicateTestRoot('simple_ubuntu', new_root)
+        self.replicateTestRoot("simple_ubuntu", new_root)
         cfg = {
-            'datasource_list': ['None'],
-            'cloud_init_modules': ['write-files'],
-            'system_info': {'paths': {'run_dir': new_root}}
+            "datasource_list": ["None"],
+            "cloud_init_modules": ["write-files"],
+            "system_info": {"paths": {"run_dir": new_root}},
         }
-        ud = helpers.readResource('user_data.1.txt')
+        ud = helpers.readResource("user_data.1.txt")
         cloud_cfg = safeyaml.dumps(cfg)
-        util.ensure_dir(os.path.join(new_root, 'etc', 'cloud'))
-        util.write_file(os.path.join(new_root, 'etc',
-                                     'cloud', 'cloud.cfg'), cloud_cfg)
+        util.ensure_dir(os.path.join(new_root, "etc", "cloud"))
+        util.write_file(
+            os.path.join(new_root, "etc", "cloud", "cloud.cfg"), cloud_cfg
+        )
         self._patchIn(new_root)
 
         # Now start verifying whats created
@@ -41,20 +39,23 @@ class TestMergeRun(helpers.FilesystemMockingTestCase):
         initer.datasource.userdata_raw = ud
         initer.instancify()
         initer.update()
-        initer.cloudify().run('consume_data',
-                              initer.consume_data,
-                              args=[PER_INSTANCE],
-                              freq=PER_INSTANCE)
-        mirrors = initer.distro.get_option('package_mirrors')
+        initer.cloudify().run(
+            "consume_data",
+            initer.consume_data,
+            args=[PER_INSTANCE],
+            freq=PER_INSTANCE,
+        )
+        mirrors = initer.distro.get_option("package_mirrors")
         self.assertEqual(1, len(mirrors))
         mirror = mirrors[0]
-        self.assertEqual(mirror['arches'], ['i386', 'amd64', 'blah'])
+        self.assertEqual(mirror["arches"], ["i386", "amd64", "blah"])
         mods = stages.Modules(initer)
-        (which_ran, failures) = mods.run_section('cloud_init_modules')
+        (which_ran, failures) = mods.run_section("cloud_init_modules")
         self.assertTrue(len(failures) == 0)
-        self.assertTrue(os.path.exists('/etc/blah.ini'))
-        self.assertIn('write-files', which_ran)
-        contents = util.load_file('/etc/blah.ini')
-        self.assertEqual(contents, 'blah')
+        self.assertTrue(os.path.exists("/etc/blah.ini"))
+        self.assertIn("write-files", which_ran)
+        contents = util.load_file("/etc/blah.ini")
+        self.assertEqual(contents, "blah")
+
 
 # vi: ts=4 expandtab
diff --git a/tests/unittests/runs/test_simple_run.py b/tests/unittests/runs/test_simple_run.py
index aa78dda3..38cf9494 100644
--- a/tests/unittests/runs/test_simple_run.py
+++ b/tests/unittests/runs/test_simple_run.py
@@ -3,12 +3,9 @@
 import copy
 import os
 
-
+from cloudinit import safeyaml, stages, util
 from cloudinit.settings import PER_INSTANCE
-from cloudinit import safeyaml
-from cloudinit import stages
 from tests.unittests import helpers
-from cloudinit import util
 
 
 class TestSimpleRun(helpers.FilesystemMockingTestCase):
@@ -18,27 +15,28 @@ class TestSimpleRun(helpers.FilesystemMockingTestCase):
     def setUp(self):
         super(TestSimpleRun, self).setUp()
         self.new_root = self.tmp_dir()
-        self.replicateTestRoot('simple_ubuntu', self.new_root)
+        self.replicateTestRoot("simple_ubuntu", self.new_root)
 
         # Seed cloud.cfg file for our tests
         self.cfg = {
-            'datasource_list': ['None'],
-            'runcmd': ['ls /etc'],  # test ALL_DISTROS
-            'spacewalk': {},  # test non-ubuntu distros module definition
-            'system_info': {'paths': {'run_dir': self.new_root}},
-            'write_files': [
+            "datasource_list": ["None"],
+            "runcmd": ["ls /etc"],  # test ALL_DISTROS
+            "spacewalk": {},  # test non-ubuntu distros module definition
+            "system_info": {"paths": {"run_dir": self.new_root}},
+            "write_files": [
                 {
-                    'path': '/etc/blah.ini',
-                    'content': 'blah',
-                    'permissions': 0o755,
+                    "path": "/etc/blah.ini",
+                    "content": "blah",
+                    "permissions": 0o755,
                 },
             ],
-            'cloud_init_modules': ['write-files', 'spacewalk', 'runcmd'],
+            "cloud_init_modules": ["write-files", "spacewalk", "runcmd"],
         }
         cloud_cfg = safeyaml.dumps(self.cfg)
-        util.ensure_dir(os.path.join(self.new_root, 'etc', 'cloud'))
-        util.write_file(os.path.join(self.new_root, 'etc',
-                                     'cloud', 'cloud.cfg'), cloud_cfg)
+        util.ensure_dir(os.path.join(self.new_root, "etc", "cloud"))
+        util.write_file(
+            os.path.join(self.new_root, "etc", "cloud", "cloud.cfg"), cloud_cfg
+        )
         self.patchOS(self.new_root)
         self.patchUtils(self.new_root)
 
@@ -49,12 +47,12 @@ class TestSimpleRun(helpers.FilesystemMockingTestCase):
         initer.read_cfg()
         initer.initialize()
         self.assertTrue(os.path.exists("/var/lib/cloud"))
-        for d in ['scripts', 'seed', 'instances', 'handlers', 'sem', 'data']:
+        for d in ["scripts", "seed", "instances", "handlers", "sem", "data"]:
             self.assertTrue(os.path.isdir(os.path.join("/var/lib/cloud", d)))
 
         initer.fetch()
         iid = initer.instancify()
-        self.assertEqual(iid, 'iid-datasource-none')
+        self.assertEqual(iid, "iid-datasource-none")
         initer.update()
         self.assertTrue(os.path.islink("var/lib/cloud/instance"))
 
@@ -66,20 +64,25 @@ class TestSimpleRun(helpers.FilesystemMockingTestCase):
         initer.fetch()
         initer.instancify()
         initer.update()
-        initer.cloudify().run('consume_data', initer.consume_data,
-                              args=[PER_INSTANCE], freq=PER_INSTANCE)
+        initer.cloudify().run(
+            "consume_data",
+            initer.consume_data,
+            args=[PER_INSTANCE],
+            freq=PER_INSTANCE,
+        )
 
         mods = stages.Modules(initer)
-        (which_ran, failures) = mods.run_section('cloud_init_modules')
+        (which_ran, failures) = mods.run_section("cloud_init_modules")
         self.assertTrue(len(failures) == 0)
-        self.assertTrue(os.path.exists('/etc/blah.ini'))
-        self.assertIn('write-files', which_ran)
-        contents = util.load_file('/etc/blah.ini')
-        self.assertEqual(contents, 'blah')
+        self.assertTrue(os.path.exists("/etc/blah.ini"))
+        self.assertIn("write-files", which_ran)
+        contents = util.load_file("/etc/blah.ini")
+        self.assertEqual(contents, "blah")
         self.assertNotIn(
             "Skipping modules ['write-files'] because they are not verified on"
             " distro 'ubuntu'",
-            self.logs.getvalue())
+            self.logs.getvalue(),
+        )
 
     def test_none_ds_skips_modules_which_define_unmatched_distros(self):
         """Skip modules which define distros which don't match the current."""
@@ -89,17 +92,22 @@ class TestSimpleRun(helpers.FilesystemMockingTestCase):
         initer.fetch()
         initer.instancify()
         initer.update()
-        initer.cloudify().run('consume_data', initer.consume_data,
-                              args=[PER_INSTANCE], freq=PER_INSTANCE)
+        initer.cloudify().run(
+            "consume_data",
+            initer.consume_data,
+            args=[PER_INSTANCE],
+            freq=PER_INSTANCE,
+        )
 
         mods = stages.Modules(initer)
-        (which_ran, failures) = mods.run_section('cloud_init_modules')
+        (which_ran, failures) = mods.run_section("cloud_init_modules")
         self.assertTrue(len(failures) == 0)
         self.assertIn(
             "Skipping modules 'spacewalk' because they are not verified on"
             " distro 'ubuntu'",
-            self.logs.getvalue())
-        self.assertNotIn('spacewalk', which_ran)
+            self.logs.getvalue(),
+        )
+        self.assertNotIn("spacewalk", which_ran)
 
     def test_none_ds_runs_modules_which_distros_all(self):
         """Skip modules which define distros attribute as supporting 'all'.
@@ -113,28 +121,34 @@ class TestSimpleRun(helpers.FilesystemMockingTestCase):
         initer.fetch()
         initer.instancify()
         initer.update()
-        initer.cloudify().run('consume_data', initer.consume_data,
-                              args=[PER_INSTANCE], freq=PER_INSTANCE)
+        initer.cloudify().run(
+            "consume_data",
+            initer.consume_data,
+            args=[PER_INSTANCE],
+            freq=PER_INSTANCE,
+        )
 
         mods = stages.Modules(initer)
-        (which_ran, failures) = mods.run_section('cloud_init_modules')
+        (which_ran, failures) = mods.run_section("cloud_init_modules")
         self.assertTrue(len(failures) == 0)
-        self.assertIn('runcmd', which_ran)
+        self.assertIn("runcmd", which_ran)
         self.assertNotIn(
             "Skipping modules 'runcmd' because they are not verified on"
             " distro 'ubuntu'",
-            self.logs.getvalue())
+            self.logs.getvalue(),
+        )
 
     def test_none_ds_forces_run_via_unverified_modules(self):
         """run_section forced skipped modules by using unverified_modules."""
 
         # re-write cloud.cfg with unverified_modules override
         cfg = copy.deepcopy(self.cfg)
-        cfg['unverified_modules'] = ['spacewalk']  # Would have skipped
+        cfg["unverified_modules"] = ["spacewalk"]  # Would have skipped
         cloud_cfg = safeyaml.dumps(cfg)
-        util.ensure_dir(os.path.join(self.new_root, 'etc', 'cloud'))
-        util.write_file(os.path.join(self.new_root, 'etc',
-                                     'cloud', 'cloud.cfg'), cloud_cfg)
+        util.ensure_dir(os.path.join(self.new_root, "etc", "cloud"))
+        util.write_file(
+            os.path.join(self.new_root, "etc", "cloud", "cloud.cfg"), cloud_cfg
+        )
 
         initer = stages.Init()
         initer.read_cfg()
@@ -142,16 +156,20 @@ class TestSimpleRun(helpers.FilesystemMockingTestCase):
         initer.fetch()
         initer.instancify()
         initer.update()
-        initer.cloudify().run('consume_data', initer.consume_data,
-                              args=[PER_INSTANCE], freq=PER_INSTANCE)
+        initer.cloudify().run(
+            "consume_data",
+            initer.consume_data,
+            args=[PER_INSTANCE],
+            freq=PER_INSTANCE,
+        )
 
         mods = stages.Modules(initer)
-        (which_ran, failures) = mods.run_section('cloud_init_modules')
+        (which_ran, failures) = mods.run_section("cloud_init_modules")
         self.assertTrue(len(failures) == 0)
-        self.assertIn('spacewalk', which_ran)
+        self.assertIn("spacewalk", which_ran)
         self.assertIn(
-            "running unverified_modules: 'spacewalk'",
-            self.logs.getvalue())
+            "running unverified_modules: 'spacewalk'", self.logs.getvalue()
+        )
 
     def test_none_ds_run_with_no_config_modules(self):
         """run_section will report no modules run when none are configured."""
@@ -159,11 +177,12 @@ class TestSimpleRun(helpers.FilesystemMockingTestCase):
         # re-write cloud.cfg with unverified_modules override
         cfg = copy.deepcopy(self.cfg)
         # Represent empty configuration in /etc/cloud/cloud.cfg
-        cfg['cloud_init_modules'] = None
+        cfg["cloud_init_modules"] = None
         cloud_cfg = safeyaml.dumps(cfg)
-        util.ensure_dir(os.path.join(self.new_root, 'etc', 'cloud'))
-        util.write_file(os.path.join(self.new_root, 'etc',
-                                     'cloud', 'cloud.cfg'), cloud_cfg)
+        util.ensure_dir(os.path.join(self.new_root, "etc", "cloud"))
+        util.write_file(
+            os.path.join(self.new_root, "etc", "cloud", "cloud.cfg"), cloud_cfg
+        )
 
         initer = stages.Init()
         initer.read_cfg()
@@ -171,12 +190,17 @@ class TestSimpleRun(helpers.FilesystemMockingTestCase):
         initer.fetch()
         initer.instancify()
         initer.update()
-        initer.cloudify().run('consume_data', initer.consume_data,
-                              args=[PER_INSTANCE], freq=PER_INSTANCE)
+        initer.cloudify().run(
+            "consume_data",
+            initer.consume_data,
+            args=[PER_INSTANCE],
+            freq=PER_INSTANCE,
+        )
 
         mods = stages.Modules(initer)
-        (which_ran, failures) = mods.run_section('cloud_init_modules')
+        (which_ran, failures) = mods.run_section("cloud_init_modules")
         self.assertTrue(len(failures) == 0)
         self.assertEqual([], which_ran)
 
+
 # vi: ts=4 expandtab