diff options
| author | Paride Legovini <paride.legovini@canonical.com> | 2021-07-20 16:58:21 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-20 09:58:21 -0500 |
| commit | ec6afadbf0f0f77d5b58dccd70df77da89c2c91d (patch) | |
| tree | 5f1a719faf924b28cdc2d6958a3b6a8eb2c771bf /tests/unittests | |
| parent | a984ee78b745b157b4b023a1786bfbd3b2002b88 (diff) | |
| download | vyos-cloud-init-ec6afadbf0f0f77d5b58dccd70df77da89c2c91d.tar.gz vyos-cloud-init-ec6afadbf0f0f77d5b58dccd70df77da89c2c91d.zip | |
Update pylint to v2.9.3 and fix the new issues it spots (#946)
In CI run against pylint 2.9.3 and fix occurrences of:
- W0237 (arguments-renamed)
- W0402 (deprecated-module)
The W0402 deprecated-module was about module `imp`:
cloudinit/patcher.py:9: [W0402(deprecated-module), ]
Uses of a deprecated module 'imp'
The imp module is deprecated and replaced by importlib, which according
to the documentation has no replacement for acquire_lock() and
release_lock(), which are the only reason why `imp` is imported.
Nothing about the code using this lock that actually requires it.
Let's remove the locking code and the import altogether.
Dropping the locking makes patcher.patch() an empty wrapper around
_patch_logging(). Rename _patch_logging() to patch_logging() and
call it directly instead. Drop patch().
Diffstat (limited to 'tests/unittests')
| -rw-r--r-- | tests/unittests/test_distros/test_create_users.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/unittests/test_distros/test_create_users.py b/tests/unittests/test_distros/test_create_users.py index 94ab052d..021866b7 100644 --- a/tests/unittests/test_distros/test_create_users.py +++ b/tests/unittests/test_distros/test_create_users.py @@ -23,7 +23,7 @@ class MyBaseDistro(distros.Distro): def _write_network(self, settings): raise NotImplementedError() - def package_command(self, cmd, args=None, pkgs=None): + def package_command(self, command, args=None, pkgs=None): raise NotImplementedError() def update_package_sources(self): |