diff options
author | Andrew Kutz <101085+akutz@users.noreply.github.com> | 2021-08-24 16:45:11 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-08-24 16:45:11 -0500 |
commit | de8931edc4093013fd685938e1c4e5a3d53f653c (patch) | |
tree | 670dc8660ecd5bb7326a0ba264b3dfb3e0c4d4f6 /tools/.lp-to-git-user | |
parent | 28e56d993fc40feab139f149dacc10cae51a3fe0 (diff) | |
download | vyos-cloud-init-de8931edc4093013fd685938e1c4e5a3d53f653c.tar.gz vyos-cloud-init-de8931edc4093013fd685938e1c4e5a3d53f653c.zip |
Update ds-identify to pass shellcheck (#979)
This patch updates the ds-identify file to pass the
popular shell linter, shellcheck. Updates include:
* Global ignore for error code 3043, the warning about
the "local" keyword not being POSIX compliant. This
keyword is used everywhere and cannot be easily removed.
* Point-of-use ignore for error code 3013, the warning
about the "-nt" comparator not being POSIX compliant.
There's no POSIX compliant way to compare timestamps
on two files without forking a new process, so this
comparator remains.
* Several point-of-use ignores for error code 2254, the
warning about quoting parameters. These warnings are
ignored for the *_matches functions where wildcard
tokens are expected to be used. Quoting the parameters
would prevent the desired globbing and cause calls
to these functions with wildcards to fail.
* A point-of-use ignore for error code 2086 for the
same reason as the above ignore -- allowing globbing
to take place for matching.
* Quoted parameters in the remainder of the locations
where it was safe to do so and did not break the
tests.
Diffstat (limited to 'tools/.lp-to-git-user')
0 files changed, 0 insertions, 0 deletions