diff options
author | Joshua Powers <josh.powers@canonical.com> | 2017-01-30 15:31:36 -0700 |
---|---|---|
committer | Scott Moser <smoser@ubuntu.com> | 2017-02-05 17:37:26 -0600 |
commit | 5f14a0b1ca3079e4ab43d615840866a4b7d8df6a (patch) | |
tree | de553e9e6cf3b56cea5e13fd9d6c0b2ec40b6ab9 /tools/make-mime.py | |
parent | e98709225510ee99ee0269c558c82b3e693e38e5 (diff) | |
download | vyos-cloud-init-5f14a0b1ca3079e4ab43d615840866a4b7d8df6a.tar.gz vyos-cloud-init-5f14a0b1ca3079e4ab43d615840866a4b7d8df6a.zip |
code-style: make master pass pycodestyle (2.3.1) cleanly, currently:
$ pycodestyle cloudinit/ tests/ tools/
tools/make-mime.py:25:5: E722 do not use bare except'
tools/mock-meta.py:252:17: E722 do not use bare except'
For tools/make-mime.py:25:5: E722 do not use bare except' the use case is
when someone runs
./make-mime.py --attach commis
instead of
./make-mime.py --attach commissaire.txt:x-commissaire-host
The split can cause a ValueError potentially if there is no:
For tools/mock-meta.py:262:17: E722 do not use bare except' the use case is
a dictionary look up occurs potentially when an unknown key is given:
key_name = key_ids[key_id]
Do note that version 2.3.0 falsely reported a dozen or so E302 and E306
errors.
Diffstat (limited to 'tools/make-mime.py')
-rwxr-xr-x | tools/make-mime.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/make-mime.py b/tools/make-mime.py index 12727126..f6a72044 100755 --- a/tools/make-mime.py +++ b/tools/make-mime.py @@ -22,7 +22,7 @@ def file_content_type(text): try: filename, content_type = text.split(":", 1) return (open(filename, 'r'), filename, content_type.strip()) - except: + except ValueError: raise argparse.ArgumentError("Invalid value for %r" % (text)) |