Adopt Black and isort (SC-700) (#1157)

Applied Black and isort, fixed any linting issues, updated tox.ini
and CI.

2 files changed, 166 insertions, 139 deletions

diff --git a/tools/mock-meta.py b/tools/mock-meta.py
index 9dd067b9..4ac1ea4f 100755
--- a/tools/mock-meta.py
+++ b/tools/mock-meta.py
@@ -36,74 +36,74 @@ except ImportError:
     from http import client as hclient
 
 
-log = logging.getLogger('meta-server')
+log = logging.getLogger("meta-server")
 
 EC2_VERSIONS = [
-    '1.0',
-    '2007-01-19',
-    '2007-03-01',
-    '2007-08-29',
-    '2007-10-10',
-    '2007-12-15',
-    '2008-02-01',
-    '2008-09-01',
-    '2009-04-04',
+    "1.0",
+    "2007-01-19",
+    "2007-03-01",
+    "2007-08-29",
+    "2007-10-10",
+    "2007-12-15",
+    "2008-02-01",
+    "2008-09-01",
+    "2009-04-04",
 ]
 
 BLOCK_DEVS = [
-    'ami',
-    'ephemeral0',
-    'root',
+    "ami",
+    "ephemeral0",
+    "root",
 ]
 
-DEV_PREFIX = 'v'  # This seems to vary alot depending on images...
+DEV_PREFIX = "v"  # This seems to vary alot depending on images...
 DEV_MAPPINGS = {
-    'ephemeral0': '%sda2' % (DEV_PREFIX),
-    'root': '/dev/%sda1' % (DEV_PREFIX),
-    'ami': '%sda1' % (DEV_PREFIX),
-    'swap': '%sda3' % (DEV_PREFIX),
+    "ephemeral0": "%sda2" % (DEV_PREFIX),
+    "root": "/dev/%sda1" % (DEV_PREFIX),
+    "ami": "%sda1" % (DEV_PREFIX),
+    "swap": "%sda3" % (DEV_PREFIX),
 }
 
 META_CAPABILITIES = [
-    'aki-id',
-    'ami-id',
-    'ami-launch-index',
-    'ami-manifest-path',
-    'ari-id',
-    'block-device-mapping/',
-    'hostname',
-    'instance-action',
-    'instance-id',
-    'instance-type',
-    'local-hostname',
-    'local-ipv4',
-    'placement/',
-    'product-codes',
-    'public-hostname',
-    'public-ipv4',
-    'public-keys/',
-    'reservation-id',
-    'security-groups'
+    "aki-id",
+    "ami-id",
+    "ami-launch-index",
+    "ami-manifest-path",
+    "ari-id",
+    "block-device-mapping/",
+    "hostname",
+    "instance-action",
+    "instance-id",
+    "instance-type",
+    "local-hostname",
+    "local-ipv4",
+    "placement/",
+    "product-codes",
+    "public-hostname",
+    "public-ipv4",
+    "public-keys/",
+    "reservation-id",
+    "security-groups",
 ]
 
 PUB_KEYS = {
-    'brickies': [
-        ('ssh-rsa '
-         'AAAAB3NzaC1yc2EAAAABIwAAAQEA3I7VUf2l5gSn5uavROsc5HRDpZdQueUq5ozemN'
-         'Sj8T7enqKHOEaFoU2VoPgGEWC9RyzSQVeyD6s7APMcE82EtmW4skVEgEGSbDc1pvxz'
-         'xtchBj78hJP6Cf5TCMFSXw+Fz5rF1dR23QDbN1mkHs7adr8GW4kSWqU7Q7NDwfIrJJ'
-         'tO7Hi42GyXtvEONHbiRPOe8stqUly7MvUoN+5kfjBM8Qqpfl2+FNhTYWpMfYdPUnE7'
-         'u536WqzFmsaqJctz3gBxH9Ex7dFtrxR4qiqEr9Qtlu3xGn7Bw07/+i1D+ey3ONkZLN'
-         '+LQ714cgj8fRS4Hj29SCmXp5Kt5/82cD/VN3NtHw== brickies'),
-        '',
+    "brickies": [
+        "ssh-rsa "
+        "AAAAB3NzaC1yc2EAAAABIwAAAQEA3I7VUf2l5gSn5uavROsc5HRDpZdQueUq5ozemN"
+        "Sj8T7enqKHOEaFoU2VoPgGEWC9RyzSQVeyD6s7APMcE82EtmW4skVEgEGSbDc1pvxz"
+        "xtchBj78hJP6Cf5TCMFSXw+Fz5rF1dR23QDbN1mkHs7adr8GW4kSWqU7Q7NDwfIrJJ"
+        "tO7Hi42GyXtvEONHbiRPOe8stqUly7MvUoN+5kfjBM8Qqpfl2+FNhTYWpMfYdPUnE7"
+        "u536WqzFmsaqJctz3gBxH9Ex7dFtrxR4qiqEr9Qtlu3xGn7Bw07/+i1D+ey3ONkZLN"
+        "+LQ714cgj8fRS4Hj29SCmXp5Kt5/82cD/VN3NtHw== brickies",
+        "",
     ],
 }
 
 INSTANCE_TYPES = [
-    'm1.large',
-    'm1.medium',
-    'm1.small',
-    'm1.xlarge',
+    "m1.large",
+    "m1.medium",
+    "m1.small",
+    "m1.xlarge",
 ]
 
 AVAILABILITY_ZONES = [
@@ -111,13 +111,13 @@ AVAILABILITY_ZONES = [
     "us-east-1b",
     "us-east-1c",
     "us-east-1d",
-    'eu-west-1a',
-    'eu-west-1b',
-    'us-west-1',
+    "eu-west-1a",
+    "eu-west-1b",
+    "us-west-1",
 ]
 
 PLACEMENT_CAPABILITIES = {
-    'availability-zone': AVAILABILITY_ZONES,
+    "availability-zone": AVAILABILITY_ZONES,
 }
 
 NOT_IMPL_RESPONSE = json.dumps({})
@@ -130,12 +130,14 @@ class WebException(Exception):
 
 
 def yamlify(data):
-    formatted = yaml.dump(data,
-                          line_break="\n",
-                          indent=4,
-                          explicit_start=True,
-                          explicit_end=True,
-                          default_flow_style=False)
+    formatted = yaml.dump(
+        data,
+        line_break="\n",
+        indent=4,
+        explicit_start=True,
+        explicit_end=True,
+        default_flow_style=False,
+    )
     return formatted
 
 
@@ -164,7 +166,7 @@ ID_CHARS = [c for c in (string.ascii_uppercase + string.digits)]
 
 
 def id_generator(size=6, lower=False):
-    txt = ''.join(random.choice(ID_CHARS) for x in range(size))
+    txt = "".join(random.choice(ID_CHARS) for x in range(size))
     if lower:
         return txt.lower()
     else:
@@ -176,14 +178,14 @@ def get_ssh_keys():
     keys.update(PUB_KEYS)
 
     # Nice helper to add in the 'running' users key (if they have one)
-    key_pth = os.path.expanduser('~/.ssh/id_rsa.pub')
+    key_pth = os.path.expanduser("~/.ssh/id_rsa.pub")
     if not os.path.isfile(key_pth):
-        key_pth = os.path.expanduser('~/.ssh/id_dsa.pub')
+        key_pth = os.path.expanduser("~/.ssh/id_dsa.pub")
 
     if os.path.isfile(key_pth):
-        with open(key_pth, 'rb') as fh:
+        with open(key_pth, "rb") as fh:
             contents = fh.read()
-        keys[os.getlogin()] = [contents, '']
+        keys[os.getlogin()] = [contents, ""]
 
     return keys
 
@@ -193,7 +195,6 @@ class HTTPServerV6(HTTPServer):
 
 
 class MetaDataHandler(object):
-
     def __init__(self, opts):
         self.opts = opts
         self.instances = {}
@@ -206,17 +207,17 @@ class MetaDataHandler(object):
             return "\n".join(caps)
         action = params[0]
         action = action.lower()
-        if action == 'instance-id':
-            return 'i-%s' % (id_generator(lower=True))
-        elif action == 'ami-launch-index':
+        if action == "instance-id":
+            return "i-%s" % (id_generator(lower=True))
+        elif action == "ami-launch-index":
             return "%s" % random.choice([0, 1, 2, 3])
-        elif action == 'aki-id':
-            return 'aki-%s' % (id_generator(lower=True))
-        elif action == 'ami-id':
-            return 'ami-%s' % (id_generator(lower=True))
-        elif action == 'ari-id':
-            return 'ari-%s' % (id_generator(lower=True))
-        elif action == 'block-device-mapping':
+        elif action == "aki-id":
+            return "aki-%s" % (id_generator(lower=True))
+        elif action == "ami-id":
+            return "ami-%s" % (id_generator(lower=True))
+        elif action == "ari-id":
+            return "ari-%s" % (id_generator(lower=True))
+        elif action == "block-device-mapping":
             nparams = params[1:]
             if not nparams:
                 return "\n".join(BLOCK_DEVS)
@@ -226,23 +227,23 @@ class MetaDataHandler(object):
                     return "\n".join(sorted(list(DEV_MAPPINGS.keys())))
                 else:
                     return str(subvalue)
-        elif action in ['hostname', 'local-hostname', 'public-hostname']:
+        elif action in ["hostname", "local-hostname", "public-hostname"]:
             # Just echo back there own hostname that they called in on..
             return "%s" % (who)
-        elif action == 'instance-type':
+        elif action == "instance-type":
             return random.choice(INSTANCE_TYPES)
-        elif action == 'ami-manifest-path':
-            return 'my-amis/spamd-image.manifest.xml'
-        elif action == 'security-groups':
-            return 'default'
-        elif action in ['local-ipv4', 'public-ipv4']:
+        elif action == "ami-manifest-path":
+            return "my-amis/spamd-image.manifest.xml"
+        elif action == "security-groups":
+            return "default"
+        elif action in ["local-ipv4", "public-ipv4"]:
             # Just echo back there own ip that they called in on...
-            return "%s" % (kwargs.get('client_ip', '10.0.0.1'))
-        elif action == 'reservation-id':
+            return "%s" % (kwargs.get("client_ip", "10.0.0.1"))
+        elif action == "reservation-id":
             return "r-%s" % (id_generator(lower=True))
-        elif action == 'product-codes':
+        elif action == "product-codes":
             return "%s" % (id_generator(size=8))
-        elif action == 'public-keys':
+        elif action == "public-keys":
             nparams = params[1:]
             # This is a weird kludge, why amazon why!!!
             # public-keys is messed up, list of /latest/meta-data/public-keys/
@@ -267,51 +268,55 @@ class MetaDataHandler(object):
                         hclient.NOT_FOUND, "Unknown key id %r" % mybe_key
                     ) from e
                 # Extract the possible sub-params
-                result = traverse(nparams[1:], {
-                    "openssh-key": "\n".join(avail_keys[key_name]),
-                })
+                result = traverse(
+                    nparams[1:],
+                    {
+                        "openssh-key": "\n".join(avail_keys[key_name]),
+                    },
+                )
                 if isinstance(result, (dict)):
                     # TODO(harlowja): This might not be right??
                     result = "\n".join(sorted(result.keys()))
                 if not result:
-                    result = ''
+                    result = ""
                 return result
             else:
                 contents = []
                 for (i, key_id) in enumerate(key_ids):
                     contents.append("%s=%s" % (i, key_id))
                 return "\n".join(contents)
-        elif action == 'placement':
+        elif action == "placement":
             nparams = params[1:]
             if not nparams:
                 pcaps = sorted(PLACEMENT_CAPABILITIES.keys())
                 return "\n".join(pcaps)
             else:
                 pentry = nparams[0].strip().lower()
-                if pentry == 'availability-zone':
+                if pentry == "availability-zone":
                     zones = PLACEMENT_CAPABILITIES[pentry]
                     return "%s" % random.choice(zones)
                 else:
-                    return "%s" % (PLACEMENT_CAPABILITIES.get(pentry, ''))
+                    return "%s" % (PLACEMENT_CAPABILITIES.get(pentry, ""))
         else:
-            log.warning(("Did not implement action %s, "
-                         "returning empty response: %r"),
-                        action, NOT_IMPL_RESPONSE)
+            log.warning(
+                "Did not implement action %s, returning empty response: %r",
+                action,
+                NOT_IMPL_RESPONSE,
+            )
             return NOT_IMPL_RESPONSE
 
 
 class UserDataHandler(object):
-
     def __init__(self, opts):
         self.opts = opts
 
     def _get_user_blob(self, **kwargs):
         blob = None
-        if self.opts['user_data_file'] is not None:
-            blob = self.opts['user_data_file']
+        if self.opts["user_data_file"] is not None:
+            blob = self.opts["user_data_file"]
         if not blob:
             blob_mp = {
-                'hostname': kwargs.get('who', 'localhost'),
+                "hostname": kwargs.get("who", "localhost"),
             }
             lines = [
                 "#cloud-config",
@@ -334,9 +339,8 @@ user_fetcher = None
 
 
 class Ec2Handler(BaseHTTPRequestHandler):
-
     def _get_versions(self):
-        versions = ['latest'] + EC2_VERSIONS
+        versions = ["latest"] + EC2_VERSIONS
         versions = sorted(versions)
         return "\n".join(versions)
 
@@ -347,33 +351,35 @@ class Ec2Handler(BaseHTTPRequestHandler):
     def _find_method(self, path):
         # Puke! (globals)
         func_mapping = {
-            'user-data': user_fetcher.get_data,
-            'meta-data': meta_fetcher.get_data,
+            "user-data": user_fetcher.get_data,
+            "meta-data": meta_fetcher.get_data,
         }
-        segments = [piece for piece in path.split('/') if len(piece)]
+        segments = [piece for piece in path.split("/") if len(piece)]
         log.info("Received segments %s", segments)
         if not segments:
             return self._get_versions
         date = segments[0].strip().lower()
         if date not in self._get_versions():
-            raise WebException(hclient.BAD_REQUEST,
-                               "Unknown version format %r" % date)
+            raise WebException(
+                hclient.BAD_REQUEST, "Unknown version format %r" % date
+            )
         if len(segments) < 2:
             raise WebException(hclient.BAD_REQUEST, "No action provided")
         look_name = segments[1].lower()
         if look_name not in func_mapping:
-            raise WebException(hclient.BAD_REQUEST,
-                               "Unknown requested data %r" % look_name)
+            raise WebException(
+                hclient.BAD_REQUEST, "Unknown requested data %r" % look_name
+            )
         base_func = func_mapping[look_name]
         who = self.address_string()
         ip_from = self.client_address[0]
         if who == ip_from:
             # Nothing resolved, so just use 'localhost'
-            who = 'localhost'
+            who = "localhost"
         kwargs = {
-            'params': list(segments[2:]),
-            'who': who,
-            'client_ip': ip_from,
+            "params": list(segments[2:]),
+            "who": who,
+            "client_ip": ip_from,
         }
         return functools.partial(base_func, **kwargs)
 
@@ -384,12 +390,13 @@ class Ec2Handler(BaseHTTPRequestHandler):
             func = self._find_method(self.path)
             data = func()
             if not data:
-                data = ''
+                data = ""
             self.send_response(hclient.OK)
             self.send_header("Content-Type", "binary/octet-stream")
             self.send_header("Content-Length", len(data))
-            log.info("Sending data (len=%s):\n%s", len(data),
-                     format_text(data))
+            log.info(
+                "Sending data (len=%s):\n%s", len(data), format_text(data)
+            )
             self.end_headers()
             self.wfile.write(data.encode())
         except RuntimeError as e:
@@ -407,7 +414,7 @@ class Ec2Handler(BaseHTTPRequestHandler):
         self._do_response()
 
 
-def setup_logging(log_level, fmt='%(levelname)s: @%(name)s : %(message)s'):
+def setup_logging(log_level, fmt="%(levelname)s: @%(name)s : %(message)s"):
     root_logger = logging.getLogger()
     console_logger = logging.StreamHandler(sys.stdout)
     console_logger.setFormatter(logging.Formatter(fmt))
@@ -417,27 +424,47 @@ def setup_logging(log_level, fmt='%(levelname)s: @%(name)s : %(message)s'):
 
 def extract_opts():
     parser = argparse.ArgumentParser()
-    parser.add_argument("-p", "--port", dest="port", action="store", type=int,
-                        default=80, metavar="PORT",
-                        help=("port from which to serve traffic"
-                              " (default: %default)"))
-    parser.add_argument("-a", "--addr", dest="address", action="store",
-                        type=str, default='::', metavar="ADDRESS",
-                        help=("address from which to serve traffic"
-                              " (default: %default)"))
-    parser.add_argument("-f", '--user-data-file', dest='user_data_file',
-                        action='store', metavar='FILE',
-                        help=("user data filename to serve back to"
-                              "incoming requests"))
-    parser.add_argument('extra', nargs='*')
+    parser.add_argument(
+        "-p",
+        "--port",
+        dest="port",
+        action="store",
+        type=int,
+        default=80,
+        metavar="PORT",
+        help="port from which to serve traffic (default: %default)",
+    )
+    parser.add_argument(
+        "-a",
+        "--addr",
+        dest="address",
+        action="store",
+        type=str,
+        default="::",
+        metavar="ADDRESS",
+        help="address from which to serve traffic (default: %default)",
+    )
+    parser.add_argument(
+        "-f",
+        "--user-data-file",
+        dest="user_data_file",
+        action="store",
+        metavar="FILE",
+        help="user data filename to serve back toincoming requests",
+    )
+    parser.add_argument("extra", nargs="*")
     args = parser.parse_args()
-    out = {'port': args.port, 'address': args.address, 'extra': args.extra,
-           'user_data_file': None}
+    out = {
+        "port": args.port,
+        "address": args.address,
+        "extra": args.extra,
+        "user_data_file": None,
+    }
     if args.user_data_file:
         if not os.path.isfile(args.user_data_file):
             parser.error("Option -f specified a non-existent file")
-        with open(args.user_data_file, 'rb') as fh:
-            out['user_data_file'] = fh.read()
+        with open(args.user_data_file, "rb") as fh:
+            out["user_data_file"] = fh.read()
     return out
 
 
@@ -455,14 +482,14 @@ def run_server():
     setup_logging(logging.DEBUG)
     setup_fetchers(opts)
     log.info("CLI opts: %s", opts)
-    server_address = (opts['address'], opts['port'])
+    server_address = (opts["address"], opts["port"])
     server = HTTPServerV6(server_address, Ec2Handler)
     sa = server.socket.getsockname()
     log.info("Serving ec2 metadata on %s using port %s ...", sa[0], sa[1])
     server.serve_forever()
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     run_server()
 
 # vi: ts=4 expandtab
diff --git a/tools/validate-yaml.py b/tools/validate-yaml.py
index d8bbcfcb..b5d77a97 100755
--- a/tools/validate-yaml.py
+++ b/tools/validate-yaml.py
@@ -12,8 +12,8 @@ if __name__ == "__main__":
     for fn in sys.argv[1:]:
         sys.stdout.write("%s" % (fn))
         try:
-            fh = open(fn, 'rb')
-            yaml.safe_load(fh.read().decode('utf-8'))
+            fh = open(fn, "rb")
+            yaml.safe_load(fh.read().decode("utf-8"))
             fh.close()
             sys.stdout.write(" - ok\n")
         except Exception as e: