diff options
| -rw-r--r-- | cloudinit/config/cc_mounts.py | 2 | ||||
| -rw-r--r-- | cloudinit/handlers/upstart_job.py | 2 | ||||
| -rw-r--r-- | cloudinit/sources/DataSourceAltCloud.py | 16 | ||||
| -rw-r--r-- | cloudinit/sources/DataSourceNoCloud.py | 4 | ||||
| -rw-r--r-- | cloudinit/sources/DataSourceOpenNebula.py | 2 | ||||
| -rw-r--r-- | cloudinit/util.py | 4 | 
6 files changed, 15 insertions, 15 deletions
| diff --git a/cloudinit/config/cc_mounts.py b/cloudinit/config/cc_mounts.py index eca6ea3f..339baba9 100644 --- a/cloudinit/config/cc_mounts.py +++ b/cloudinit/config/cc_mounts.py @@ -233,7 +233,7 @@ def setup_swapfile(fname, size=None, maxsize=None):      if str(size).lower() == "auto":          try:              memsize = util.read_meminfo()['total'] -        except IOError as e: +        except IOError:              LOG.debug("Not creating swap: failed to read meminfo")              return diff --git a/cloudinit/handlers/upstart_job.py b/cloudinit/handlers/upstart_job.py index 1ca92d4b..dc338769 100644 --- a/cloudinit/handlers/upstart_job.py +++ b/cloudinit/handlers/upstart_job.py @@ -97,7 +97,7 @@ def _has_suitable_upstart():              else:                  util.logexc(LOG, "dpkg --compare-versions failed [%s]",                              e.exit_code) -        except Exception as e: +        except Exception:              util.logexc(LOG, "dpkg --compare-versions failed")          return False      else: diff --git a/cloudinit/sources/DataSourceAltCloud.py b/cloudinit/sources/DataSourceAltCloud.py index f6e86f34..24fd65ff 100644 --- a/cloudinit/sources/DataSourceAltCloud.py +++ b/cloudinit/sources/DataSourceAltCloud.py @@ -184,11 +184,11 @@ class DataSourceAltCloud(sources.DataSource):              cmd = CMD_PROBE_FLOPPY              (cmd_out, _err) = util.subp(cmd)              LOG.debug('Command: %s\nOutput%s', ' '.join(cmd), cmd_out) -        except ProcessExecutionError as _err: -            util.logexc(LOG, 'Failed command: %s\n%s', ' '.join(cmd), _err) +        except ProcessExecutionError as e: +            util.logexc(LOG, 'Failed command: %s\n%s', ' '.join(cmd), e)              return False -        except OSError as _err: -            util.logexc(LOG, 'Failed command: %s\n%s', ' '.join(cmd), _err) +        except OSError as e: +            util.logexc(LOG, 'Failed command: %s\n%s', ' '.join(cmd), e)              return False          floppy_dev = '/dev/fd0' @@ -197,11 +197,11 @@ class DataSourceAltCloud(sources.DataSource):          try:              (cmd_out, _err) = util.udevadm_settle(exists=floppy_dev, timeout=5)              LOG.debug('Command: %s\nOutput%s', ' '.join(cmd), cmd_out) -        except ProcessExecutionError as _err: -            util.logexc(LOG, 'Failed command: %s\n%s', ' '.join(cmd), _err) +        except ProcessExecutionError as e: +            util.logexc(LOG, 'Failed command: %s\n%s', ' '.join(cmd), e)              return False -        except OSError as _err: -            util.logexc(LOG, 'Failed command: %s\n%s', ' '.join(cmd), _err) +        except OSError as e: +            util.logexc(LOG, 'Failed command: %s\n%s', ' '.join(cmd), e)              return False          try: diff --git a/cloudinit/sources/DataSourceNoCloud.py b/cloudinit/sources/DataSourceNoCloud.py index 5d3a8ddb..2daea59d 100644 --- a/cloudinit/sources/DataSourceNoCloud.py +++ b/cloudinit/sources/DataSourceNoCloud.py @@ -78,7 +78,7 @@ class DataSourceNoCloud(sources.DataSource):                  LOG.debug("Using seeded data from %s", path)                  mydata = _merge_new_seed(mydata, seeded)                  break -            except ValueError as e: +            except ValueError:                  pass          # If the datasource config had a 'seedfrom' entry, then that takes @@ -117,7 +117,7 @@ class DataSourceNoCloud(sources.DataSource):                      try:                          seeded = util.mount_cb(dev, _pp2d_callback,                                                 pp2d_kwargs) -                    except ValueError as e: +                    except ValueError:                          if dev in label_list:                              LOG.warning("device %s with label=%s not a"                                          "valid seed.", dev, label) diff --git a/cloudinit/sources/DataSourceOpenNebula.py b/cloudinit/sources/DataSourceOpenNebula.py index d4a41116..16c10785 100644 --- a/cloudinit/sources/DataSourceOpenNebula.py +++ b/cloudinit/sources/DataSourceOpenNebula.py @@ -378,7 +378,7 @@ def read_context_disk_dir(source_dir, asuser=None):          if asuser is not None:              try:                  pwd.getpwnam(asuser) -            except KeyError as e: +            except KeyError:                  raise BrokenContextDiskDir(                      "configured user '{user}' does not exist".format(                          user=asuser)) diff --git a/cloudinit/util.py b/cloudinit/util.py index c0473b8c..6ea6ca76 100644 --- a/cloudinit/util.py +++ b/cloudinit/util.py @@ -2531,8 +2531,8 @@ def _call_dmidecode(key, dmidecode_path):          if result.replace(".", "") == "":              return ""          return result -    except (IOError, OSError) as _err: -        LOG.debug('failed dmidecode cmd: %s\n%s', cmd, _err) +    except (IOError, OSError) as e: +        LOG.debug('failed dmidecode cmd: %s\n%s', cmd, e)          return None | 
