From fad919aa2c894abaa3af88aed1e064c1220937fe Mon Sep 17 00:00:00 2001 From: Daniel Watkins Date: Fri, 18 Dec 2020 12:29:38 -0500 Subject: stale: disable check for holiday break (#735) We're unlikely to see any activity on many PRs over the next couple of weeks, so don't close out inactive PRs for the duration. --- .github/workflows/stale.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to '.github') diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 20c5735d..7097a662 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -1,8 +1,8 @@ name: Mark and close stale pull requests -on: - schedule: - - cron: "0 0 * * *" # Daily @ 00:00 +#on: +# schedule: +# - cron: "0 0 * * *" # Daily @ 00:00 jobs: stale: -- cgit v1.2.3 From 3c076f4cd1e7110883c723b163bfc9ca8f9d3f7b Mon Sep 17 00:00:00 2001 From: Daniel Watkins Date: Fri, 18 Dec 2020 12:40:01 -0500 Subject: PULL_REQUEST_TEMPLATE.md: use backticks around commit message (#736) This makes it easier to copy/paste commit messages prepared elsewhere into the GitHub UI (and also means that the formatting in the GH UI more closely matches how the commit message will be consumed elsewhere). --- .github/PULL_REQUEST_TEMPLATE.md | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) (limited to '.github') diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2b59d10a..0aa97dd4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,17 +1,19 @@ ## Proposed Commit Message -> summary: no more than 70 characters -> -> A description of what the change being made is and why it is being -> made, if the summary line is insufficient. The blank line above is -> required. This should be wrapped at 72 characters, but otherwise has -> no particular length requirements. -> -> If you need to write multiple paragraphs, feel free. -> -> LP: #NNNNNNN (replace with the appropriate bug reference or remove -> this line entirely if there is no associated bug) +``` +summary: no more than 70 characters + +A description of what the change being made is and why it is being +made, if the summary line is insufficient. The blank line above is +required. This should be wrapped at 72 characters, but otherwise has +no particular length requirements. + +If you need to write multiple paragraphs, feel free. + +LP: #NNNNNNN (replace with the appropriate bug reference or remove +this line entirely if there is no associated bug) +``` ## Additional Context -- cgit v1.2.3 From e4f2d6139a802e659c571f581763eddeee715e2f Mon Sep 17 00:00:00 2001 From: Daniel Watkins Date: Fri, 18 Dec 2020 13:02:34 -0500 Subject: stale: fix error in definition (#740) This should fix the error, and also allows us to manually trigger the workflow. --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github') diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 7097a662..cec1311b 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -1,6 +1,6 @@ name: Mark and close stale pull requests -#on: +on: workflow_dispatch # schedule: # - cron: "0 0 * * *" # Daily @ 00:00 -- cgit v1.2.3 From c5f6c78623dd022c0ec45eb9917bbb39aafdca32 Mon Sep 17 00:00:00 2001 From: Daniel Watkins Date: Mon, 4 Jan 2021 17:46:04 -0500 Subject: stale: re-enable post holidays (#749) This reverts commits fad919aa2c894abaa3af88aed1e064c1220937fe ("stale: disable check for holiday break (#735)") and e4f2d6139a802e659c571f581763eddeee715e2f ("stale: fix error in definition (#740)"). --- .github/workflows/stale.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to '.github') diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index cec1311b..20c5735d 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -1,8 +1,8 @@ name: Mark and close stale pull requests -on: workflow_dispatch -# schedule: -# - cron: "0 0 * * *" # Daily @ 00:00 +on: + schedule: + - cron: "0 0 * * *" # Daily @ 00:00 jobs: stale: -- cgit v1.2.3 From 08d8902a95407d1f313ba1c679145d5f6b0df455 Mon Sep 17 00:00:00 2001 From: Daniel Watkins Date: Thu, 18 Feb 2021 18:11:32 -0500 Subject: stale.yml: don't ask submitters to reopen PRs (#816) Because they don't have the permissions to do it. Instead, reword the message to ask people to ping mitechie, in line with the rest of the message. --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github') diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 20c5735d..3b71ba28 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -20,5 +20,5 @@ jobs: If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon. - (If the pull request is closed, please do feel free to reopen it if you wish to continue working on it.) + (If the pull request is closed and you would like to continue working on it, please do tag mitechie to reopen it.) stale-pr-label: 'stale-pr' -- cgit v1.2.3 From 32860627535dfc1249088de36d1eb561a39851a9 Mon Sep 17 00:00:00 2001 From: Chris Patterson Date: Wed, 24 Nov 2021 09:29:10 -0500 Subject: github: update PR template's contributing URL (#1120) "HACKING" was renamed to "CONTRIBUTING", update the PR template URL accordingly. Signed-off-by: Chris Patterson --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github') diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0aa97dd4..017e82e4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -27,6 +27,6 @@ setup, and teardown. Scripts used may be attached directly to this PR. --> ## Checklist: - - [ ] My code follows the process laid out in [the documentation](https://cloudinit.readthedocs.io/en/latest/topics/hacking.html) + - [ ] My code follows the process laid out in [the documentation](https://cloudinit.readthedocs.io/en/latest/topics/contributing.html) - [ ] I have updated or added any unit tests accordingly - [ ] I have updated or added any documentation accordingly -- cgit v1.2.3 From 823a83bad1df0c13c02cf83b1e0dfd97c1913c69 Mon Sep 17 00:00:00 2001 From: James Falcon Date: Thu, 27 Jan 2022 21:29:58 -0600 Subject: Remove mitechie from stale PR github action (#1217) --- .github/workflows/stale.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to '.github') diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 3b71ba28..c763dafd 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -18,7 +18,7 @@ jobs: stale-pr-message: | Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. - If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon. + If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. - (If the pull request is closed and you would like to continue working on it, please do tag mitechie to reopen it.) + (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) stale-pr-label: 'stale-pr' -- cgit v1.2.3