From 3e2f7356effc9e9cccc5ae945846279804eedc46 Mon Sep 17 00:00:00 2001 From: Dimitri John Ledkov Date: Tue, 18 Feb 2020 17:03:24 +0000 Subject: utils: use SystemRandom when generating random password. (#204) As noticed by Seth Arnold, non-deterministic SystemRandom should be used when creating security sensitive random strings. --- cloudinit/util.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cloudinit/util.py b/cloudinit/util.py index d99e82fa..c02b3d9a 100644 --- a/cloudinit/util.py +++ b/cloudinit/util.py @@ -397,9 +397,10 @@ def translate_bool(val, addons=None): def rand_str(strlen=32, select_from=None): + r = random.SystemRandom() if not select_from: select_from = string.ascii_letters + string.digits - return "".join([random.choice(select_from) for _x in range(0, strlen)]) + return "".join([r.choice(select_from) for _x in range(0, strlen)]) def rand_dict_key(dictionary, postfix=None): -- cgit v1.2.3