From 9c33cb24b8a834aa8034db4c989725901a0814c6 Mon Sep 17 00:00:00 2001 From: Scott Moser Date: Mon, 22 May 2017 10:17:38 -0400 Subject: tox: move pylint target to 1.7.1 The motivation for this is to make tip-pylint target green. It does 2 things: a.) silence a warning that is generated in pylint 1.7.1, but not other versions of pylint. This bug in pylint is filed at https://github.com/PyCQA/pylint/issues/1444 b.) move tox -e pylint to use pylint 1.7.1 --- cloudinit/util.py | 5 +++-- tox.ini | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cloudinit/util.py b/cloudinit/util.py index 67ff7ba3..135e4608 100644 --- a/cloudinit/util.py +++ b/cloudinit/util.py @@ -478,10 +478,11 @@ def decomp_gzip(data, quiet=True, decode=True): try: buf = six.BytesIO(encode_text(data)) with contextlib.closing(gzip.GzipFile(None, "rb", 1, buf)) as gh: + # E1101 is https://github.com/PyCQA/pylint/issues/1444 if decode: - return decode_binary(gh.read()) + return decode_binary(gh.read()) # pylint: disable=E1101 else: - return gh.read() + return gh.read() # pylint: disable=E1101 except Exception as e: if quiet: return data diff --git a/tox.ini b/tox.ini index 826f554e..fce07740 100644 --- a/tox.ini +++ b/tox.ini @@ -18,7 +18,7 @@ setenv = LC_ALL = en_US.utf-8 [testenv:pylint] -deps = pylint==1.6.5 +deps = pylint==1.7.1 commands = {envpython} -m pylint {posargs:cloudinit} [testenv:py3] -- cgit v1.2.3