1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
|
# This file is part of cloud-init. See LICENSE file for license information.
from unittest import mock
from cloudinit.config import cc_lxd
from tests.unittests import helpers as t_help
from tests.unittests.util import get_cloud
class TestLxd(t_help.CiTestCase):
with_logs = True
lxd_cfg = {
"lxd": {
"init": {
"network_address": "0.0.0.0",
"storage_backend": "zfs",
"storage_pool": "poolname",
}
}
}
@mock.patch("cloudinit.config.cc_lxd.maybe_cleanup_default")
@mock.patch("cloudinit.config.cc_lxd.subp")
def test_lxd_init(self, mock_subp, m_maybe_clean):
cc = get_cloud()
mock_subp.which.return_value = True
m_maybe_clean.return_value = None
cc_lxd.handle("cc_lxd", self.lxd_cfg, cc, self.logger, [])
self.assertTrue(mock_subp.which.called)
# no bridge config, so maybe_cleanup should not be called.
self.assertFalse(m_maybe_clean.called)
self.assertEqual(
[
mock.call(["lxd", "waitready", "--timeout=300"]),
mock.call(
[
"lxd",
"init",
"--auto",
"--network-address=0.0.0.0",
"--storage-backend=zfs",
"--storage-pool=poolname",
]
),
],
mock_subp.subp.call_args_list,
)
@mock.patch("cloudinit.config.cc_lxd.maybe_cleanup_default")
@mock.patch("cloudinit.config.cc_lxd.subp")
def test_lxd_install(self, mock_subp, m_maybe_clean):
cc = get_cloud()
cc.distro = mock.MagicMock()
mock_subp.which.return_value = None
cc_lxd.handle("cc_lxd", self.lxd_cfg, cc, self.logger, [])
self.assertNotIn("WARN", self.logs.getvalue())
self.assertTrue(cc.distro.install_packages.called)
cc_lxd.handle("cc_lxd", self.lxd_cfg, cc, self.logger, [])
self.assertFalse(m_maybe_clean.called)
install_pkg = cc.distro.install_packages.call_args_list[0][0][0]
self.assertEqual(sorted(install_pkg), ["lxd", "zfsutils-linux"])
@mock.patch("cloudinit.config.cc_lxd.maybe_cleanup_default")
@mock.patch("cloudinit.config.cc_lxd.subp")
def test_no_init_does_nothing(self, mock_subp, m_maybe_clean):
cc = get_cloud()
cc.distro = mock.MagicMock()
cc_lxd.handle("cc_lxd", {"lxd": {}}, cc, self.logger, [])
self.assertFalse(cc.distro.install_packages.called)
self.assertFalse(mock_subp.subp.called)
self.assertFalse(m_maybe_clean.called)
@mock.patch("cloudinit.config.cc_lxd.maybe_cleanup_default")
@mock.patch("cloudinit.config.cc_lxd.subp")
def test_no_lxd_does_nothing(self, mock_subp, m_maybe_clean):
cc = get_cloud()
cc.distro = mock.MagicMock()
cc_lxd.handle("cc_lxd", {"package_update": True}, cc, self.logger, [])
self.assertFalse(cc.distro.install_packages.called)
self.assertFalse(mock_subp.subp.called)
self.assertFalse(m_maybe_clean.called)
def test_lxd_debconf_new_full(self):
data = {
"mode": "new",
"name": "testbr0",
"ipv4_address": "10.0.8.1",
"ipv4_netmask": "24",
"ipv4_dhcp_first": "10.0.8.2",
"ipv4_dhcp_last": "10.0.8.254",
"ipv4_dhcp_leases": "250",
"ipv4_nat": "true",
"ipv6_address": "fd98:9e0:3744::1",
"ipv6_netmask": "64",
"ipv6_nat": "true",
"domain": "lxd",
}
self.assertEqual(
cc_lxd.bridge_to_debconf(data),
{
"lxd/setup-bridge": "true",
"lxd/bridge-name": "testbr0",
"lxd/bridge-ipv4": "true",
"lxd/bridge-ipv4-address": "10.0.8.1",
"lxd/bridge-ipv4-netmask": "24",
"lxd/bridge-ipv4-dhcp-first": "10.0.8.2",
"lxd/bridge-ipv4-dhcp-last": "10.0.8.254",
"lxd/bridge-ipv4-dhcp-leases": "250",
"lxd/bridge-ipv4-nat": "true",
"lxd/bridge-ipv6": "true",
"lxd/bridge-ipv6-address": "fd98:9e0:3744::1",
"lxd/bridge-ipv6-netmask": "64",
"lxd/bridge-ipv6-nat": "true",
"lxd/bridge-domain": "lxd",
},
)
def test_lxd_debconf_new_partial(self):
data = {
"mode": "new",
"ipv6_address": "fd98:9e0:3744::1",
"ipv6_netmask": "64",
"ipv6_nat": "true",
}
self.assertEqual(
cc_lxd.bridge_to_debconf(data),
{
"lxd/setup-bridge": "true",
"lxd/bridge-ipv6": "true",
"lxd/bridge-ipv6-address": "fd98:9e0:3744::1",
"lxd/bridge-ipv6-netmask": "64",
"lxd/bridge-ipv6-nat": "true",
},
)
def test_lxd_debconf_existing(self):
data = {"mode": "existing", "name": "testbr0"}
self.assertEqual(
cc_lxd.bridge_to_debconf(data),
{
"lxd/setup-bridge": "false",
"lxd/use-existing-bridge": "true",
"lxd/bridge-name": "testbr0",
},
)
def test_lxd_debconf_none(self):
data = {"mode": "none"}
self.assertEqual(
cc_lxd.bridge_to_debconf(data),
{"lxd/setup-bridge": "false", "lxd/bridge-name": ""},
)
def test_lxd_cmd_new_full(self):
data = {
"mode": "new",
"name": "testbr0",
"ipv4_address": "10.0.8.1",
"ipv4_netmask": "24",
"ipv4_dhcp_first": "10.0.8.2",
"ipv4_dhcp_last": "10.0.8.254",
"ipv4_dhcp_leases": "250",
"ipv4_nat": "true",
"ipv6_address": "fd98:9e0:3744::1",
"ipv6_netmask": "64",
"ipv6_nat": "true",
"domain": "lxd",
}
self.assertEqual(
cc_lxd.bridge_to_cmd(data),
(
[
"network",
"create",
"testbr0",
"ipv4.address=10.0.8.1/24",
"ipv4.nat=true",
"ipv4.dhcp.ranges=10.0.8.2-10.0.8.254",
"ipv6.address=fd98:9e0:3744::1/64",
"ipv6.nat=true",
"dns.domain=lxd",
],
["network", "attach-profile", "testbr0", "default", "eth0"],
),
)
def test_lxd_cmd_new_partial(self):
data = {
"mode": "new",
"ipv6_address": "fd98:9e0:3744::1",
"ipv6_netmask": "64",
"ipv6_nat": "true",
}
self.assertEqual(
cc_lxd.bridge_to_cmd(data),
(
[
"network",
"create",
"lxdbr0",
"ipv4.address=none",
"ipv6.address=fd98:9e0:3744::1/64",
"ipv6.nat=true",
],
["network", "attach-profile", "lxdbr0", "default", "eth0"],
),
)
def test_lxd_cmd_existing(self):
data = {"mode": "existing", "name": "testbr0"}
self.assertEqual(
cc_lxd.bridge_to_cmd(data),
(
None,
["network", "attach-profile", "testbr0", "default", "eth0"],
),
)
def test_lxd_cmd_none(self):
data = {"mode": "none"}
self.assertEqual(cc_lxd.bridge_to_cmd(data), (None, None))
class TestLxdMaybeCleanupDefault(t_help.CiTestCase):
"""Test the implementation of maybe_cleanup_default."""
defnet = cc_lxd._DEFAULT_NETWORK_NAME
@mock.patch("cloudinit.config.cc_lxd._lxc")
def test_network_other_than_default_not_deleted(self, m_lxc):
"""deletion or removal should only occur if bridge is default."""
cc_lxd.maybe_cleanup_default(
net_name="lxdbr1", did_init=True, create=True, attach=True
)
m_lxc.assert_not_called()
@mock.patch("cloudinit.config.cc_lxd._lxc")
def test_did_init_false_does_not_delete(self, m_lxc):
"""deletion or removal should only occur if did_init is True."""
cc_lxd.maybe_cleanup_default(
net_name=self.defnet, did_init=False, create=True, attach=True
)
m_lxc.assert_not_called()
@mock.patch("cloudinit.config.cc_lxd._lxc")
def test_network_deleted_if_create_true(self, m_lxc):
"""deletion of network should occur if create is True."""
cc_lxd.maybe_cleanup_default(
net_name=self.defnet, did_init=True, create=True, attach=False
)
m_lxc.assert_called_with(["network", "delete", self.defnet])
@mock.patch("cloudinit.config.cc_lxd._lxc")
def test_device_removed_if_attach_true(self, m_lxc):
"""deletion of network should occur if create is True."""
nic_name = "my_nic"
profile = "my_profile"
cc_lxd.maybe_cleanup_default(
net_name=self.defnet,
did_init=True,
create=False,
attach=True,
profile=profile,
nic_name=nic_name,
)
m_lxc.assert_called_once_with(
["profile", "device", "remove", profile, nic_name]
)
# vi: ts=4 expandtab
|
