diff options
| author | Yuriy Andamasov <yuriy@vyos.io> | 2026-05-11 00:41:23 +0300 |
|---|---|---|
| committer | Yuriy Andamasov <yuriy@vyos.io> | 2026-05-11 00:41:23 +0300 |
| commit | bf50e7d11bc6c3c4224a7c6ea039755fe83558eb (patch) | |
| tree | 71f86868d745f3ac66559cdd44401a6933212cff /.github/workflows | |
| parent | 6aa6d83cdd95e514f0fa06258a8c1ba298a5dfd8 (diff) | |
| download | vyos-documentation-bf50e7d11bc6c3c4224a7c6ea039755fe83558eb.tar.gz vyos-documentation-bf50e7d11bc6c3c4224a7c6ea039755fe83558eb.zip | |
ci(ai-validation): refresh two stale comments after ubuntu-latest switch
Copilot review on the paired add-to-circinus PR (#1959) flagged two
documentation drifts from the ubuntu-latest switch in this PR:
1. Line 65: comment referenced a 'cp loop' but the implementation has
used 'git show HEAD:<path>' as the bundling mechanism since
1ea164ff. Reworded to describe the bundling loop accurately.
2. Line 270: comment explained why setup-uv was used 'on Debian 12' —
stale now that the workflow runs on ubuntu-latest. Reworded to
describe the actual reason setup-uv is preferred (fast interpreter
provisioning + portable to self-hosted Debian if this workflow
ever moves back).
Documentation-only change. No behavioral effect.
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/ai-validation.yml | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/.github/workflows/ai-validation.yml b/.github/workflows/ai-validation.yml index 1cad9e58..44952092 100644 --- a/.github/workflows/ai-validation.yml +++ b/.github/workflows/ai-validation.yml @@ -62,10 +62,11 @@ jobs: set -euo pipefail git fetch --depth=1 origin "${{ github.event.pull_request.base.ref }}" BASE="origin/${{ github.event.pull_request.base.ref }}" - # --diff-filter=ACMRT excludes Deleted entries so the cp loop below - # doesn't try to copy files that no longer exist in the merge ref. - # Deletions still appear in diff-md.patch (full diff) but not in - # changed-md.txt (which drives the file-copy step). + # --diff-filter=ACMRT excludes Deleted entries so the bundling + # loop below (`git show HEAD:<path>`) doesn't try to extract + # blobs for files that no longer exist in the merge ref. + # Deletions still appear in diff-md.patch (full diff) but not + # in changed-md.txt (which drives the bundling step). git diff "$BASE...HEAD" --name-only --diff-filter=ACMRT -z -- 'docs/**/*.md' > changed-md.z git diff "$BASE...HEAD" --name-only --diff-filter=ACMRT -z -- 'docs/**/*.rst' > changed-rst.z tr '\0' '\n' < changed-md.z > changed-md.txt @@ -267,10 +268,13 @@ jobs: exit 1 fi - # actions/setup-python prebuilt manifest does not ship Python 3.12 for - # Debian 12 (only Ubuntu). astral-sh/setup-uv installs uv (cross-platform) - # which then provisions Python 3.12 from Astral's standalone builds — - # works on Debian. activate-environment:true creates a .venv at + # astral-sh/setup-uv is used instead of actions/setup-python: uv + # provisions Python interpreters from Astral's standalone builds in a + # few seconds (no apt cache, no compile), and the same recipe works + # unchanged if this workflow ever moves back to a self-hosted Debian + # runner — actions/setup-python relies on a prebuilt manifest that + # only covers Ubuntu for some interpreter versions. + # activate-environment:true creates a .venv at # ${{ github.workspace }}/.venv and prepends its bin/ to PATH so the # `vyos-doc-review` CLI script is callable in subsequent steps. - name: Setup uv + Python 3.12 |