summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYuriy Andamasov <yuriy@vyos.io>2026-08-04 16:37:20 +0300
committerYuriy Andamasov <yuriy@vyos.io>2026-08-04 16:37:20 +0300
commit26bcf3497f8a753991aa8c19128f0ed274935f2d (patch)
tree6e895620caaee4b3b2146dac958143981ec3da1c
parentea6a61f3c36ce24bb8c966a5ae3f3b72934f644f (diff)
downloadvyos-documentation-26bcf3497f8a753991aa8c19128f0ed274935f2d.tar.gz
vyos-documentation-26bcf3497f8a753991aa8c19128f0ed274935f2d.zip
docs: update AGENTS.md bot-review section to current CodeRabbit realityagents-md-bot-workflow
The "Bot review workflow" section documented a manual-invocation flow that no longer matches how this repo works. Stale claims removed: - "Auto-reviews are disabled on this repo — both bots are triggered manually." CodeRabbit auto-review is enabled here; the per-repo disable override was lifted. - The 5-step workflow instructing contributors to comment `@copilot review` on a draft, iterate until Copilot is silent, then flip to ready and comment `@coderabbitai review`. - The two-row bot table pairing Copilot with drafts and CodeRabbit with ready PRs. Current reality documented instead: - CodeRabbit reviews automatically on the draft -> ready flip and on every subsequent push; drafts are always skipped. - CodeRabbit commonly edits its walkthrough comment in place rather than posting a new one, so the absence of a new comment is not the absence of a review. - A rate-limited CodeRabbit silently drops that review; commenting `@coderabbitai review` after the window resets is the only case where a manual trigger is appropriate. - Copilot is no longer part of the workflow and should not be invoked. Threads from a manual invocation by someone else are addressed like any other reviewer feedback. Also adds the missing AI Validation entry to the CI list: it cross-checks changed docs Markdown against the vyos-1x source tree for the corresponding branch and posts inline plus summary review comments, runs only when a PR touches docs Markdown, and skips when the required repository secrets are unavailable or the PR is a Mergify-authored backport. README.md's pointer to the contributor guide is updated in the same pass to drop Copilot from the named workflow. Note that .github/copilot-instructions.md is a symlink to AGENTS.md, so it picks up the change automatically. 🤖 Generated by [robots](https://vyos.io)
-rw-r--r--AGENTS.md45
-rw-r--r--README.md2
2 files changed, 27 insertions, 20 deletions
diff --git a/AGENTS.md b/AGENTS.md
index f445a7c7..f8845a80 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -292,6 +292,13 @@ serves and crawlers skip the redirect hop.
changed files under `docs/` only. Repo-root meta files
(README.md, AGENTS.md, `.github/copilot-instructions.md`) are out
of scope.
+- **AI Validation** (`.github/workflows/ai-validation.yml`) —
+ cross-checks the changed `docs/**/*.md` against the VyOS CLI
+ definitions in the `vyos-1x` source tree for the corresponding
+ branch, and posts findings as inline review comments plus a summary
+ comment on the PR. Only runs when a PR touches Markdown under
+ `docs/`. Skips — with a notice — when the required repository
+ secrets aren't configured, and on Mergify-authored backport PRs.
- **Sphinx build** — runs on Read the Docs for every PR; preview URL
appears as a check.
- **CLA check** — contributors must sign the VyOS CLA before merge.
@@ -299,22 +306,22 @@ serves and crawlers skip the redirect hop.
### Bot review workflow
-Two bots run at separate stages — do not mix them:
-
-| Bot | When to trigger | How |
-|-----|-----------------|-----|
-| **Copilot** | Draft PRs only | Comment `@copilot review` |
-| **CodeRabbit** | Ready-for-review PRs only | Comment `@coderabbitai review` |
-
-Auto-reviews are disabled on this repo — both bots are triggered
-manually via the comments shown above.
-
-Workflow:
-1. Open PR as draft (`gh pr create --draft`).
-2. Iterate; when complete, comment `@copilot review`.
-3. Address Copilot threads, re-request after each fix round until
- Copilot is silent.
-4. Flip to ready (`gh pr ready <num>`), then comment `@coderabbitai review`.
-5. Address CodeRabbit threads the same way.
-
-Never trigger `@copilot review` on a ready-for-review PR.
+CodeRabbit is the automated reviewer on this repo. It runs on its own —
+in the normal case there is nothing to invoke by hand. Iterate in draft
+while the work is in flux, then flip to ready when you want review.
+
+- **Drafts are skipped.** CodeRabbit ignores draft PRs entirely.
+- **Review fires automatically** when a PR is flipped to ready
+ (`gh pr ready <num>`), and again on every subsequent push.
+- **The walkthrough comment is edited in place.** CodeRabbit usually
+ updates its existing comment rather than posting a new one — for
+ example to "no actionable comments". No new comment does not mean no
+ new review; re-read the existing one.
+- **Rate limits silently drop a review.** If CodeRabbit is rate-limited
+ when an event fires, that review is skipped with no error. Comment
+ `@coderabbitai review` once the limit window resets. This is the only
+ case where triggering it by hand is appropriate.
+
+Copilot is not part of this workflow — do not invoke `@copilot review`.
+If Copilot threads do appear because someone invoked it manually,
+address them like any other reviewer feedback.
diff --git a/README.md b/README.md
index a1364b36..52c24e07 100644
--- a/README.md
+++ b/README.md
@@ -80,4 +80,4 @@ Output lands in `docs/_build/html/`.
See [AGENTS.md](AGENTS.md) for the full contributor guide — MyST source
conventions, the VyOS command directives (`cfgcmd` / `opcmd` /
`cmdincludemd`), IP-address rules, the linter and its suppression markers,
-and the Copilot/CodeRabbit bot review workflow.
+and the CodeRabbit bot review workflow.