diff options
| author | Yuriy Andamasov <yuriy@vyos.io> | 2026-07-22 18:30:57 +0300 |
|---|---|---|
| committer | Yuriy Andamasov <yuriy@vyos.io> | 2026-07-22 18:39:42 +0300 |
| commit | 95b8a4115439826e7dff767bf3515684535d0783 (patch) | |
| tree | 0b08b64b8ed468dbbc44d9cd19c2de9a7e83deb8 /scripts/docs_gates/test_smoke.py | |
| parent | 6ae607d4c37f2c61a5b06fc5649e46dac63eaac8 (diff) | |
| download | vyos-documentation-95b8a4115439826e7dff767bf3515684535d0783.tar.gz vyos-documentation-95b8a4115439826e7dff767bf3515684535d0783.zip | |
docs-gates: widen smoke retry envelope for worker-version propagation (5 rounds x 30s)
The merge-triggered smoke run for the round-based retry work failed on a
worker-version propagation race that outlasted the 3-round x 20s envelope: all
probes were served the previous SHA through rounds 1-2 and one path (cli.html)
was still stale at round 3 (2 sleeps x 20s = 40s insufficient).
Widen to MAX_ROUNDS=5 / RETRY_SLEEP_SECONDS=30 -> 4 inter-round sleeps x 30s =
2 min, covering the observed 1-2+ min propagation waves. The green path is
unaffected (no retries -> zero added time); DEADLINE_SECONDS=480 still bounds the
worst case. Tests read the constants dynamically (monkeypatch), so none pin the
old literals.
🤖 Generated by [robots](https://vyos.io)
Diffstat (limited to 'scripts/docs_gates/test_smoke.py')
| -rw-r--r-- | scripts/docs_gates/test_smoke.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/docs_gates/test_smoke.py b/scripts/docs_gates/test_smoke.py index d32ec0cb..f0a37c7a 100644 --- a/scripts/docs_gates/test_smoke.py +++ b/scripts/docs_gates/test_smoke.py @@ -292,7 +292,7 @@ def test_httperror_response_is_closed_even_when_read_raises(monkeypatch): urllib.error.HTTPError("https://host.invalid/x", 502, "msg", Message(), body)])) probe = smoke.Probe("/en/rolling/index.html", 200, assert_docs_build=False, assert_apex_build=False) - ok, status, docs_build, detail = smoke._probe_once("host", probe, "sha", "id", "sec") + ok, _, _, detail = smoke._probe_once("host", probe, "sha", "id", "sec") assert ok is False assert detail is not None and "reset during body read" in detail assert body.close_calls >= 1 # close still attempted despite the read raising @@ -328,6 +328,6 @@ def test_probe_once_detail_joins_multiple_failed_checks(monkeypatch): # wrong status AND missing X-Apex-Build → detail "status+apex-build" monkeypatch.setattr(smoke, "_OPENER", _FakeOpener([_FakeResp(500, {})])) probe = smoke.Probe("/versions.json", 200, assert_docs_build=False, assert_apex_build=True) - ok, status, docs_build, detail = smoke._probe_once("host", probe, "sha", "id", "sec") + ok, _, _, detail = smoke._probe_once("host", probe, "sha", "id", "sec") assert ok is False assert detail == "status+apex-build" |
