From f6ef27d087a4cae08b122e73b7c46771d1a6764b Mon Sep 17 00:00:00 2001
From: Yuriy Andamasov <yuriy@vyos.io>
Date: Mon, 11 May 2026 01:11:54 +0300
Subject: ci(ai-validation): skip Pass 1/2 when PR has no .md changes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

actions/upload-artifact silently omits empty directories. On a PR that
changes no docs/**/*.md (workflow tweaks, README edits, config), the
prepare job's _changed_md/ ends up empty and is dropped from the
artifact. The validate job downloads the artifact, then "Pass 1 —
deterministic checks" tries to start with `working-directory:
_changed_md`, which doesn't exist, and bash fails before any in-step
short-circuit can run.

Surface a `has_md_changes` output from prepare based on whether
changed-md.txt is non-empty, and gate Pass 1 + Pass 2 on it. When the
flag is false, both review steps skip cleanly with no failure noise.

Affects all infrastructure-only PRs (CI changes, workflow updates,
config tweaks). Same failure was visible on the in-flight backports
of update-version-tags hardening (#1965, #1966) which are pure
workflow changes.

🤖 Generated by [robots](https://vyos.io)
---
 .github/workflows/ai-validation.yml | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ai-validation.yml b/.github/workflows/ai-validation.yml
index 44952092..738faf60 100644
--- a/.github/workflows/ai-validation.yml
+++ b/.github/workflows/ai-validation.yml
@@ -49,6 +49,14 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       contents: read
+    outputs:
+      # Surface whether the PR touched any docs/**/*.md so validate's review
+      # steps can skip on infrastructure-only PRs (workflow/config/README
+      # changes). actions/upload-artifact silently omits empty directories
+      # — when no .md files change, _changed_md/ isn't uploaded, and
+      # validate's working-directory: _changed_md would otherwise fail
+      # before any in-step short-circuit can run.
+      has_md_changes: ${{ steps.changes.outputs.has_md_changes }}
     steps:
       - name: Checkout PR merge ref (NO credentials)
         uses: actions/checkout@v6
@@ -58,6 +66,7 @@ jobs:
           fetch-depth: 2
 
       - name: Compute changed files and bundle .md content
+        id: changes
         run: |
           set -euo pipefail
           git fetch --depth=1 origin "${{ github.event.pull_request.base.ref }}"
@@ -122,6 +131,12 @@ jobs:
             git show "HEAD:$path" > "_changed_md/$path"
           done < changed-md.z
 
+          if [ -s changed-md.txt ]; then
+            echo "has_md_changes=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "has_md_changes=false" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Upload PR input artifact
         uses: actions/upload-artifact@v4
         with:
@@ -312,7 +327,7 @@ jobs:
       # Pass 1 would emit zero findings — a silent failure mode the
       # §3.6 fail-closed gate cannot catch when the DB is present.
       - name: Pass 1 — deterministic checks
-        if: steps.secrets-check.outputs.skip != 'true' && steps.download-db.outcome == 'success'
+        if: steps.secrets-check.outputs.skip != 'true' && steps.download-db.outcome == 'success' && needs.prepare.outputs.has_md_changes == 'true'
         working-directory: _changed_md
         run: |
           vyos-doc-review pass1 \
@@ -321,7 +336,7 @@ jobs:
             --output ../pass1-findings.json
 
       - name: Pass 2 — Claude review
-        if: steps.secrets-check.outputs.skip != 'true'
+        if: steps.secrets-check.outputs.skip != 'true' && needs.prepare.outputs.has_md_changes == 'true'
         uses: anthropics/claude-code-action@v1
         with:
           anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
-- 
cgit v1.2.3