From 82a06e1dc812ceba239aaabf4acd651a038bfee7 Mon Sep 17 00:00:00 2001
From: Yuriy Andamasov <yuriy@vyos.io>
Date: Wed, 13 May 2026 23:18:29 +0300
Subject: fix(includes): rewrite need_improvement.txt as MyST so plain
 `{include}` renders correctly
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

After the RST→MyST migration, ~45 MD pages use the plain `{include}` MyST
directive to pull in `_include/need_improvement.txt`. The included file
still contained RST (`.. raw:: html`, `.. raw:: latex`, `:ref:`), and
MyST's built-in `{include}` parses the content with the *outer* file's
parser — i.e. as MyST. RST directives then render as literal paragraphs.

Visible symptom on docs.vyos.io/en/rolling (and across 1.5/1.4):
the VPP index, VPP subpages, haproxy, isis, bfd, policy, pki, salt,
flowtables, webproxy, and others all show:

  .. raw:: latex
  \iffalse
  .. raw:: html
  Call for Contributions
  Help improve this section ...
  For contribution guidelines, see :ref: documentation .

Fix: rewrite `_include/need_improvement.txt` as a native MyST admonition
(`:::{admonition} Call for Contributions / :class: error / ... / :::`)
and drop the now-unnecessary `{eval-rst}` wrapper at the single callsite
(`configuration/highavailability/index.md`) that wrapped the include for
RST processing.

The fix is companion to 9c815d68 (cmdincludemd RST plumbing) but targets
the plain-`{include}` path which doesn't route through our custom
extension.

🤖 Generated by [robots](https://vyos.io)
---
 docs/_include/need_improvement.txt | 22 ++++------------------
 1 file changed, 4 insertions(+), 18 deletions(-)

(limited to 'docs/_include')

diff --git a/docs/_include/need_improvement.txt b/docs/_include/need_improvement.txt
index e368ee95..c95260ee 100644
--- a/docs/_include/need_improvement.txt
+++ b/docs/_include/need_improvement.txt
@@ -1,21 +1,7 @@
-.. raw:: latex
-
-    \iffalse
-
-.. raw:: html
-
-   <div class="admonition error">
-   <p class="admonition-title">Call for Contributions</p>
-
+:::{admonition} Call for Contributions
+:class: error
 
 Help improve this section with additional content, examples, and explanations.
 
-For contribution guidelines, see :ref:`documentation`.
-
-.. raw:: html
-
-   </div>
-
-.. raw:: latex
-
-    \fi
\ No newline at end of file
+For contribution guidelines, see {ref}`documentation`.
+:::
-- 
cgit v1.2.3