(mirror of https://github.com/vyos/vyos-live-build.git) https://git.amelek.net/vyos/vyos-live-build.git/atom?h=master 2020-05-05T18:55:28+00:00 2020-05-05T18:55:28+00:00 Lyndon Brown jnqnfe@gmail.com 2020-05-05T15:45:57+00:00 urn:sha1:18eefdd6f38631e15e56a2bd7a25bba50b05acfa it removes one or more, so should be plural for clarity Gbp-Dch: Short 2020-05-05T18:55:28+00:00 Lyndon Brown jnqnfe@gmail.com 2020-05-05T15:42:44+00:00 urn:sha1:919a464b64b4bda52a56b8732ea5ef7727649cf0 it installs one or more, so should be plural for clarity Gbp-Dch: Short 2020-05-04T21:15:09+00:00 Lyndon Brown jnqnfe@gmail.com 2020-05-04T17:20:02+00:00 urn:sha1:a542d52141acef0e2d2bb78253d6b5df4305dcd1 when loopback support was introduced, it initially duplicated the code for generating a grub2 config, before the duplicated code was removed from the grub-pc script, effectively thus moving grub config generation to the loopback feature script. grub-efi support was added after this. this results in a misleading filename, since the `binary_loopback_cfg` script is essential for use of grub-pc|grub-efi, and actually only has a single line of code on top that's needed for adding actual loopback support on top. (when grub-pc and grub-efi are not used, the entire script is still needed for loopback support to work). so here we rename it to make better sense, and correct/clarify bits of documentation. Gbp-Dch: Short 2020-05-04T20:40:13+00:00 Lyndon Brown jnqnfe@gmail.com 2020-05-04T15:12:45+00:00 urn:sha1:d7883ec32b2bb907fce17fb759c08c5cd9851fc3 the design choice from when EFI support was introduced was to change `--bootloader` to `--bootloaders`, with users specifying their selection of BIOS and EFI bootloaders together. at this time there were not even any decent validation checks being performed, and invalid combinations could cause some chaos. since then proper validation was put in place, including checking that only a single instance of each of BIOS and EFI bootloaders exists in the selection. here we tweak things such that we stick with the same option, but we split the selection up such that we store the BIOS and EFI selections separately within the saved config file, and offer it up to scripts to help simplify those scripts. we must however retain support for splitting from the combined option, both because we still use it in the combined option, and for backwards compatibility with older saved configs. Gbp-Dch: Short 2020-05-04T20:40:13+00:00 Lyndon Brown jnqnfe@gmail.com 2020-05-04T13:28:37+00:00 urn:sha1:3f840aeeba982a858a881271a3bb48bca5b50dd8 thus far, config bootloader validation only did the basic check that each bootloader specified was a known and supported bootloader, it did not check combinations. it now checks combinations, and strips out the previous "bootloader role" stuff. the no-bootloaders warning is duplicated, covering two slightly different situations (empty string, and whitespace string). this is anticipated to be just temporary, with this just being the first step in better handling bootloader selections. Gbp-Dch: Short 2020-04-23T16:54:31+00:00 Lyndon Brown jnqnfe@gmail.com 2020-04-06T17:46:47+00:00 urn:sha1:500f2050739e8cb902d710d1ae6b3f5de4d00dcd no backwards compatibility hack for reading the old var from existing saved config used because this was previously stored in the alternate format config/build file. Gbp-Dch: Short 2020-04-23T15:59:39+00:00 Lyndon Brown jnqnfe@gmail.com 2020-04-08T19:27:41+00:00 urn:sha1:bf63762721ddfa497e1b6e4b311178fd68a0b012 the grub-pc image creation code has no business being in binary_iso, it should be in binary_grub-pc. it should be noted that the binary_iso script did not even have the necessary package check for grub-mkimage, while binary_grub-pc did have it, pointlessly. Gbp-Dch: Short 2020-04-23T13:08:07+00:00 Lyndon Brown jnqnfe@gmail.com 2020-03-28T08:17:28+00:00 urn:sha1:554a8d11088181e666a04558230e94b19f32f2d6 - add a validation check where an error will be printed - replace the check done in the grub scripts with one that simple exits if executed bypassing the validation check Gbp-Dch: Short 2020-04-23T12:51:09+00:00 Lyndon Brown jnqnfe@gmail.com 2020-03-28T05:13:11+00:00 urn:sha1:39e4d3e3cbcc8d37700cfe46a95f669b4d9479ea whilst some parts of the codebase were set up to work with multiple types specified, others did not work with it and would not necessarily be easy to adjust. this thus makes some tweaks to adjust things accordingly. - option renamed to singular form (maintaining backwards compatibility) - a validation check has been added - unnecessary glob style type references fixed - checks with In_list changed to a direct singular comparison - typo of type "netboot" written as just "net" fixed (though unreachable so of no consequence; really the code could be removed but it's trivial) Gbp-Dch: Short 2020-03-17T22:59:37+00:00 Lyndon Brown jnqnfe@gmail.com 2020-03-15T13:05:44+00:00 urn:sha1:fb0790cc4379280084cc9a4469a515e243f45b9b this function takes one or more required stage fileS _plural_, and exits if any are missing (or at least it does now after the refactor). let's rename it to make things more clear Gbp-Dch: Short