(mirror of https://github.com/vyos/vyos-live-build.git) https://git.amelek.net/vyos/vyos-live-build.git/atom?h=cla 2020-05-03T00:31:47+00:00 2020-05-03T00:31:47+00:00 Lyndon Brown jnqnfe@gmail.com 2020-05-02T23:58:18+00:00 urn:sha1:43b4f9cdf62972bff5cff45f895305c391a895f2 did not properly consider all usage cases properly in deciding placement. this captured `--usage` in `$PROGRAM --usage` as the action for instance. Gbp-Dch: Ignore 2020-05-02T13:04:12+00:00 Lyndon Brown jnqnfe@gmail.com 2020-05-02T12:43:22+00:00 urn:sha1:b20979334cc28c345b2b72da30c3591fb5c85882 for bootstrap, the check is moved to the case statement for greater robustness, and for consistency with other scripts. Gbp-Dch: Ignore 2020-04-30T05:20:52+00:00 Lyndon Brown jnqnfe@gmail.com 2020-04-30T04:48:08+00:00 urn:sha1:647dcb7aeddc71c9637e1487de1c3f61e49ae978 during testing i encountered an unexpected error resulting from the following condition: - bootstrap was cached - cache of bootstrap packages was empty (from playing with `lb clean`) - installer was not none|live everything works fine up until the main installer script, which comes to an abrupt halt with an error due to the missing cached bootstrap packages that it wants to copy. this situation is easy to unintentionally create, as i managed to do. here we catch the failure condition, correcting for it. this is done by checking for the missing cached packages when restoring the bootstrap from the cache, and skipping this if the packages were missing, thus forcing the bootstrap to be rebuilt. the packages should then be found within the cache, allowing the installer stage to complete successfully. of course the bootstrap stage will only cache the packages if caching is enabled, but if caching is disabled and installer enabled, the config validation will catch that, reporting that problem. Gbp-Dch: Short 2020-04-23T13:53:30+00:00 Lyndon Brown jnqnfe@gmail.com 2020-03-30T14:17:52+00:00 urn:sha1:6def2c27be28169cf3e0757a6928e3f13de157a8 Gbp-Dch: Ignore 2020-04-23T13:53:12+00:00 Lyndon Brown jnqnfe@gmail.com 2020-03-30T14:09:41+00:00 urn:sha1:430c48640c6b5523f8da65561f62d25b6a7efbb2 makes them consistent with other similar script-specific param handling; saves the arg processing from dealing with it. Gbp-Dch: Short 2020-04-01T18:03:20+00:00 Lyndon Brown jnqnfe@gmail.com 2020-04-01T01:19:43+00:00 urn:sha1:1716958a8dd4b52b1d437a29d268c949b83767c0 2020-03-17T22:09:51+00:00 Lyndon Brown jnqnfe@gmail.com 2020-03-17T22:09:51+00:00 urn:sha1:dadeec9d396382d42bae0cf490dc55456fa71199 missed in final revision of fe9195b59c9647598ecea00900edfe2678bddcac Gbp-Dch: Ignore 2020-03-17T18:57:02+00:00 Lyndon Brown jnqnfe@gmail.com 2020-03-13T17:11:53+00:00 urn:sha1:fe9195b59c9647598ecea00900edfe2678bddcac as suggested by Raphaël rather than have fixed stagefile filename strings at all in the scripts, use `$(basename $0)` to use the name of the script (which is the same for almost all cases anyway, and the stage files are supposed to be almost exclusively unique per-script). we can thus simplify things by determining the filename for most use cases within the functions themselves. this does change the file used by a couple of scripts, affecting backwards compatibility of executing live-build upon an existing partially or fully completed build: - binary_grub-pc used "binary_grub" - chroot_includes used "includes.chroot" care had to be taken for the following cases: - there are some cases like bootstrap_cache, source_debian and bootstrap_debootstrap which are dealing with more than one file, and/or otherwise a filename that is not specific to the script itself exactly, or should not be based upon its name. - some cases like chroot_cache, bootstrap_cache and chroot_install-packages need to append something to the end of the name depending upon which pass/action mode the script is being executed with. - furthermore in the bootstrap_cache case one of the filenames is used within the bootstrap_debootstrap and thus needs very careful handling to be certain that a change in filename of bootstrap_cache does not break bootstrap_debootstrap. Gbp-Dch: Short 2020-03-17T18:57:02+00:00 Lyndon Brown jnqnfe@gmail.com 2020-03-12T01:21:39+00:00 urn:sha1:04d9ee0211e7cf2d5f637941ff6579b4f5462da6 - avoid all need to pass ".build/" path in stage file names into the functions - add a helper to remove a stage file (required to complete the above properly) - avoid duplicating filenames within scripts which makes them prone to mistakes (some instances of which I've actually encountered and had to fix) Gbp-Dch: Short 2020-03-13T16:19:59+00:00 Lyndon Brown jnqnfe@gmail.com 2020-03-13T16:19:59+00:00 urn:sha1:a46985b08ac8b8c73d8a3965ee83daa4d4c41e22 Gbp-Dch: Ignore