(mirror of https://github.com/vyos/vyos-live-build.git) https://git.amelek.net/vyos/vyos-live-build.git/atom?h=debian%2F3.0_a53-1 2012-06-04T09:55:22+00:00 2012-06-04T09:55:22+00:00 Daniel Baumann daniel@debian.org 2012-06-04T08:52:28+00:00 urn:sha1:434307c22d192e1f937915b417615f62b3b6bead 2012-06-03T20:42:41+00:00 Daniel Baumann daniel@debian.org 2012-06-03T20:42:41+00:00 urn:sha1:aa0c0fb107cf821ca5b85e0f8156442eaa9c3dd7 2012-02-06T22:15:12+00:00 Daniel Baumann daniel@debian.org 2012-02-04T20:41:41+00:00 urn:sha1:822dc2c028390575c13e3546b80b308ab51395c4 2012-01-10T20:54:58+00:00 Matthijs Kooijman matthijs@stdin.nl 2012-01-10T20:01:06+00:00 urn:sha1:58209e8bd8b7c159c64405cde9e127de54af293f This reverts part of cacf9b6e34 (but also adds a "bind" option to the remount command, as documented in mount(8)). Apparently, doing "mount -o bind,ro" doesn't work. It outputs: mount: warning: chroot/root/config seems to be mounted read-write. and mounts read-write instead of read-only. This behaviour is documented in mount(8). Newer kernels do seem to allow combining bind with the read-only option (see mount(2)), but this does not seem to work (possibly because mount is trying to be smart). 2012-01-10T20:54:58+00:00 Matthijs Kooijman matthijs@stdin.nl 2012-01-10T19:11:52+00:00 urn:sha1:e7ecf56be3df3623bb3e78a85598f74dbd08b6a0 Previously, the config was bindmounted inside the chroot only for hooks from the config dir, now it is done earlier so it is available for all hooks. Note that it is now also done if there are no hooks, but this is probably enough of an exception case to not warrant the extra plumbing required to detect the case (and doing an extra bindmount shouldn't really hurt anyway...). 2012-01-10T20:54:58+00:00 Matthijs Kooijman matthijs@stdin.nl 2012-01-10T18:38:02+00:00 urn:sha1:ea491a1a1a81fecfe43ff02a9a627a9f9a9eea85 lb_chroot_hooks would copy the hooks to run to chroot/root/lb_chroot_hooks, but then try to run them from chroot/root (which obviously fails). This means lb_chroot_hooks has not been working for hooks from /usr/share/live/build/hooks since lb_chroot_hooks was added in revision e4793268. Running hooks from the config directory was unaffected. 2012-01-10T20:54:58+00:00 Matthijs Kooijman matthijs@stdin.nl 2012-01-10T13:44:42+00:00 urn:sha1:dbe6a82bc031ecc8d9ba4230350bdd6277f905f6 Apparently, dash doesn't expand shell patterns within a quoted string, whereas bash does. We can't remove the quoting entirely, though, since that would cause problems when $LB_BASE or $_HOOK contains spaces (note that $_HOOK can probably never contain spaces, but let's handle it just in case). Only quoting the expansion of $LB_BASE and $_HOOK, but not the shell pattern should make the hooks work with both bash and dash again. 2011-07-25T16:05:40+00:00 Daniel Baumann daniel@debian.org 2011-07-25T16:05:40+00:00 urn:sha1:cacf9b6e34d08aaf8f1637d9b14b1db4219582a2 2011-07-21T16:35:56+00:00 Cody A.W. Somerville cody.somerville@canonical.com 2011-07-21T16:35:56+00:00 urn:sha1:50816947a79f9f407e237cca563a14f2a33b76d5 2011-07-19T14:45:36+00:00 Daniel Baumann daniel@debian.org 2011-07-19T14:45:36+00:00 urn:sha1:b70ec215abe8999a67f95d02305d722adf760620