vyos-live-build.git/share/hooks/normal/0430-update-mlocate-database.hook.chroot, branch rolling

Replace 'which' with 'command -v' to test for the existance of an executable

2020-05-01T09:59:11+00:00

This is considered to be more robust. Two instances remain: scripts/build/chroot_archives, line 257: if [ "${LB_APT}" = "aptitude" ] && [ ! $(Chroot chroot "which aptitude") ] The command is run inside a chroot where the environment might be special, and would need further testing. manpages/Makefile, line 42: @if [ ! -x "$$(which po4a 2>/dev/null)" ]; \ I am insufficiently familiar with makefile syntax to edit this.

Revert "Test for executables: replace 'which' with more robust 'command -v'"

2020-03-12T12:32:26+00:00

This reverts commit 2d9ab1f7f82f9a98b97d1503c1e3f31c86061c15. Causes test failure due to bashism.

Test for executables: replace 'which' with more robust 'command -v'

2020-03-12T10:35:57+00:00

Instances of: if [ $(which ] have been replaced with: if command -v >/dev/null which is considered to be more robust in a range of environments. scripts/build/chroot_archives: line 259: if [ "${LB_APT}" = "aptitude" ] && [ ! $(Chroot chroot "which aptitude") ] has been left untouched because the chroot might require a more complex command which would need more testing. manpages/Makefile: line 42: @if [ ! -x "$$(which po4a 2>/dev/null)" ]; \ has been left untouched because I am not sufficiently familiar with makefiles.

fix consistency in binary execution and existance checking

2020-03-09T10:51:11+00:00

- prefer using `which` over hard coded paths - it is redundant to check that the bin pointed to the return of `which` exists and is executable, `which` already gives us assurance of that if it returns true! - the redirection of output (`2>/dev/null`) seems to be unnecessary from my testing. the instances relatnig to fdisk and losetup in functions/defaults.sh have been left as they are since they get executed by `lb config` which can run without sudo elevation unlike `lb build` and in that case `which` would fail to find these binaries resulting in error. this also fixes a bug showing an error for missing debootstrap - this tool requires sudo privileges to run and thus is not found via a none elevated which search. Gbp-Dch: Short Closes: #952927

Splitting non-live specific hooks into their own subdirectory within hooks.

2015-05-20T06:19:56+00:00