summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-23config: obsolete unused --isohybrid-options optionLyndon Brown
2020-04-23config: apt-get should probably be an allowed and documented --apt valueLyndon Brown
since everywhere where 'apt' is a permitted value, 'apt-get' is also, it just wasn't listed in the option's documentation and thus was also not listed in the new validation check. Gbp-Dch: Short
2020-04-23config: fix broken backwards compatibility hackLyndon Brown
80aa5ab61100b6b11ae47984bab9a2eb988074f5 implemented a hack to handle replacement of LB_LINUX_FLAVOURS with LB_LINUX_FLAVOURS_WITH_ARCH in config files, but implemented it in the wrong place. adding a conditional conversion within the config file meant that the old value would only be read from **new** config files that are created obviously without it, including re-saved configs if `lb config` were re-run with additional options (not recommended). any existing value in an existing config file would actually be ignored. the right place to read the old value was in the Set_defaults() function (since renamed). a second issue also existed with the hack, it failed to excape the `$` and thus printed the existing value of $LB_LINUX_FLAVOURS into the conditional check being constructed in the config file, instead of printing the name of the variable. the check embedded into the config file thus became this on an amd64 machine: ``` if [ -n "amd64" ] then LB_LINUX_FLAVOURS_WITH_ARCH="amd64" fi ``` which is clearly not what was intended. Gbp-Dch: Short
2020-04-23config: stop writing 'default: <foo>' lines to config filesLyndon Brown
while helpful for users to know the defaults, the values printed as the supposed defaults for most are actually the same values as being configured, or in some cases a piece of text "autodetected or empty", and thus the information is completely wrong and actually unhelpful since it misinforms the user. fixing this to give the real defaults is very much non-trivial. as a workaround users wanting to know the default for an option can always: a. use `lb config` wit no options (or auto) in a clean directory and thus get a config with all defaults. b. look at the live-build code. if they just want to reset an option, they can also just comment it out. Gbp-Dch: Short Closes: #904614
2020-04-23installer: rework validation check for installer typeLyndon Brown
(and move the wget options setting down where it should be while at it) the value of LB_DEBIAN_INSTALLER is now properly checked in the main validation routine, so we can just directly exit here as a simple safety check should validation be bypassed. Gbp-Dch: Short
2020-04-23config: add missing deprecation warningLyndon Brown
Gbp-Dch: Ignore
2020-04-23config: minor reorganisationLyndon Brown
Gbp-Dch: Ignore
2020-04-23config: strip unhelpful commentsLyndon Brown
Gbp-Dch: Ignore
2020-04-23config: expand validation coverageLyndon Brown
to cover checking available value choices Gbp-Dch: Short
2020-04-23config: reorganise validation checksLyndon Brown
splitting into two parts will make things much tidier Gbp-Dch: Short
2020-04-23tidy up grub bootloader compatibility checkingLyndon Brown
- add a validation check where an error will be printed - replace the check done in the grub scripts with one that simple exits if executed bypassing the validation check Gbp-Dch: Short
2020-04-23config: tidy validationLyndon Brown
2020-04-23config: merge defaults.sh and configuration.sh, part 2Lyndon Brown
...and second we then change the filename Gbp-Dch: Short
2020-04-23config: merge defaults.sh and configuration.sh, part 1Lyndon Brown
the stuff in defaults.sh is only partially to do with setting default config values, it also does other prep work like centralised comma separated value to space separated conversion, and validation. this is split into two parts to keep the diff simple, first we move the two small functions from configuration.sh into default.sh... Gbp-Dch: Short
2020-04-23config: better handle error conditionLyndon Brown
Gbp-Dch: Ignore
2020-04-23config: reorganise the option case blockLyndon Brown
move away from the somewhat config file grouping based organisation to an alphabetised list, after grouping into script-specific; general; build-specific and other. the config file based organisation was a bad choice, making it hard to find the right place to insert options for instance. Gbp-Dch: Short
2020-04-23config: organise getopt longoption setLyndon Brown
alphabetised per line lists, broken up into multiple lines where exceeding 80 chars. Gbp-Dch: Short
2020-04-23config: remove spurious secondary validation checkLyndon Brown
it is already done just before writing the config to disk; this check is happening just after doing so and is thus pointless. Gbp-Dch: Short
2020-04-23config: add --validate optionLyndon Brown
running `lb config --validate` causes the script to stop after running the validation check on the config compiled at that point, prior to writing the config to disk. this gives users the ability to check the validity of a config without modifying or rewriting the saved config. note that if users provide new config options alongside --validate, these are taken into account in the check performed. the 'check complete' message will not be seen if an error is reported by the check function, while it will be seen if only warnings are given, but it would require a redesign of the validation check function to make any improvement in that area, and it's perhaps not worth it. Gbp-Dch: Short
2020-04-23config: rename Set_config_defaults() to Prepare_config()Lyndon Brown
it mostly applies defaults where a value does not exist, but does more in some cases. the new name better reflects its usage and functionality. Gbp-Dch: Short
2020-04-23config: rename Check_config_defaults() to Validate_config()Lyndon Brown
this is used after applying user settings on top of the defaults, so is not specific to checking defaults; it's a validation checker. Gbp-Dch: Short
2020-04-23config: move defaults set in wrong functionLyndon Brown
Gbp-Dch: Ignore
2020-04-23--binary-images can support only a single typeLyndon Brown
whilst some parts of the codebase were set up to work with multiple types specified, others did not work with it and would not necessarily be easy to adjust. this thus makes some tweaks to adjust things accordingly. - option renamed to singular form (maintaining backwards compatibility) - a validation check has been added - unnecessary glob style type references fixed - checks with In_list changed to a direct singular comparison - typo of type "netboot" written as just "net" fixed (though unreachable so of no consequence; really the code could be removed but it's trivial) Gbp-Dch: Short
2020-04-23manpages: fix typoLyndon Brown
Closes: #926238
2020-04-23manpages: fix typoLyndon Brown
bad escape, '-\' should have been '\-' resulted in test showing "--mirror-tstrap" instead of "--mirror-bootstrap" Gbp-Dch: Ignore
2020-04-23manpages: remove unhelpful and largely obsolete fixme noticesLyndon Brown
2020-04-23fix incorrect handling of -c|--conffileLyndon Brown
this option actually only has an impact when used for `lb config`; it thus was incorrectly accepted and captured by Arguments() and the documentation was wrong. going back through git history, this has been incorrect since the v0.99 days. also, reorganised the list alphabetically (no-color was inserted in the wrong place). Gbp-Dch: Short
2020-04-23manpages: fixup synopsisLyndon Brown
live-build page: list of individual commands outdated (color options not added); incorrect (conffile is `lb config` specific as to be addressed otherwise separately); is unnecessary here; and the synopsis suggests usage without a command (e.g. `lb --help` is wrong when it is not). lb: consistensy fix in formatting. all: placeholders should be in capitals for consistency; "OPTIONS" is better the "live-build options" as a placeholder. config: unlike the others where "live-build options" is replaced with "OPTIONS", it makes more sense to specifically list the info (help; usage; version} options, since below the full list of other options including other generic options are given. Gbp-Dch: Short
2020-04-23manpages: fix mistakeLyndon Brown
Gbp-Dch: Ignore
2020-04-23config: support comma and space separated list of source image typesLyndon Brown
2020-04-23manpages: document that multiple source image types can be requestedLyndon Brown
the same is not the case for binary images since although some parts of the codebase support it, others do not. Gbp-Dch: Short
2020-04-23manpages: revise documentation of --linux-packagesLyndon Brown
including documenting use of the value "none" Gbp-Dch: Short
2020-04-23manpages: document that --linux-flavours is space separatedLyndon Brown
2020-04-23manpages: fix typoLyndon Brown
"more than that" -> "more than one" Gbp-Dch: Ignore
2020-04-23manpages: document space separation for --keyring-packagesLyndon Brown
2020-04-23manpages: document all values for --interactiveLyndon Brown
2020-04-23config: support comma or space separated archive area listsLyndon Brown
2020-04-23config: support both comma and space separated to-cache stagesLyndon Brown
2020-04-23manpage: document that multiple stages to cache should be space separatedLyndon Brown
2020-04-23manpage: fix consistency issuesLyndon Brown
- in underlining option parameters - in some cases of single or multiple (quoted + space separated) values Gbp-Dch: Ignore
2020-04-23manpages: indicate in usage that multiple bootloaders can be givenLyndon Brown
Gbp-Dch: Ignore
2020-04-23bootloaders: improve bootloader list handlingLyndon Brown
two parts of the code worked with both comma and space separated lists, while two others only worked with comma separated. swapping out commas with spaces when we setup the var in Set_config_defaults() means that individual scripts no longer need to worry about it and everything supports both; and that we can avoid the IFS/OLDIFS mess. Gbp-Dch: Short
2020-04-23manpages: fix mistakeLyndon Brown
the bootloader list should be comma separated not space. i do not know what possessed me to write space based in aed4e0fef2b87e20ea13ea86d36b9b12ac23426d. fix "booloader" typo while at it. Gbp-Dch: Ignore
2020-04-23fix outdated grub-legacy bootloader name referencesLyndon Brown
2020-04-23manpage: document that multiple archive areas should be space separatedLyndon Brown
2020-04-23Fix permissions & ownership of copied /etc/resolv.confLyndon Brown
Closes: #857740 [tweaked by Raphaël Hertzog to fix the chown root:root call]
2020-04-23binary_hdd: fix variable name typoLyndon Brown
2020-04-23config: fix wrong saved value for parent archive areasLyndon Brown
2020-04-23chroot_apt: fix broken removalLyndon Brown
2020-04-23chroot_apt: improve readabilityLyndon Brown
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-30 10:33:27 +0000