<feed xmlns='http://www.w3.org/2005/Atom'>
<title>vyos.vyos.git/changelogs/fragments/fix-icmp-parse-attr.yml, branch dependabot/github_actions/actions/setup-python-7</title>
<subtitle>Ansible Network Collection for VyOS (mirror of https://github.com/vyos/vyos.vyos.git)
</subtitle>
<id>https://git.amelek.net/vyos/vyos.vyos.git/atom?h=dependabot%2Fgithub_actions%2Factions%2Fsetup-python-7</id>
<link rel='self' href='https://git.amelek.net/vyos/vyos.vyos.git/atom?h=dependabot%2Fgithub_actions%2Factions%2Fsetup-python-7'/>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/'/>
<updated>2026-06-30T11:18:50+00:00</updated>
<entry>
<title>T8522: fix parse_icmp_attr() split delimiter and UnboundLocalError (#464)</title>
<updated>2026-06-30T11:18:50+00:00</updated>
<author>
<name>Yuriy Andamasov</name>
<email>yuriy@vyos.io</email>
</author>
<published>2026-06-30T11:18:50+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=0e10d136ef280ca147b6f1e332072f6ba14c8844'/>
<id>urn:sha1:0e10d136ef280ca147b6f1e332072f6ba14c8844</id>
<content type='text'>
* Add easy-wins improvement spec for vyos.vyos collection

Covers five phases: formatting compliance, runtime.yml redirect fix,
deprecated feature cleanup, missing unit tests, and template deduplication.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;

* Add implementation plan for easy-wins improvements

15 tasks across 5 phases: formatting compliance, runtime.yml bugfix,
deprecated code cleanup, missing unit tests, template deduplication.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;

* Update spec and plan with architect review corrections

Key changes:
- Defer Phase 5 (template deduplication) to v7.0.0: route_maps
  are not identical, BGP dedup blocked by Python module-level
  scoping, OSPF has fundamentally different command paradigms
- Add .git-blame-ignore-revs step to Phase 1
- Add missing test cases: overridden/rendered for resource modules,
  aggregate/purge/with_address for vyos_vlan
- Fix incorrect claim that version.py LooseVersion is unused
- Add sequential merge requirement to preamble

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;

* chore: add .worktrees/ and .claude/ to .gitignore

* T8522: fix parse_icmp_attr() split delimiter and UnboundLocalError

- Use val.split("/") instead of val.split(".") when parsing type/code pairs
- In the numeric-only branch, use int(val) instead of the undefined type_no variable
- Cast both type and code to int for consistent typing

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;

* T8522: remove unrelated planning docs and gitignore changes

These files were included from local main branch commits unrelated
to this bugfix. This commit removes them to keep the PR scoped.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;

* T8522: add parsed test for legacy type/code ICMP format

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;

---------

Co-authored-by: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
Co-authored-by: omnom62 &lt;75066712+omnom62@users.noreply.github.com&gt;</content>
</entry>
</feed>
