<feed xmlns='http://www.w3.org/2005/Atom'>
<title>vyos.vyos.git/changelogs, branch 3.0.0</title>
<subtitle>Ansible Network Collection for VyOS (mirror of https://github.com/vyos/vyos.vyos.git)
</subtitle>
<id>https://git.amelek.net/vyos/vyos.vyos.git/atom?h=3.0.0</id>
<link rel='self' href='https://git.amelek.net/vyos/vyos.vyos.git/atom?h=3.0.0'/>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/'/>
<updated>2022-04-26T20:08:13+00:00</updated>
<entry>
<title>Vyos release 3.0.0 (#255)</title>
<updated>2022-04-26T20:08:13+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-04-26T20:08:13+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=5baf4a4495aebda69d1b2e74d2ff6700b1b70c83'/>
<id>urn:sha1:5baf4a4495aebda69d1b2e74d2ff6700b1b70c83</id>
<content type='text'>
Vyos release 3.0.0

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


ISSUE TYPE


Docs Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case &lt;this.is@nathanielca.se&gt;</content>
</entry>
<entry>
<title>updated references of base plugins to netcommon (#232)</title>
<updated>2022-04-25T19:48:42+00:00</updated>
<author>
<name>Sagar Paul</name>
<email>sagpaul@redhat.com</email>
</author>
<published>2022-04-25T19:48:42+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=43c2ecba6a04cc121375a541d817343c33ebe235'/>
<id>urn:sha1:43c2ecba6a04cc121375a541d817343c33ebe235</id>
<content type='text'>
updated references of base plugins to netcommon

SUMMARY

Minimum required ansible.netcommon version is 2.5.1
Updated base plugin references to ansible.netcommon

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case &lt;this.is@nathanielca.se&gt;</content>
</entry>
<entry>
<title>Add fqcn to ansible_connection to support stable-2.9 (#254)</title>
<updated>2022-04-25T17:55:07+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-04-25T17:55:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=b834c87f13e3ec908bfcd79022404ddf71d6559e'/>
<id>urn:sha1:b834c87f13e3ec908bfcd79022404ddf71d6559e</id>
<content type='text'>
Add fqcn to ansible_connection to support stable-2.9

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


strip_prompt argument is supported only in netcommon network_cli . Vyos jobs on stable-2.9 is failing with the following error, as this argument is not supported ansibe/ansible. This PR sets ansible_connection to ansible.netcommon.network_cli, so that the correct module is used.
2022-04-21 21:14:54.059623 | controller |     capabilities = Connection(module._socket_path).get_capabilities()
2022-04-21 21:14:54.059626 | controller |   File "/tmp/ansible_vyos.vyos.vyos_config_payload_hjioy2__/ansible_vyos.vyos.vyos_config_payload.zip/ansible/module_utils/connection.py", line 190, in __rpc__
2022-04-21 21:14:54.059629 | controller |     raise ConnectionError(to_text(msg, errors='surrogate_then_replace'), code=code)
2022-04-21 21:14:54.059632 | controller | fatal: [vyos]: FAILED! =&gt; {
2022-04-21 21:14:54.059635 | controller |     "changed": false,
2022-04-21 21:14:54.059638 | controller |     "invocation": {
2022-04-21 21:14:54.059641 | controller |         "module_args": {
2022-04-21 21:14:54.059644 | controller |             "backup": false,
2022-04-21 21:14:54.059647 | controller |             "backup_options": null,
2022-04-21 21:14:54.059650 | controller |             "comment": "configured by vyos_config",
2022-04-21 21:14:54.059653 | controller |             "config": null,
2022-04-21 21:14:54.059656 | controller |             "lines": [
2022-04-21 21:14:54.059658 | controller |                 "delete interfaces ethernet eth1",
2022-04-21 21:14:54.059661 | controller |                 "delete interfaces ethernet eth2"
2022-04-21 21:14:54.059664 | controller |             ],
2022-04-21 21:14:54.059667 | controller |             "match": "none",
2022-04-21 21:14:54.059670 | controller |             "provider": null,
2022-04-21 21:14:54.059673 | controller |             "save": false,
2022-04-21 21:14:54.059676 | controller |             "src": null
2022-04-21 21:14:54.059678 | controller |         }
2022-04-21 21:14:54.059682 | controller |     },
2022-04-21 21:14:54.059685 | controller |     "msg": "send() got an unexpected keyword argument 'strip_prompt'"

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty &lt;nilashishchakraborty8@gmail.com&gt;</content>
</entry>
<entry>
<title>Remove warning for default value of gather_subset from vyos_facts (#253)</title>
<updated>2022-04-21T23:25:26+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-04-21T23:25:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=03c735a5219c52233b385b6835ef684f8b9ccb42'/>
<id>urn:sha1:03c735a5219c52233b385b6835ef684f8b9ccb42</id>
<content type='text'>
Remove warning for default value of gather_subset from vyos_facts

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


The warning is no more needed because the default value has been changed by #252
ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty &lt;nilashishchakraborty8@gmail.com&gt;</content>
</entry>
<entry>
<title>change default subset to min (#252)</title>
<updated>2022-04-21T03:56:19+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-04-21T03:56:19+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=3677b7834a8cb735db9b7004563e74bc1ca74961'/>
<id>urn:sha1:3677b7834a8cb735db9b7004563e74bc1ca74961</id>
<content type='text'>
vyos_facts: change default subset to min

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


Fixes #231
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nathaniel Case &lt;this.is@nathanielca.se&gt;</content>
</entry>
<entry>
<title>Create symmlinks for redirection of vyos modules (#244)</title>
<updated>2022-04-04T19:23:39+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-04-04T19:23:39+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=507955aeda83492dab7f2d5f9b695f7bd4043e35'/>
<id>urn:sha1:507955aeda83492dab7f2d5f9b695f7bd4043e35</id>
<content type='text'>
Create symmlinks for redirection of vyos modules

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Sagar Paul &lt;sagpaul@redhat.com&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>Change preconfig hostname in integration test (#243)</title>
<updated>2022-03-10T01:20:40+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-03-10T01:20:40+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=87c5dcb6a147738d2b1ea60993018822a5baf21e'/>
<id>urn:sha1:87c5dcb6a147738d2b1ea60993018822a5baf21e</id>
<content type='text'>
Change preconfig hostname in integration test

SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>Prepare vyos release 2.8.0 (#241)</title>
<updated>2022-03-01T18:45:26+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-03-01T18:45:26+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=8208b02f6f5d5956ccd8d28fdf925cf580011712'/>
<id>urn:sha1:8208b02f6f5d5956ccd8d28fdf925cf580011712</id>
<content type='text'>
Prepare vyos release 2.8.0

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


ISSUE TYPE


Docs Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py  (#240)</title>
<updated>2022-03-01T16:01:04+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-03-01T16:01:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=2299c492ca285f227cdb2043c9602e58ba55bf72'/>
<id>urn:sha1:2299c492ca285f227cdb2043c9602e58ba55bf72</id>
<content type='text'>
Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py 

SUMMARY


Fixes #239
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty &lt;nilashishchakraborty8@gmail.com&gt;
Reviewed-by: Sagar Paul &lt;sagpaul@redhat.com&gt;
Reviewed-by: GomathiselviS &lt;None&gt;
Reviewed-by: Rohit Thakur &lt;rohitthakur2590@outlook.com&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>firewall_rules: Fix incorrect behavior when IPv4 and IPv6 rule sets have the same name (#236)</title>
<updated>2022-02-25T18:28:54+00:00</updated>
<author>
<name>Andrew Gunnerson</name>
<email>accounts+github@chiller3.com</email>
</author>
<published>2022-02-25T18:28:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=b28632c3e581371f3b0d670d376ab409a4b8fa0e'/>
<id>urn:sha1:b28632c3e581371f3b0d670d376ab409a4b8fa0e</id>
<content type='text'>
firewall_rules: Fix incorrect behavior when IPv4 and IPv6 rule sets have the same name

SUMMARY
VyOS supports IPv4 and IPv6 rule sets having the same name, but there are a couple places in the Ansible module that don't handle this situation.

The fact gathering for ansible_network_resources.firewall_rules has been updated to look for name &lt;name&gt; or ipv6-name &lt;name&gt; instead of just &lt;name&gt;.
The vyos_firewall_rules module has been updated to take the afi into consideration when comparing the have and want states.
V4-EGRESS and V6-EGRESS have been renamed to just EGRESS in the tests. The existing tests seem to be complete enough to test this same-name situation. (V4-INGRESS and V6-INGRESS were not renamed.)

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
vyos_facts and vyos_firewall_rules
ADDITIONAL INFORMATION
An example of a configuration that was originally causing an issue:

(Click to expand):
name wan-lan {
    default-action drop
    rule 1 {
        action accept
        state {
            established enable
            related enable
        }
    }
    rule 2 {
        action drop
        log enable
        state {
            invalid enable
        }
    }
}

ipv6-name wan-lan {
    default-action drop
    rule 1 {
        action accept
        state {
            established enable
            related enable
        }
    }
    rule 2 {
        action drop
        log enable
        state {
            invalid enable
        }
    }
    rule 10 {
        action accept
        protocol icmpv6
    }
}


With this configuration, ansible_network_resources.firewall_rules would show the icmpv6 rule under both ipv4 and ipv6:

(Click to expand):
[
    {
        "afi": "ipv4",
        "rule_sets": [
            {
                "default_action": "drop",
                "name": "wan-lan",
                "rules": [
                    {
                        "action": "accept",
                        "number": 1,
                        "state": {
                            "established": true,
                            "related": true
                        }
                    },
                    {
                        "action": "drop",
                        "number": 2,
                        "state": {
                            "invalid": true
                        }
                    },
                    {
                        "action": "accept",
                        "number": 10,
                        "protocol": "icmpv6"
                    }
                ]
            },
        ]
    },
    {
        "afi": "ipv6",
        "rule_sets": [
            {
                "default_action": "drop",
                "name": "wan-lan",
                "rules": [
                    {
                        "action": "accept",
                        "number": 1,
                        "state": {
                            "established": true,
                            "related": true
                        }
                    },
                    {
                        "action": "drop",
                        "number": 2,
                        "state": {
                            "invalid": true
                        }
                    },
                    {
                        "action": "accept",
                        "number": 10,
                        "protocol": "icmpv6"
                    }
                ]
            },
        ]
    }
]

A similar issue would happen when using vyos_firewall_rules as well, where it would attempt to change rules for the wrong afi.

Reviewed-by: GomathiselviS &lt;None&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
</feed>
