vyos.vyos.git/tests/unit, branch 4.0.1

Update Unit Tests (#297)

2023-02-28T04:49:54+00:00

* Remove Python < 3.6 wrappers * Update imports

[pre-commit.ci] pre-commit autoupdate (#291)

2023-02-08T13:16:23+00:00

* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 22.12.0 → 23.1.0](https://github.com/psf/black/compare/22.12.0...23.1.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

[command] run at least once when retries is 0 (#292)

2023-02-07T18:11:59+00:00

* [command] run at least once when retries is 0 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Add prettier and isort to pre-commit. (#270)

2023-01-25T13:37:58+00:00

* Add prettier and isort to pre-commit. * Bump line-length to 100 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Remove deprecated modules and provider (#277)

2022-10-13T17:11:19+00:00

* Remove deprecated modules and provider * Remove tests for removed modules * Remove references to vyos_argument_spec

Fix `pre-commit` Issues (#223)

2022-09-02T13:22:14+00:00

* Fix `pre-commit` Issues This change fixes `.pre-commit-config.yaml` so that `main` no longer has errors on it. To accomplish that, two things had to be done: * Update the version of `black` that `pre-commit` uses to match what `tox` uses. * Run `pre-commit run --all-files` and commit the results Co-authored-by: Kate Case

Fix arguments-renamed errors (#268)

2022-08-22T19:03:19+00:00

Add support for icmpv6 type-name in firewall_rules (#258)

2022-05-23T16:03:58+00:00

Add support for icmpv6 type-name in firewall_rules Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY Fixes #257 ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Sagar Paul

Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py (#240)

2022-03-01T16:01:04+00:00

Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py SUMMARY Fixes #239 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Nilashish Chakraborty Reviewed-by: Sagar Paul Reviewed-by: GomathiselviS Reviewed-by: Rohit Thakur Reviewed-by: None

firewall_rules: Fix incorrect behavior when IPv4 and IPv6 rule sets have the same name (#236)

2022-02-25T18:28:54+00:00

firewall_rules: Fix incorrect behavior when IPv4 and IPv6 rule sets have the same name SUMMARY VyOS supports IPv4 and IPv6 rule sets having the same name, but there are a couple places in the Ansible module that don't handle this situation. The fact gathering for ansible_network_resources.firewall_rules has been updated to look for name or ipv6-name instead of just . The vyos_firewall_rules module has been updated to take the afi into consideration when comparing the have and want states. V4-EGRESS and V6-EGRESS have been renamed to just EGRESS in the tests. The existing tests seem to be complete enough to test this same-name situation. (V4-INGRESS and V6-INGRESS were not renamed.) ISSUE TYPE Bugfix Pull Request COMPONENT NAME vyos_facts and vyos_firewall_rules ADDITIONAL INFORMATION An example of a configuration that was originally causing an issue: (Click to expand): name wan-lan { default-action drop rule 1 { action accept state { established enable related enable } } rule 2 { action drop log enable state { invalid enable } } } ipv6-name wan-lan { default-action drop rule 1 { action accept state { established enable related enable } } rule 2 { action drop log enable state { invalid enable } } rule 10 { action accept protocol icmpv6 } } With this configuration, ansible_network_resources.firewall_rules would show the icmpv6 rule under both ipv4 and ipv6: (Click to expand): [ { "afi": "ipv4", "rule_sets": [ { "default_action": "drop", "name": "wan-lan", "rules": [ { "action": "accept", "number": 1, "state": { "established": true, "related": true } }, { "action": "drop", "number": 2, "state": { "invalid": true } }, { "action": "accept", "number": 10, "protocol": "icmpv6" } ] }, ] }, { "afi": "ipv6", "rule_sets": [ { "default_action": "drop", "name": "wan-lan", "rules": [ { "action": "accept", "number": 1, "state": { "established": true, "related": true } }, { "action": "drop", "number": 2, "state": { "invalid": true } }, { "action": "accept", "number": 10, "protocol": "icmpv6" } ] }, ] } ] A similar issue would happen when using vyos_firewall_rules as well, where it would attempt to change rules for the wrong afi. Reviewed-by: GomathiselviS Reviewed-by: None