<feed xmlns='http://www.w3.org/2005/Atom'>
<title>vyos.vyos.git/tests, branch 2.8.0</title>
<subtitle>Ansible Network Collection for VyOS (mirror of https://github.com/vyos/vyos.vyos.git)
</subtitle>
<id>https://git.amelek.net/vyos/vyos.vyos.git/atom?h=2.8.0</id>
<link rel='self' href='https://git.amelek.net/vyos/vyos.vyos.git/atom?h=2.8.0'/>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/'/>
<updated>2022-03-01T16:01:04+00:00</updated>
<entry>
<title>Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py  (#240)</title>
<updated>2022-03-01T16:01:04+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-03-01T16:01:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=2299c492ca285f227cdb2043c9602e58ba55bf72'/>
<id>urn:sha1:2299c492ca285f227cdb2043c9602e58ba55bf72</id>
<content type='text'>
Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py 

SUMMARY


Fixes #239
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty &lt;nilashishchakraborty8@gmail.com&gt;
Reviewed-by: Sagar Paul &lt;sagpaul@redhat.com&gt;
Reviewed-by: GomathiselviS &lt;None&gt;
Reviewed-by: Rohit Thakur &lt;rohitthakur2590@outlook.com&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>firewall_rules: Fix incorrect behavior when IPv4 and IPv6 rule sets have the same name (#236)</title>
<updated>2022-02-25T18:28:54+00:00</updated>
<author>
<name>Andrew Gunnerson</name>
<email>accounts+github@chiller3.com</email>
</author>
<published>2022-02-25T18:28:54+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=b28632c3e581371f3b0d670d376ab409a4b8fa0e'/>
<id>urn:sha1:b28632c3e581371f3b0d670d376ab409a4b8fa0e</id>
<content type='text'>
firewall_rules: Fix incorrect behavior when IPv4 and IPv6 rule sets have the same name

SUMMARY
VyOS supports IPv4 and IPv6 rule sets having the same name, but there are a couple places in the Ansible module that don't handle this situation.

The fact gathering for ansible_network_resources.firewall_rules has been updated to look for name &lt;name&gt; or ipv6-name &lt;name&gt; instead of just &lt;name&gt;.
The vyos_firewall_rules module has been updated to take the afi into consideration when comparing the have and want states.
V4-EGRESS and V6-EGRESS have been renamed to just EGRESS in the tests. The existing tests seem to be complete enough to test this same-name situation. (V4-INGRESS and V6-INGRESS were not renamed.)

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
vyos_facts and vyos_firewall_rules
ADDITIONAL INFORMATION
An example of a configuration that was originally causing an issue:

(Click to expand):
name wan-lan {
    default-action drop
    rule 1 {
        action accept
        state {
            established enable
            related enable
        }
    }
    rule 2 {
        action drop
        log enable
        state {
            invalid enable
        }
    }
}

ipv6-name wan-lan {
    default-action drop
    rule 1 {
        action accept
        state {
            established enable
            related enable
        }
    }
    rule 2 {
        action drop
        log enable
        state {
            invalid enable
        }
    }
    rule 10 {
        action accept
        protocol icmpv6
    }
}


With this configuration, ansible_network_resources.firewall_rules would show the icmpv6 rule under both ipv4 and ipv6:

(Click to expand):
[
    {
        "afi": "ipv4",
        "rule_sets": [
            {
                "default_action": "drop",
                "name": "wan-lan",
                "rules": [
                    {
                        "action": "accept",
                        "number": 1,
                        "state": {
                            "established": true,
                            "related": true
                        }
                    },
                    {
                        "action": "drop",
                        "number": 2,
                        "state": {
                            "invalid": true
                        }
                    },
                    {
                        "action": "accept",
                        "number": 10,
                        "protocol": "icmpv6"
                    }
                ]
            },
        ]
    },
    {
        "afi": "ipv6",
        "rule_sets": [
            {
                "default_action": "drop",
                "name": "wan-lan",
                "rules": [
                    {
                        "action": "accept",
                        "number": 1,
                        "state": {
                            "established": true,
                            "related": true
                        }
                    },
                    {
                        "action": "drop",
                        "number": 2,
                        "state": {
                            "invalid": true
                        }
                    },
                    {
                        "action": "accept",
                        "number": 10,
                        "protocol": "icmpv6"
                    }
                ]
            },
        ]
    }
]

A similar issue would happen when using vyos_firewall_rules as well, where it would attempt to change rules for the wrong afi.

Reviewed-by: GomathiselviS &lt;None&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>vyos_firewall_rules: Add support for log enable on individual rules (#238)</title>
<updated>2022-02-22T21:30:07+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-02-22T21:30:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=d3c91d0ee00c187a5623a6b66f9fedad800ff3d0'/>
<id>urn:sha1:d3c91d0ee00c187a5623a6b66f9fedad800ff3d0</id>
<content type='text'>
vyos_firewall_rules: Add support for log enable on individual rules

SUMMARY


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Rohit Thakur &lt;rohitthakur2590@outlook.com&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>Add Vyos hostname resource module (#237)</title>
<updated>2022-02-17T15:10:20+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-02-17T15:10:20+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=4662d6d03742ecc2fd09c530cf4b70217975e5bb'/>
<id>urn:sha1:4662d6d03742ecc2fd09c530cf4b70217975e5bb</id>
<content type='text'>
Add Vyos hostname resource module

SUMMARY


ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty &lt;nilashishchakraborty8@gmail.com&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>Vyos snmp_server Resource Module (#227)</title>
<updated>2022-02-01T00:41:29+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-02-01T00:41:29+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=32371e3fe712b08bc3e3b47075741234ad784586'/>
<id>urn:sha1:32371e3fe712b08bc3e3b47075741234ad784586</id>
<content type='text'>
Vyos snmp_server Resource Module

SUMMARY


Added vyos_snmp_server resource module
ISSUE TYPE


New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Nilashish Chakraborty &lt;nilashishchakraborty8@gmail.com&gt;
Reviewed-by: Ashwini Mhatre &lt;mashu97@gmail.com&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>Enable configuring ntp server pool in ntp_global (#225)</title>
<updated>2022-01-19T23:19:45+00:00</updated>
<author>
<name>GomathiselviS</name>
<email>gomathiselvi@gmail.com</email>
</author>
<published>2022-01-19T23:19:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=a4fc3def45320e633a773f2efa453c78d3b4afca'/>
<id>urn:sha1:a4fc3def45320e633a773f2efa453c78d3b4afca</id>
<content type='text'>
Enable configuring ntp server pool in ntp_global

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY


Fixes #221
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Shawn Wilsher &lt;None&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>tests: remove unintended .swp file (#218)</title>
<updated>2021-12-08T21:05:57+00:00</updated>
<author>
<name>David Moreau Simard</name>
<email>moi@dmsimard.com</email>
</author>
<published>2021-12-08T21:05:57+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=be096e94d2904dd5743abde26253b86fa79f26bb'/>
<id>urn:sha1:be096e94d2904dd5743abde26253b86fa79f26bb</id>
<content type='text'>
tests: remove unintended .swp file

SUMMARY
Depends-On: #220
.swp files are VI temporary files and it was likely not intended to be
added to the repository.
ISSUE TYPE

Bugfix Pull Request


COMPONENT NAME
tests

Reviewed-by: GomathiselviS &lt;None&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>Add vyos_ntp resource module (#175)</title>
<updated>2021-10-02T17:28:30+00:00</updated>
<author>
<name>YVarshitha</name>
<email>63169351+YVarshitha@users.noreply.github.com</email>
</author>
<published>2021-10-02T17:28:30+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=85ea49f10a6167dea4c08e71a1e8e5a62cb57395'/>
<id>urn:sha1:85ea49f10a6167dea4c08e71a1e8e5a62cb57395</id>
<content type='text'>
Add vyos_ntp resource module

SUMMARY


Resource module vyos_ntp
ISSUE TYPE


New Module Pull Request

COMPONENT NAME

vyos_ntp
ADDITIONAL INFORMATION

Reviewed-by: GomathiselviS &lt;None&gt;
Reviewed-by: Nilashish Chakraborty &lt;nilashishchakraborty8@gmail.com&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>Copy ignore-2.12.txt to ignore-2.13.txt (#214)</title>
<updated>2021-09-28T14:12:12+00:00</updated>
<author>
<name>Andrew Klychkov</name>
<email>aklychko@redhat.com</email>
</author>
<published>2021-09-28T14:12:12+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=88689227265b7f6b272b695a275f4a47735ddcc2'/>
<id>urn:sha1:88689227265b7f6b272b695a275f4a47735ddcc2</id>
<content type='text'>
Copy ignore-2.12.txt to ignore-2.13.txt

SUMMARY
Relates to ansible-collections/overview#45 (comment)

Reviewed-by: None &lt;None&gt;</content>
</entry>
<entry>
<title>Add support for IPv6 `address_group` and `network_group` (#202)</title>
<updated>2021-09-20T23:25:49+00:00</updated>
<author>
<name>Shawn Wilsher</name>
<email>656602+sdwilsh@users.noreply.github.com</email>
</author>
<published>2021-09-20T23:25:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.amelek.net/vyos/vyos.vyos.git/commit/?id=c2cf82dfea4aa89e5aa9ba57b798bee030a9abbe'/>
<id>urn:sha1:c2cf82dfea4aa89e5aa9ba57b798bee030a9abbe</id>
<content type='text'>
Add support for IPv6 `address_group` and `network_group`

SUMMARY
This adds support for ipv6 in network and address groups by adding an afi parameter, but defaulting it to ipv4 for backwards compatibility.
Fixes #137.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
vyos_firewall_global

Reviewed-by: GomathiselviS &lt;None&gt;
Reviewed-by: Shawn Wilsher &lt;None&gt;
Reviewed-by: None &lt;None&gt;</content>
</entry>
</feed>
