diff options
| author | Yuriy Andamasov <yuriy@vyos.io> | 2026-04-16 08:09:06 +0300 |
|---|---|---|
| committer | Yuriy Andamasov <yuriy@vyos.io> | 2026-04-16 08:10:17 +0300 |
| commit | 9555eb81ec1030f9834254d3bacb9ef223c9f8a9 (patch) | |
| tree | cc4b894829c718a5e906137e03b2513a2ba788e0 /.github/copilot-instructions.md | |
| parent | 8507846c78b053104e2e80048095cd8299ae3719 (diff) | |
| download | vyos.vyos-chore/copilot-review-instructions.tar.gz vyos.vyos-chore/copilot-review-instructions.zip | |
T8523: fix four more inaccuracies flagged by Copilot reviewchore/copilot-review-instructions
- CLI quoting: address values in firewall groups are unquoted in
fixtures; instruct reviewers to align with surrounding fixture
style rather than flagging all unquoted addresses
- Resource module mocking: add .start()/.stop() calls to the snippet
so it matches the actual setUp/tearDown pattern in existing tests
- terminal plugin versions: reference README.md instead of hardcoding
a version list that diverges from README
- changelog fragment: remove stale "copyright headers" claim (that
section was dropped from the instruction files)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Diffstat (limited to '.github/copilot-instructions.md')
| -rw-r--r-- | .github/copilot-instructions.md | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 02d951ce..fc25faa1 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -40,9 +40,10 @@ Resource modules support all states: `merged`, `replaced`, `overridden`, `delete ## VyOS CLI conventions -- Set commands with string/address values: `set interfaces ethernet eth0 address '192.0.2.1/24'` +- Set commands: `set interfaces ethernet eth0 address '192.0.2.1/24'` - Delete commands: `delete interfaces ethernet eth0 address '192.0.2.1/24'` -- String and address values are single-quoted; boolean flags and bare keywords are not. +- Quoting varies by context. In general, string values (descriptions, names, ELIN numbers) are single-quoted; boolean flags and bare keywords are not. However, address/prefix values may be quoted or unquoted depending on where they appear: - Quoted: `address '192.0.2.1/24'`, `description 'my-iface'`, `elin '0000000911'` - - Unquoted: `disable`, `mtu-ignore`, `set interfaces loopback lo`, `vif 200` + - Unquoted: `address 192.0.2.1` (in firewall groups), `disable`, `mtu-ignore`, `vif 200` +- When reviewing tests and fixtures, align with the quoting style used by surrounding fixtures rather than flagging a missing quote as an error. - Interface types: `ethernet`, `loopback`, `bonding`, `bridge`, `tunnel`, `wireguard`. |