diff options
| author | Yuriy Andamasov <yuriy@vyos.io> | 2026-04-16 07:18:36 +0300 |
|---|---|---|
| committer | Yuriy Andamasov <yuriy@vyos.io> | 2026-04-16 07:18:36 +0300 |
| commit | 768cca2ab06d481cf81ffcbcc72ec7f6dec6fedb (patch) | |
| tree | 5644a721a3877e7a5fc33744f3298e3bc5bd7184 | |
| parent | 63f7d61a3e47713b32f73c354b32f3bf551d4f05 (diff) | |
| download | vyos.vyos-768cca2ab06d481cf81ffcbcc72ec7f6dec6fedb.tar.gz vyos.vyos-768cca2ab06d481cf81ffcbcc72ec7f6dec6fedb.zip | |
T8522: add parsed test for legacy type/code ICMP format
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| -rw-r--r-- | tests/unit/modules/network/vyos/test_vyos_firewall_rules13.py | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/tests/unit/modules/network/vyos/test_vyos_firewall_rules13.py b/tests/unit/modules/network/vyos/test_vyos_firewall_rules13.py index 1af61752..edce123b 100644 --- a/tests/unit/modules/network/vyos/test_vyos_firewall_rules13.py +++ b/tests/unit/modules/network/vyos/test_vyos_firewall_rules13.py @@ -1576,3 +1576,17 @@ class TestVyosFirewallRulesModule13(TestVyosModule): ] self.maxDiff = None self.execute_module(changed=True, commands=commands) + + def test_vyos_firewall_rules_parsed_icmp_type_code(self): + """parse_icmp_attr: legacy 'type/code' token parses into integer type and code.""" + raw = ( + "set firewall name TEST rule 1 action 'accept'\n" + "set firewall name TEST rule 1 protocol 'icmp'\n" + "set firewall name TEST rule 1 icmp type '3/4'\n" + ) + set_module_args(dict(running_config=raw, state="parsed")) + result = self.execute_module(changed=False) + parsed = result["parsed"] + rule = parsed[0]["rule_sets"][0]["rules"][0] + self.assertEqual(rule["icmp"]["type"], 3) + self.assertEqual(rule["icmp"]["code"], 4) |