diff options
| author | Yuriy Andamasov <yuriy@vyos.io> | 2026-04-16 06:55:31 +0300 |
|---|---|---|
| committer | Yuriy Andamasov <yuriy@vyos.io> | 2026-04-16 06:55:37 +0300 |
| commit | 3237ec79bae58908901b650dc48389cbbdd7ff26 (patch) | |
| tree | 6fd9c7d42a51b6b2cecd7c79f991d8469df00d2b /plugins | |
| parent | e3a15efbd2b047e9bac3ff9d6781386f26400904 (diff) | |
| download | vyos.vyos-3237ec79bae58908901b650dc48389cbbdd7ff26.tar.gz vyos.vyos-3237ec79bae58908901b650dc48389cbbdd7ff26.zip | |
T8522: fix parse_icmp_attr() split delimiter and UnboundLocalError
- Use val.split("/") instead of val.split(".") when parsing type/code pairs
- In the numeric-only branch, use int(val) instead of the undefined type_no variable
- Cast both type and code to int for consistent typing
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Diffstat (limited to 'plugins')
| -rw-r--r-- | plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py b/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py index 270b4a62..f8f02e7a 100644 --- a/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py +++ b/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py @@ -412,11 +412,11 @@ class Firewall_rulesFacts(object): # <1.3 could be # (type), #/# (type/code) or 'type' (type_name) # recent this is only for strings if "/" in val: # type/code - (type_no, code) = val.split(".") - config["type"] = type_no - config["code"] = code + (type_no, code) = val.split("/") + config["type"] = int(type_no) + config["code"] = int(code) elif val.isnumeric(): - config["type"] = type_no + config["type"] = int(val) else: config["type_name"] = val return config |