diff options
| author | GomathiselviS <gomathiselvi@gmail.com> | 2022-03-01 11:01:04 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-01 16:01:04 +0000 |
| commit | 2299c492ca285f227cdb2043c9602e58ba55bf72 (patch) | |
| tree | 35bde410f5940aea7337d34808c844e240278ec8 /tests/integration | |
| parent | b28632c3e581371f3b0d670d376ab409a4b8fa0e (diff) | |
| download | vyos.vyos-2299c492ca285f227cdb2043c9602e58ba55bf72.tar.gz vyos.vyos-2299c492ca285f227cdb2043c9602e58ba55bf72.zip | |
Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py (#240)
Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py
SUMMARY
Fixes #239
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: GomathiselviS <None>
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: None <None>
Diffstat (limited to 'tests/integration')
| -rw-r--r-- | tests/integration/targets/vyos_firewall_rules/tests/cli/merged.yaml | 11 | ||||
| -rw-r--r-- | tests/integration/targets/vyos_firewall_rules/vars/main.yaml | 4 |
2 files changed, 15 insertions, 0 deletions
diff --git a/tests/integration/targets/vyos_firewall_rules/tests/cli/merged.yaml b/tests/integration/targets/vyos_firewall_rules/tests/cli/merged.yaml index d8b7d17..48fdff7 100644 --- a/tests/integration/targets/vyos_firewall_rules/tests/cli/merged.yaml +++ b/tests/integration/targets/vyos_firewall_rules/tests/cli/merged.yaml @@ -39,11 +39,13 @@ action: accept description: Rule 101 is configured by Ansible ipsec: match-ipsec + disabled: true - number: 102 action: reject description: Rule 102 is configured by Ansible ipsec: match-ipsec + disable: true - number: 103 action: accept @@ -60,6 +62,9 @@ related: true state: merged + - vyos.vyos.vyos_facts: + gather_network_resources: firewall_rules + - name: Assert that before dicts were correctly generated assert: that: @@ -72,6 +77,12 @@ - "{{ merged['commands'] | symmetric_difference(result['commands']) |length\ \ == 0 }}" + - name: Assert that fact was correctly generated + assert: + that: + - "{{ merged['after'] | symmetric_difference(ansible_facts['network_resources']['firewall_rules']) |length\ + \ == 0 }}" + - name: Assert that after dicts was correctly generated assert: that: diff --git a/tests/integration/targets/vyos_firewall_rules/vars/main.yaml b/tests/integration/targets/vyos_firewall_rules/vars/main.yaml index 88323ba..3bd1512 100644 --- a/tests/integration/targets/vyos_firewall_rules/vars/main.yaml +++ b/tests/integration/targets/vyos_firewall_rules/vars/main.yaml @@ -17,10 +17,12 @@ merged: - set firewall name INBOUND default-action 'accept' - set firewall name INBOUND description 'IPv4 INBOUND rule set' - set firewall name INBOUND rule 101 action 'accept' + - set firewall name INBOUND rule 101 disable - set firewall name INBOUND rule 101 - set firewall name INBOUND rule 101 description 'Rule 101 is configured by Ansible' - set firewall name INBOUND rule 101 ipsec 'match-ipsec' - set firewall name INBOUND rule 102 action 'reject' + - set firewall name INBOUND rule 102 disable - set firewall name INBOUND rule 102 - set firewall name INBOUND rule 102 description 'Rule 102 is configured by Ansible' - set firewall name INBOUND rule 102 ipsec 'match-ipsec' @@ -58,8 +60,10 @@ merged: action: accept description: Rule 101 is configured by Ansible ipsec: match-ipsec + disable: true - number: 102 action: reject + disable: true description: Rule 102 is configured by Ansible ipsec: match-ipsec - number: 103 |