summaryrefslogtreecommitdiff
path: root/.github/copilot-instructions.md
diff options
context:
space:
mode:
Diffstat (limited to '.github/copilot-instructions.md')
-rw-r--r--.github/copilot-instructions.md7
1 files changed, 4 insertions, 3 deletions
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
index 02d951ce..fc25faa1 100644
--- a/.github/copilot-instructions.md
+++ b/.github/copilot-instructions.md
@@ -40,9 +40,10 @@ Resource modules support all states: `merged`, `replaced`, `overridden`, `delete
## VyOS CLI conventions
-- Set commands with string/address values: `set interfaces ethernet eth0 address '192.0.2.1/24'`
+- Set commands: `set interfaces ethernet eth0 address '192.0.2.1/24'`
- Delete commands: `delete interfaces ethernet eth0 address '192.0.2.1/24'`
-- String and address values are single-quoted; boolean flags and bare keywords are not.
+- Quoting varies by context. In general, string values (descriptions, names, ELIN numbers) are single-quoted; boolean flags and bare keywords are not. However, address/prefix values may be quoted or unquoted depending on where they appear:
- Quoted: `address '192.0.2.1/24'`, `description 'my-iface'`, `elin '0000000911'`
- - Unquoted: `disable`, `mtu-ignore`, `set interfaces loopback lo`, `vif 200`
+ - Unquoted: `address 192.0.2.1` (in firewall groups), `disable`, `mtu-ignore`, `vif 200`
+- When reviewing tests and fixtures, align with the quoting style used by surrounding fixtures rather than flagging a missing quote as an error.
- Interface types: `ethernet`, `loopback`, `bonding`, `bridge`, `tunnel`, `wireguard`.