Age | Commit message (Collapse) | Author |
|
updated references of base plugins to netcommon
SUMMARY
Minimum required ansible.netcommon version is 2.5.1
Updated base plugin references to ansible.netcommon
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
|
|
Add fqcn to ansible_connection to support stable-2.9
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
strip_prompt argument is supported only in netcommon network_cli . Vyos jobs on stable-2.9 is failing with the following error, as this argument is not supported ansibe/ansible. This PR sets ansible_connection to ansible.netcommon.network_cli, so that the correct module is used.
2022-04-21 21:14:54.059623 | controller | capabilities = Connection(module._socket_path).get_capabilities()
2022-04-21 21:14:54.059626 | controller | File "/tmp/ansible_vyos.vyos.vyos_config_payload_hjioy2__/ansible_vyos.vyos.vyos_config_payload.zip/ansible/module_utils/connection.py", line 190, in __rpc__
2022-04-21 21:14:54.059629 | controller | raise ConnectionError(to_text(msg, errors='surrogate_then_replace'), code=code)
2022-04-21 21:14:54.059632 | controller | fatal: [vyos]: FAILED! => {
2022-04-21 21:14:54.059635 | controller | "changed": false,
2022-04-21 21:14:54.059638 | controller | "invocation": {
2022-04-21 21:14:54.059641 | controller | "module_args": {
2022-04-21 21:14:54.059644 | controller | "backup": false,
2022-04-21 21:14:54.059647 | controller | "backup_options": null,
2022-04-21 21:14:54.059650 | controller | "comment": "configured by vyos_config",
2022-04-21 21:14:54.059653 | controller | "config": null,
2022-04-21 21:14:54.059656 | controller | "lines": [
2022-04-21 21:14:54.059658 | controller | "delete interfaces ethernet eth1",
2022-04-21 21:14:54.059661 | controller | "delete interfaces ethernet eth2"
2022-04-21 21:14:54.059664 | controller | ],
2022-04-21 21:14:54.059667 | controller | "match": "none",
2022-04-21 21:14:54.059670 | controller | "provider": null,
2022-04-21 21:14:54.059673 | controller | "save": false,
2022-04-21 21:14:54.059676 | controller | "src": null
2022-04-21 21:14:54.059678 | controller | }
2022-04-21 21:14:54.059682 | controller | },
2022-04-21 21:14:54.059685 | controller | "msg": "send() got an unexpected keyword argument 'strip_prompt'"
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
|
|
Remove warning for default value of gather_subset from vyos_facts
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
The warning is no more needed because the default value has been changed by #252
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
|
|
vyos_facts: change default subset to min
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
Fixes #231
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
|
|
Create symmlinks for redirection of vyos modules
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: None <None>
|
|
Change preconfig hostname in integration test
SUMMARY
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: None <None>
|
|
Prepare vyos release 2.8.0
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
ISSUE TYPE
Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: None <None>
|
|
Change parameter 'disabled' to 'disable' in test_vyos_firewall_rules.py
SUMMARY
Fixes #239
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
Reviewed-by: GomathiselviS <None>
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: None <None>
|
|
same name (#236)
firewall_rules: Fix incorrect behavior when IPv4 and IPv6 rule sets have the same name
SUMMARY
VyOS supports IPv4 and IPv6 rule sets having the same name, but there are a couple places in the Ansible module that don't handle this situation.
The fact gathering for ansible_network_resources.firewall_rules has been updated to look for name <name> or ipv6-name <name> instead of just <name>.
The vyos_firewall_rules module has been updated to take the afi into consideration when comparing the have and want states.
V4-EGRESS and V6-EGRESS have been renamed to just EGRESS in the tests. The existing tests seem to be complete enough to test this same-name situation. (V4-INGRESS and V6-INGRESS were not renamed.)
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
vyos_facts and vyos_firewall_rules
ADDITIONAL INFORMATION
An example of a configuration that was originally causing an issue:
(Click to expand):
name wan-lan {
default-action drop
rule 1 {
action accept
state {
established enable
related enable
}
}
rule 2 {
action drop
log enable
state {
invalid enable
}
}
}
ipv6-name wan-lan {
default-action drop
rule 1 {
action accept
state {
established enable
related enable
}
}
rule 2 {
action drop
log enable
state {
invalid enable
}
}
rule 10 {
action accept
protocol icmpv6
}
}
With this configuration, ansible_network_resources.firewall_rules would show the icmpv6 rule under both ipv4 and ipv6:
(Click to expand):
[
{
"afi": "ipv4",
"rule_sets": [
{
"default_action": "drop",
"name": "wan-lan",
"rules": [
{
"action": "accept",
"number": 1,
"state": {
"established": true,
"related": true
}
},
{
"action": "drop",
"number": 2,
"state": {
"invalid": true
}
},
{
"action": "accept",
"number": 10,
"protocol": "icmpv6"
}
]
},
]
},
{
"afi": "ipv6",
"rule_sets": [
{
"default_action": "drop",
"name": "wan-lan",
"rules": [
{
"action": "accept",
"number": 1,
"state": {
"established": true,
"related": true
}
},
{
"action": "drop",
"number": 2,
"state": {
"invalid": true
}
},
{
"action": "accept",
"number": 10,
"protocol": "icmpv6"
}
]
},
]
}
]
A similar issue would happen when using vyos_firewall_rules as well, where it would attempt to change rules for the wrong afi.
Reviewed-by: GomathiselviS <None>
Reviewed-by: None <None>
|
|
vyos_firewall_rules: Add support for log enable on individual rules
SUMMARY
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: None <None>
|
|
Add Vyos hostname resource module
SUMMARY
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
|
|
Vyos release 2.7.0
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: None <None>
|
|
Vyos snmp_server Resource Module
SUMMARY
Added vyos_snmp_server resource module
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Ashwini Mhatre <mashu97@gmail.com>
Reviewed-by: None <None>
|
|
Enable configuring ntp server pool in ntp_global
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
Fixes #221
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Shawn Wilsher <None>
Reviewed-by: None <None>
|
|
tests: remove unintended .swp file
SUMMARY
Depends-On: #220
.swp files are VI temporary files and it was likely not intended to be
added to the repository.
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
tests
Reviewed-by: GomathiselviS <None>
Reviewed-by: None <None>
|
|
Add libssh dependency for vyos collection
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: None <None>
|
|
Prepare release vyos 2.6.0
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: None <None>
|
|
Add vyos_ntp resource module
SUMMARY
Resource module vyos_ntp
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
vyos_ntp
ADDITIONAL INFORMATION
Reviewed-by: GomathiselviS <None>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
|
|
Copy ignore-2.12.txt to ignore-2.13.txt
SUMMARY
Relates to ansible-collections/overview#45 (comment)
Reviewed-by: None <None>
|
|
Add support for IPv6 `address_group` and `network_group`
SUMMARY
This adds support for ipv6 in network and address groups by adding an afi parameter, but defaulting it to ipv4 for backwards compatibility.
Fixes #137.
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
vyos_firewall_global
Reviewed-by: GomathiselviS <None>
Reviewed-by: Shawn Wilsher <None>
Reviewed-by: None <None>
|
|
(#203)
Fix `vyos.vyos.vyos_firewall_rules` `state: replaced` to match documentation
SUMMARY
vyos.vyos.vyos_firewall_rules should only try to change listed firewall rules, as documented, when the state is set to replaced. As currently implemented (prior to this PR), it better matches what overridden is meant to do.
Fixes #201
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
vyos.vyos.vyos_firewall_rules
ADDITIONAL INFORMATION
Cleanup and document existing code for clarity
Add a failing idempotent test
Add a failing change test
Fix failing tests
Add change fragment
Reviewed-by: GomathiselviS <None>
Reviewed-by: Shawn Wilsher <None>
Reviewed-by: None <None>
|
|
Updating collection_prep pre-commit hook to 0.9.4
Committed via https://github.com/asottile/all-repos
Reviewed-by: None <None>
|
|
Allow_duplicates for prepare_vyos_tests
Signed-off-by: Paul Belanger pabelanger@redhat.com
Reviewed-by: None <None>
|
|
's/0.9.[12]/0.9.3/' (#210)
git ls-files -z -- .pre-commit-config.yaml | xargs -0 sed -i 's/0.9.[12]/0.9.3/'
Depends-On: ansible/ansible-zuul-jobs#1101
Committed via https://github.com/asottile/all-repos
Reviewed-by: None <None>
|
|
added 'issues' to 'galaxy.yml'
SUMMARY
added 'issues' to 'galaxy.yml'
ISSUE TYPE
galaxy.yml Pull Request
COMPONENT NAME
galaxy.yml
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
|
|
Prepare for vyos release 2.5.1
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
|
|
IPV6 ICMP type name in vyos.vyos.vyos_firewall_rules is not idempotent
SUMMARY
fix issue: #170
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: GomathiselviS <None>
Reviewed-by: None <None>
|
|
Fix pylint sanity issues
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: None <None>
|
|
Drop ansible_become for testing
We don't actually need escalated permissions to run these things.
Signed-off-by: Paul Belanger pabelanger@redhat.com
Reviewed-by: GomathiselviS <None>
Reviewed-by: Nathaniel Case <this.is@nathanielca.se>
Reviewed-by: None <None>
|
|
Docs fixed - wrong platform mentioned
SUMMARY
updated docs corrected wrong platform mentioned
ISSUE TYPE
Docs Pull Request
COMPONENT NAME
bgp_address_family
ospf_interfaces
ADDITIONAL INFORMATION
Reviewed-by: GomathiselviS <None>
Reviewed-by: None <None>
|
|
Prepare vyos release 2.5.0
Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY
ISSUE TYPE
Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Sagar Paul <sagpaul@redhat.com>
|
|
vyos logging_global resource module
SUMMARY
Logging resource module vyos_logging_global
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
vyos_logging_global
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
|
|
fix issue in route-maps facts code when route-maps facts are empty.
SUMMARY
fixes: #181
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
|
|
collection prep 2_4_0
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
|
|
VyOS Prefix Lists Resource Module Added
SUMMARY
PR for vyos_prefix_lists rm
resolves: #99
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Rohit Thakur <rohitthakur2590@outlook.com>
Reviewed-by: Nilashish Chakraborty <nilashishchakraborty8@gmail.com>
Reviewed-by: Priyam Sahoo <None>
|
|
Prepare vyos release 2.3.1
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
static route fixes
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
Spelling glitch fix on doc
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
Fix keyerror in firewall_rules when state=overridden
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
Update README: freenode -> libera.chat
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
VYOS release 2.3.0
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
Revert "Prepare vyos release 2.2.1"
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
Prepare vyos release 2.2.1
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
Replace admin_distance with distance while generating static_routes nexthop command
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
fix route-map delete integrataion test
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
Vyos route maps
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
To update changelog doc path in Readme
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
[firewall_global] port-groups are not added
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
Prepare vyos for release 2.2.0
Reviewed-by: https://github.com/apps/ansible-zuul
|
|
VyOS: available_network_resources implemented in vyos_facts
Reviewed-by: https://github.com/apps/ansible-zuul
|