From 21e3948bddf9dd39339bda6a8d655919a5ee8ca6 Mon Sep 17 00:00:00 2001
From: Rahmanim Benny <brahmani@redhat.com>
Date: Tue, 5 Mar 2024 12:16:03 +0200
Subject: Avoid unsafe conditions for integration tests (#340)
* Avoid unsafe conditions for integration tests
* Remove .idea/ folder
* remove another jinja templating expression from asserts condition
* remove shortname jinja templating expression from asserts condition
* Update changelog
* changelog updates
---
changelogs/fragments/avoid_unsafe_conditions.yml | 3 +++
tests/integration/targets/vyos_config/tests/cli/check_config.yaml | 4 ++--
.../targets/vyos_config/tests/redirection/cli/shortname.yaml | 4 ++--
3 files changed, 7 insertions(+), 4 deletions(-)
create mode 100644 changelogs/fragments/avoid_unsafe_conditions.yml
diff --git a/changelogs/fragments/avoid_unsafe_conditions.yml b/changelogs/fragments/avoid_unsafe_conditions.yml
new file mode 100644
index 00000000..693f01d0
--- /dev/null
+++ b/changelogs/fragments/avoid_unsafe_conditions.yml
@@ -0,0 +1,3 @@
+---
+trivial:
+ - avoid_unsafe_conditions - Avoid unsafe conditions in integration tests to resolve issues related to assertion unsafe conditions.
diff --git a/tests/integration/targets/vyos_config/tests/cli/check_config.yaml b/tests/integration/targets/vyos_config/tests/cli/check_config.yaml
index 2df01354..5e028549 100644
--- a/tests/integration/targets/vyos_config/tests/cli/check_config.yaml
+++ b/tests/integration/targets/vyos_config/tests/cli/check_config.yaml
@@ -16,7 +16,7 @@
- name: Check that multiple duplicate lines collapse into a single commands
assert:
that:
- - "{{ result.commands|length }} == 1"
+ - result.commands|length == 1
- name: Check that set is correctly prepended
assert:
@@ -52,6 +52,6 @@
- assert:
that:
- - "{{ result.filtered|length }} == 2"
+ - result.filtered|length == 2
- debug: msg="END cli/config_check.yaml on connection={{ ansible_connection }}"
diff --git a/tests/integration/targets/vyos_config/tests/redirection/cli/shortname.yaml b/tests/integration/targets/vyos_config/tests/redirection/cli/shortname.yaml
index f397a27c..e5bb8dda 100644
--- a/tests/integration/targets/vyos_config/tests/redirection/cli/shortname.yaml
+++ b/tests/integration/targets/vyos_config/tests/redirection/cli/shortname.yaml
@@ -16,7 +16,7 @@
- name: Check that multiple duplicate lines collapse into a single commands
assert:
that:
- - "{{ result.commands|length }} == 1"
+ - result.commands|length == 1
- name: Check that set is correctly prepended
assert:
@@ -52,7 +52,7 @@
- assert:
that:
- - "{{ result.filtered|length }} == 2"
+ - result.filtered|length == 2
- name: Remove interface description and delete temp user
vyos.vyos.config: &cleanup
--
cgit v1.2.3