From 8cf785d03536f910accb175aac90754ab64a03a7 Mon Sep 17 00:00:00 2001 From: GomathiselviS Date: Wed, 8 Dec 2021 16:05:54 -0500 Subject: Add libssh dependency for vyos collection (#220) Add libssh dependency for vyos collection Signed-off-by: GomathiselviS gomathiselvi@gmail.com SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Rohit Thakur Reviewed-by: None --- README.md | 1 + bindep.txt | 3 +++ changelogs/fragments/sanity_issue_fix.yaml | 3 +++ docs/vyos.vyos.vyos_facts_module.rst | 4 ++-- docs/vyos.vyos.vyos_ping_module.rst | 12 ++++++------ plugins/modules/vyos_facts.py | 4 ++-- plugins/modules/vyos_ping.py | 12 ++++++------ 7 files changed, 23 insertions(+), 16 deletions(-) create mode 100644 changelogs/fragments/sanity_issue_fix.yaml diff --git a/README.md b/README.md index 67e7a3b5..89640154 100644 --- a/README.md +++ b/README.md @@ -60,6 +60,7 @@ Name | Description [vyos.vyos.vyos_ping](https://github.com/ansible-collections/vyos.vyos/blob/main/docs/vyos.vyos.vyos_ping_module.rst)|Tests reachability using ping from VyOS network devices [vyos.vyos.vyos_prefix_lists](https://github.com/ansible-collections/vyos.vyos/blob/main/docs/vyos.vyos.vyos_prefix_lists_module.rst)|Prefix-Lists resource module for VyOS [vyos.vyos.vyos_route_maps](https://github.com/ansible-collections/vyos.vyos/blob/main/docs/vyos.vyos.vyos_route_maps_module.rst)|Route Map Resource Module. +[vyos.vyos.vyos_snmp_serve](https://github.com/ansible-collections/vyos.vyos/blob/main/docs/vyos.vyos.vyos_snmp_serve_module.rst)|Manages snmp_server resource module [vyos.vyos.vyos_static_route](https://github.com/ansible-collections/vyos.vyos/blob/main/docs/vyos.vyos.vyos_static_route_module.rst)|(deprecated, removed after 2022-06-01) Manage static IP routes on Vyatta VyOS network devices [vyos.vyos.vyos_static_routes](https://github.com/ansible-collections/vyos.vyos/blob/main/docs/vyos.vyos.vyos_static_routes_module.rst)|Static routes resource module [vyos.vyos.vyos_system](https://github.com/ansible-collections/vyos.vyos/blob/main/docs/vyos.vyos.vyos_system_module.rst)|Run `set system` commands on VyOS devices diff --git a/bindep.txt b/bindep.txt index ba9c980f..af39ab0c 100644 --- a/bindep.txt +++ b/bindep.txt @@ -4,3 +4,6 @@ gcc-c++ [doc test platform:rpm] python3-devel [test platform:rpm] python3 [test platform:rpm] +libssh-devel [test platform:rpm] +libffi-devel [test platform:rpm] +openssl-devel [test platform:rpm] diff --git a/changelogs/fragments/sanity_issue_fix.yaml b/changelogs/fragments/sanity_issue_fix.yaml new file mode 100644 index 00000000..60bb3d23 --- /dev/null +++ b/changelogs/fragments/sanity_issue_fix.yaml @@ -0,0 +1,3 @@ +--- +trivial: + - Add libssh dependency and fix doc issues. diff --git a/docs/vyos.vyos.vyos_facts_module.rst b/docs/vyos.vyos.vyos_facts_module.rst index b931d4c1..83606d06 100644 --- a/docs/vyos.vyos.vyos_facts_module.rst +++ b/docs/vyos.vyos.vyos_facts_module.rst @@ -65,7 +65,7 @@ Parameters -
When supplied, this argument will restrict the facts collected to a given subset. Possible values for this argument include all and the resources like interfaces. Can specify a list of values to include a larger subset. Values can also be used with an initial ! to specify that a specific subset should not be collected. Valid subsets are 'all', 'interfaces', 'l3_interfaces', 'lag_interfaces', 'lldp_global', 'lldp_interfaces', 'static_routes', 'firewall_rules', 'firewall_global', 'firewall_interfaces', 'ospfv3', 'ospfv2'.
+
When supplied, this argument will restrict the facts collected to a given subset. Possible values for this argument include all and the resources like interfaces. Can specify a list of values to include a larger subset. Values can also be used with an initial ! to specify that a specific subset should not be collected. Valid subsets are 'all', 'interfaces', 'l3_interfaces', 'lag_interfaces', 'lldp_global', 'lldp_interfaces', 'static_routes', 'firewall_rules', 'firewall_global', 'firewall_interfaces', 'ospfv3', 'ospfv2'.
@@ -82,7 +82,7 @@ Parameters Default:
"!config"
-
When supplied, this argument will restrict the facts collected to a given subset. Possible values for this argument include all, default, config, and neighbors. Can specify a list of values to include a larger subset. Values can also be used with an initial ! to specify that a specific subset should not be collected.
+
When supplied, this argument will restrict the facts collected to a given subset. Possible values for this argument include all, default, config, and neighbors. Can specify a list of values to include a larger subset. Values can also be used with an initial ! to specify that a specific subset should not be collected.
diff --git a/docs/vyos.vyos.vyos_ping_module.rst b/docs/vyos.vyos.vyos_ping_module.rst index 59e4a745..841ca819 100644 --- a/docs/vyos.vyos.vyos_ping_module.rst +++ b/docs/vyos.vyos.vyos_ping_module.rst @@ -19,9 +19,9 @@ Synopsis -------- - Tests reachability using ping from a VyOS device to a remote destination. - Tested against VyOS 1.1.8 (helium) -- For a general purpose network module, see the :ref:`net_ping ` module. -- For Windows targets, use the :ref:`win_ping ` module instead. -- For targets running Python, use the :ref:`ping ` module instead. +- For a general purpose network module, see the net_ping module. +- For Windows targets, use the win_ping module instead. +- For targets running Python, use the ping module instead. @@ -273,9 +273,9 @@ Notes .. note:: - Tested against VyOS 1.1.8 (helium). - - For a general purpose network module, see the :ref:`net_ping ` module. - - For Windows targets, use the :ref:`win_ping ` module instead. - - For targets running Python, use the :ref:`ping ` module instead. + - For a general purpose network module, see the net_ping module. + - For Windows targets, use the win_ping module instead. + - For targets running Python, use the ping module instead. - This module works with connection ``network_cli``. See `the VyOS OS Platform Options <../network/user_guide/platform_vyos.html>`_. - For more information on using Ansible to manage network devices see the :ref:`Ansible Network Guide ` diff --git a/plugins/modules/vyos_facts.py b/plugins/modules/vyos_facts.py index 8bffcda3..ef19ec09 100644 --- a/plugins/modules/vyos_facts.py +++ b/plugins/modules/vyos_facts.py @@ -35,7 +35,7 @@ options: - When supplied, this argument will restrict the facts collected to a given subset. Possible values for this argument include all, default, config, and neighbors. Can specify a list of values to include a larger subset. Values can also be used with an - initial C(M(!)) to specify that a specific subset should not be collected. + initial C(!) to specify that a specific subset should not be collected. required: false default: '!config' type: list @@ -45,7 +45,7 @@ options: - When supplied, this argument will restrict the facts collected to a given subset. Possible values for this argument include all and the resources like interfaces. Can specify a list of values to include a larger subset. Values can also be - used with an initial C(M(!)) to specify that a specific subset should not be + used with an initial C(!) to specify that a specific subset should not be collected. Valid subsets are 'all', 'interfaces', 'l3_interfaces', 'lag_interfaces', 'lldp_global', 'lldp_interfaces', 'static_routes', 'firewall_rules', 'firewall_global', 'firewall_interfaces', 'ospfv3', 'ospfv2'. diff --git a/plugins/modules/vyos_ping.py b/plugins/modules/vyos_ping.py index 90aa6d30..1052a9e2 100644 --- a/plugins/modules/vyos_ping.py +++ b/plugins/modules/vyos_ping.py @@ -30,9 +30,9 @@ short_description: Tests reachability using ping from VyOS network devices description: - Tests reachability using ping from a VyOS device to a remote destination. - Tested against VyOS 1.1.8 (helium) -- For a general purpose network module, see the M(net_ping) module. -- For Windows targets, use the M(win_ping) module instead. -- For targets running Python, use the M(ping) module instead. +- For a general purpose network module, see the net_ping module. +- For Windows targets, use the win_ping module instead. +- For targets running Python, use the ping module instead. version_added: 1.0.0 author: - Nilashish Chakraborty (@NilashishC) @@ -73,9 +73,9 @@ options: default: present notes: - Tested against VyOS 1.1.8 (helium). -- For a general purpose network module, see the M(net_ping) module. -- For Windows targets, use the M(win_ping) module instead. -- For targets running Python, use the M(ping) module instead. +- For a general purpose network module, see the net_ping module. +- For Windows targets, use the win_ping module instead. +- For targets running Python, use the ping module instead. - This module works with connection C(network_cli). See L(the VyOS OS Platform Options,../network/user_guide/platform_vyos.html). extends_documentation_fragment: - vyos.vyos.vyos -- cgit v1.2.3