From 9e829e1b75996b6b8268ab29b105d5dfa97da441 Mon Sep 17 00:00:00 2001 From: Shawn Wilsher <656602+sdwilsh@users.noreply.github.com> Date: Mon, 20 Sep 2021 16:25:42 -0700 Subject: Fix `vyos.vyos.vyos_firewall_rules` `state: replaced` to match documentation (#203) Fix `vyos.vyos.vyos_firewall_rules` `state: replaced` to match documentation SUMMARY vyos.vyos.vyos_firewall_rules should only try to change listed firewall rules, as documented, when the state is set to replaced. As currently implemented (prior to this PR), it better matches what overridden is meant to do. Fixes #201 ISSUE TYPE Bugfix Pull Request COMPONENT NAME vyos.vyos.vyos_firewall_rules ADDITIONAL INFORMATION Cleanup and document existing code for clarity Add a failing idempotent test Add a failing change test Fix failing tests Add change fragment Reviewed-by: GomathiselviS Reviewed-by: Shawn Wilsher Reviewed-by: None --- changelogs/fragments/fix-firewall_rules-state-replaced.yaml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 changelogs/fragments/fix-firewall_rules-state-replaced.yaml (limited to 'changelogs') diff --git a/changelogs/fragments/fix-firewall_rules-state-replaced.yaml b/changelogs/fragments/fix-firewall_rules-state-replaced.yaml new file mode 100644 index 00000000..231cd71b --- /dev/null +++ b/changelogs/fragments/fix-firewall_rules-state-replaced.yaml @@ -0,0 +1,3 @@ +--- +bugfixes: + - Fix vyos_firewall_rules with state replaced to only replace the specified rules. -- cgit v1.2.3