From 93aaf8615a0535dfe8cbd3b68dd82a1051a31411 Mon Sep 17 00:00:00 2001 From: YVarshitha <63169351+YVarshitha@users.noreply.github.com> Date: Fri, 27 Aug 2021 11:00:33 -0400 Subject: IPV6 ICMP type name in vyos.vyos.vyos_firewall_rules is not idempotent (#187) IPV6 ICMP type name in vyos.vyos.vyos_firewall_rules is not idempotent SUMMARY fix issue: #170 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: None --- .../module_utils/network/vyos/facts/firewall_rules/firewall_rules.py | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'plugins') diff --git a/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py b/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py index 44242929..63a159e6 100644 --- a/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py +++ b/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py @@ -13,6 +13,7 @@ from __future__ import absolute_import, division, print_function __metaclass__ = type +import re from re import findall, search, M from copy import deepcopy from ansible_collections.ansible.netcommon.plugins.module_utils.network.common import ( @@ -167,6 +168,7 @@ class Firewall_rulesFacts(object): "fragment", "disabled", "description", + "icmp", ] rule = self.parse_attr(conf, a_lst) r_sub = { @@ -282,6 +284,9 @@ class Firewall_rulesFacts(object): :return: generated config dictionary. """ a_lst = ["code", "type", "type_name"] + if attrib == "icmp": + attrib = "icmpv6" + conf = re.sub("icmpv6 type", "icmpv6 type-name", conf) cfg_dict = self.parse_attr(conf, a_lst, match=attrib) return cfg_dict -- cgit v1.2.3