From d3c91d0ee00c187a5623a6b66f9fedad800ff3d0 Mon Sep 17 00:00:00 2001 From: GomathiselviS Date: Tue, 22 Feb 2022 16:30:07 -0500 Subject: vyos_firewall_rules: Add support for log enable on individual rules (#238) vyos_firewall_rules: Add support for log enable on individual rules SUMMARY ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Rohit Thakur Reviewed-by: None --- .../network/vyos/argspec/firewall_rules/firewall_rules.py | 4 ++++ .../network/vyos/config/firewall_rules/firewall_rules.py | 2 ++ .../network/vyos/facts/firewall_rules/firewall_rules.py | 1 + plugins/modules/vyos_firewall_rules.py | 7 +++++++ 4 files changed, 14 insertions(+) (limited to 'plugins') diff --git a/plugins/module_utils/network/vyos/argspec/firewall_rules/firewall_rules.py b/plugins/module_utils/network/vyos/argspec/firewall_rules/firewall_rules.py index 2df77589..22dc8f7d 100644 --- a/plugins/module_utils/network/vyos/argspec/firewall_rules/firewall_rules.py +++ b/plugins/module_utils/network/vyos/argspec/firewall_rules/firewall_rules.py @@ -164,6 +164,10 @@ class Firewall_rulesArgs(object): # pylint: disable=R0903 }, "type": "dict", }, + "log": { + "type": "str", + "choices": ["enable", "disable"], + }, "number": {"required": True, "type": "int"}, "p2p": { "elements": "dict", diff --git a/plugins/module_utils/network/vyos/config/firewall_rules/firewall_rules.py b/plugins/module_utils/network/vyos/config/firewall_rules/firewall_rules.py index 3c56626f..1f1536c5 100644 --- a/plugins/module_utils/network/vyos/config/firewall_rules/firewall_rules.py +++ b/plugins/module_utils/network/vyos/config/firewall_rules/firewall_rules.py @@ -356,6 +356,7 @@ class Firewall_rules(ConfigBase): "fragment", "disabled", "description", + "log", ) if w_rules: for w in w_rules: @@ -1022,6 +1023,7 @@ class Firewall_rules(ConfigBase): r_set = ( "p2p", "ipsec", + "log", "action", "fragment", "protocol", diff --git a/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py b/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py index 63a159e6..8e29dbd7 100644 --- a/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py +++ b/plugins/module_utils/network/vyos/facts/firewall_rules/firewall_rules.py @@ -163,6 +163,7 @@ class Firewall_rulesFacts(object): """ a_lst = [ "ipsec", + "log", "action", "protocol", "fragment", diff --git a/plugins/modules/vyos_firewall_rules.py b/plugins/modules/vyos_firewall_rules.py index b6ed81b6..6df6892c 100644 --- a/plugins/modules/vyos_firewall_rules.py +++ b/plugins/modules/vyos_firewall_rules.py @@ -220,6 +220,13 @@ options: choices: - match-ipsec - match-none + log: + description: + - Option to log packets matching rule + type: str + choices: + - disable + - enable limit: description: - Rate limit using a token bucket filter. -- cgit v1.2.3