From 1ccb6f9f494a552d1d0004906d0463ddcdf374db Mon Sep 17 00:00:00 2001 From: Ruben van Dijk <15885455+RubenNL@users.noreply.github.com> Date: Mon, 3 Nov 2025 14:58:17 +0100 Subject: T7964 - Fix edgecase with empty `commands` array. (#439) * T7964 - Add failing test. * T7964 - Fix "IndexError: list index out of range". --- .../network/vyos/fixtures/vyos_firewall_global_config_v14.cfg | 3 ++- tests/unit/modules/network/vyos/test_vyos_firewall_global14.py | 10 ++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) (limited to 'tests/unit/modules') diff --git a/tests/unit/modules/network/vyos/fixtures/vyos_firewall_global_config_v14.cfg b/tests/unit/modules/network/vyos/fixtures/vyos_firewall_global_config_v14.cfg index 9e854fa6..c883ca78 100644 --- a/tests/unit/modules/network/vyos/fixtures/vyos_firewall_global_config_v14.cfg +++ b/tests/unit/modules/network/vyos/fixtures/vyos_firewall_global_config_v14.cfg @@ -1,3 +1,4 @@ +set firewall group address-group A-EMPTY set firewall group address-group RND-HOSTS address 192.0.2.1 set firewall group address-group RND-HOSTS address 192.0.2.3 set firewall group address-group RND-HOSTS address 192.0.2.5 @@ -20,4 +21,4 @@ set firewall global-options ipv6-src-route 'enable' set firewall global-options send-redirects 'enable' set firewall zone ZONE-TEST interface 'eth0.1234' set firewall zone ZONE-TEST description 'zone-test test description' -set firewall group address-group ZONE-TEST address '1.2.3.4' \ No newline at end of file +set firewall group address-group ZONE-TEST address '1.2.3.4' diff --git a/tests/unit/modules/network/vyos/test_vyos_firewall_global14.py b/tests/unit/modules/network/vyos/test_vyos_firewall_global14.py index efa0e454..b8bca0cc 100644 --- a/tests/unit/modules/network/vyos/test_vyos_firewall_global14.py +++ b/tests/unit/modules/network/vyos/test_vyos_firewall_global14.py @@ -205,6 +205,10 @@ class TestVyosFirewallRulesModule14(TestVyosModule): config=dict( group=dict( address_group=[ + dict( + afi="ipv4", + name="A-EMPTY", + ), dict( afi="ipv4", name="RND-HOSTS", @@ -323,6 +327,7 @@ class TestVyosFirewallRulesModule14(TestVyosModule): ), ) commands = [ + "delete firewall group address-group A-EMPTY", "delete firewall group address-group RND-HOSTS address 192.0.2.3", "delete firewall group address-group RND-HOSTS address 192.0.2.5", "delete firewall group address-group DELETE-HOSTS address", @@ -356,6 +361,10 @@ class TestVyosFirewallRulesModule14(TestVyosModule): ], group=dict( address_group=[ + dict( + afi="ipv4", + name="A-EMPTY", + ), dict( afi="ipv4", name="RND-HOSTS", @@ -484,6 +493,7 @@ class TestVyosFirewallRulesModule14(TestVyosModule): ), ) commands = [ + "delete firewall group address-group A-EMPTY", "delete firewall group address-group RND-HOSTS address 192.0.2.3", "delete firewall group address-group RND-HOSTS address 192.0.2.5", "delete firewall group address-group ZONE-TEST address 1.2.3.4", -- cgit v1.2.3