diff options
| author | Denys Fedoryshchenko <denys.f@collabora.com> | 2025-12-07 21:27:49 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-12-07 21:27:49 +0200 |
| commit | 0a89d44ce83738f3253709eb1d450cc25c80943e (patch) | |
| tree | 297b227a93c82623de45b9d683cabaf38b49c19d | |
| parent | 5ca558210d04a500aa5fa78bab97ea99addc6c09 (diff) | |
| parent | 2e67021ad907ffc1d73515acf18573884eb67828 (diff) | |
| download | accel-ppp-0a89d44ce83738f3253709eb1d450cc25c80943e.tar.gz accel-ppp-0a89d44ce83738f3253709eb1d450cc25c80943e.zip | |
Merge pull request #270 from nuclearcat/static-analyzer-fixes
auth_chap_md5: unused variable, mschap_error likely copy paste error, plain chap dont have errors like mschap
| -rw-r--r-- | CMakeLists.txt | 2 | ||||
| -rw-r--r-- | accel-pppd/auth/auth_chap_md5.c | 1 | ||||
| -rw-r--r-- | cmake/cpack.cmake | 2 |
3 files changed, 2 insertions, 3 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index b2b98ea0..0661e8fc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -55,7 +55,7 @@ IF (EXISTS ${CMAKE_HOME_DIRECTORY}/.git AND NOT IGNORE_GIT) WORKING_DIRECTORY ${CMAKE_HOME_DIRECTORY} OUTPUT_VARIABLE ACCEL_PPP_VERSION ) - STRING(STRIP ${ACCEL_PPP_VERSION} ACCEL_PPP_VERSION) + STRING(STRIP "${ACCEL_PPP_VERSION}" ACCEL_PPP_VERSION) ELSE (EXISTS ${CMAKE_HOME_DIRECTORY}/.git AND NOT IGNORE_GIT) SET (ACCEL_PPP_VERSION 1.13.0) ENDIF (EXISTS ${CMAKE_HOME_DIRECTORY}/.git AND NOT IGNORE_GIT) diff --git a/accel-pppd/auth/auth_chap_md5.c b/accel-pppd/auth/auth_chap_md5.c index 3ff685e6..e0820dba 100644 --- a/accel-pppd/auth/auth_chap_md5.c +++ b/accel-pppd/auth/auth_chap_md5.c @@ -73,7 +73,6 @@ struct chap_auth_data { struct triton_timer_t interval; int failure; char *name; - char *mschap_error; unsigned int started:1; }; diff --git a/cmake/cpack.cmake b/cmake/cpack.cmake index c004075c..ee2a0391 100644 --- a/cmake/cpack.cmake +++ b/cmake/cpack.cmake @@ -1,6 +1,6 @@ INCLUDE(InstallRequiredSystemLibraries) -string(REPLACE "." ";" VERSION_LIST ${ACCEL_PPP_VERSION}) +string(REPLACE "." ";" VERSION_LIST "${ACCEL_PPP_VERSION}") # Verify if VERSION_LIST has 3 elements # If not assign dummy variables |