diff options
| author | Guillaume Nault <g.nault@alphalink.fr> | 2018-02-21 17:55:53 +0100 |
|---|---|---|
| committer | Dmitry Kozlov <xeb@mail.ru> | 2018-03-03 12:13:17 +0300 |
| commit | 8028b5739030e2c905d9c86ff797bcb488ae6b06 (patch) | |
| tree | 71a441bdd4856cd865ac71cd35880cd3ef0040df | |
| parent | d0fdab57a368be5983b9db53061c4e55b25d8ae3 (diff) | |
| download | accel-ppp-8028b5739030e2c905d9c86ff797bcb488ae6b06.tar.gz accel-ppp-8028b5739030e2c905d9c86ff797bcb488ae6b06.zip | |
ppp: fix use-after-free in ppp_auth_failed()
The 'username' variable can be freed at the beginning of the function.
We have to use ppp->ses.username instead.
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
| -rw-r--r-- | accel-pppd/ppp/ppp_auth.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/accel-pppd/ppp/ppp_auth.c b/accel-pppd/ppp/ppp_auth.c index 79272886..7658e650 100644 --- a/accel-pppd/ppp/ppp_auth.c +++ b/accel-pppd/ppp/ppp_auth.c @@ -364,8 +364,8 @@ void __export ppp_auth_failed(struct ppp_t *ppp, char *username) _free(username); ppp->ses.terminate_cause = TERM_AUTH_ERROR; pthread_rwlock_unlock(&ses_lock); - log_ppp_info1("%s: authentication failed\n", username); - log_info1("%s: authentication failed\n", username); + log_ppp_info1("%s: authentication failed\n", ppp->ses.username); + log_info1("%s: authentication failed\n", ppp->ses.username); triton_event_fire(EV_SES_AUTH_FAILED, ppp); } else log_ppp_info1("authentication failed\n"); |