diff options
| author | Guillaume Nault <g.nault@alphalink.fr> | 2012-12-10 13:29:32 +0100 |
|---|---|---|
| committer | Kozlov Dmitry <xeb@mail.ru> | 2012-12-14 20:52:51 +0400 |
| commit | 98466f59d258d2079755d2a1808cd34631d9f230 (patch) | |
| tree | dace3ce3af9cb44b0848654153a6191e3648a32b | |
| parent | 9e07dd71679b93852528efb41ac51ec2423f394b (diff) | |
| download | accel-ppp-98466f59d258d2079755d2a1808cd34631d9f230.tar.gz accel-ppp-98466f59d258d2079755d2a1808cd34631d9f230.zip | |
l2tp: Fix allocation checking when adding octets AVP
l2tp_packet_add_octets() performs a malloc on the "octets" field of the
L2TP attribute, but checks the "string" field for allocation failure.
Though these fields should be equivalent in this case, the "octets"
field should be logically checked instead of "string".
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
| -rw-r--r-- | accel-pppd/ctrl/l2tp/packet.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/accel-pppd/ctrl/l2tp/packet.c b/accel-pppd/ctrl/l2tp/packet.c index 70d8d5d9..b1ae5d58 100644 --- a/accel-pppd/ctrl/l2tp/packet.c +++ b/accel-pppd/ctrl/l2tp/packet.c @@ -482,7 +482,7 @@ int l2tp_packet_add_octets(struct l2tp_packet_t *pack, int id, const uint8_t *va attr->length = size; attr->val.octets = _malloc(size); - if (!attr->val.string) { + if (!attr->val.octets) { log_emerg("l2tp: out of memory\n"); mempool_free(attr); return -1; |