diff options
| author | Denys Fedoryshchenko <denys.f@collabora.com> | 2026-02-06 18:04:29 +0200 |
|---|---|---|
| committer | Denys Fedoryshchenko <denys.f@collabora.com> | 2026-02-06 18:04:29 +0200 |
| commit | e3c3c7752944af85ed2854eaaf7482b018cae8b4 (patch) | |
| tree | 87414b9c39f058cef4383f2e63c391179dd2501f | |
| parent | 96ff385e6b9084b4c6ba58292e396e18ff7d04d5 (diff) | |
| download | accel-ppp-e3c3c7752944af85ed2854eaaf7482b018cae8b4.tar.gz accel-ppp-e3c3c7752944af85ed2854eaaf7482b018cae8b4.zip | |
radius: MS-CHAP2-Success unchecked memcpy(40 bytes)
Also fix small typo.
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
| -rw-r--r-- | accel-pppd/radius/auth.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/accel-pppd/radius/auth.c b/accel-pppd/radius/auth.c index 69f1b2ef..73e7a50c 100644 --- a/accel-pppd/radius/auth.c +++ b/accel-pppd/radius/auth.c @@ -434,7 +434,10 @@ static int rad_auth_mschap_v2_recv(struct rad_req_t *req) if (req->reply->code == CODE_ACCESS_ACCEPT) { ra = rad_packet_find_attr(req->reply, "Microsoft", "MS-CHAP2-Success"); if (!ra) { - log_error("radius:auth:mschap-v2: 'MS-CHAP-Success' not found in radius response\n"); + log_error("radius:auth:mschap-v2: 'MS-CHAP2-Success' not found in radius response\n"); + return -1; + } else if (ra->len < 43) { + log_error("radius:auth:mschap-v2: 'MS-CHAP2-Success' too short (%i)\n", ra->len); return -1; } else memcpy(rpd->auth_ctx->authenticator, ra->val.octets + 3, 40); |