ipoe: fix username string leak on early session teardown

The ipoe-level ses->username always holds an allocated string
(_strdup of ifname/calling-station-id, u_inet_ntoa buffer or lua
result), but ipoe_session_free() never released it. Ownership is
normally transferred in auth_result() via ap_session_set_username(),
so the string was leaked whenever a session died before auth_result()
ran: termination while starting, PWDB_WAIT never completing, or
ipoe_create_interface() failure.

The create-interface failure path also leaked the freshly allocated
local copy outright, since it returned before the string was stored
anywhere.

Store the string in ses->username as soon as it is obtained and free
it in ipoe_session_free(). auth_result() clears ses->username before
handing ownership to ap_session_set_username(), so no double free is
possible.

Reported-by: Louis Scalbert (#101)

0 files changed, 0 insertions, 0 deletions