summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordd <dd@wx.tnyzeq.icu>2024-10-06 17:47:09 +0200
committerdd <dd@wx.tnyzeq.icu>2024-10-06 17:47:16 +0200
commite119b73e2111943dcba994e03580eb8fdc50bc84 (patch)
tree456a61efe8d2cf4c66ab1423c8b19c76db2d44e3
parentf8bb674857505c2ca5a360ad35ae7281da784b2f (diff)
downloadvyos-jenkins-e119b73e2111943dcba994e03580eb8fdc50bc84.tar.gz
vyos-jenkins-e119b73e2111943dcba994e03580eb8fdc50bc84.zip
updated circinus builder to refuse to run as root
-rwxr-xr-xnew/image_builder.py4
-rw-r--r--new/lib/helpers.py9
-rwxr-xr-xnew/package_builder.py4
3 files changed, 15 insertions, 2 deletions
diff --git a/new/image_builder.py b/new/image_builder.py
index 23baccd..3d99975 100755
--- a/new/image_builder.py
+++ b/new/image_builder.py
@@ -13,7 +13,7 @@ from time import monotonic
import netifaces
from lib.git import Git
-from lib.helpers import setup_logging, execute, quote_all, rmtree
+from lib.helpers import setup_logging, execute, quote_all, rmtree, refuse_root
class ImageBuilder:
@@ -197,6 +197,8 @@ if __name__ == "__main__":
setup_logging()
try:
+ refuse_root()
+
parser = argparse.ArgumentParser()
parser.add_argument("branch", help="VyOS branch (current, circinus)")
parser.add_argument("--vyos-build-git", default="https://github.com/vyos/vyos-build.git",
diff --git a/new/lib/helpers.py b/new/lib/helpers.py
index 2d84e1a..d2ea3f4 100644
--- a/new/lib/helpers.py
+++ b/new/lib/helpers.py
@@ -1,4 +1,5 @@
import logging
+import os
import shlex
import shutil
import subprocess
@@ -65,3 +66,11 @@ def setup_logging():
console.setLevel(logging.INFO)
console.setFormatter(formatter)
logger.addHandler(console)
+
+def refuse_root():
+ if os.getuid() == 0:
+ logging.error(
+ "ERROR: 'root' user detected, please don't run this script as root,"
+ " run as any other regular user that has docker access (usermod -aG docker YOUR_USER),"
+ " the root privileges would break some packages.")
+ exit(1) \ No newline at end of file
diff --git a/new/package_builder.py b/new/package_builder.py
index b9b2c74..3f01520 100755
--- a/new/package_builder.py
+++ b/new/package_builder.py
@@ -11,7 +11,7 @@ from lib.apt import Apt
from lib.cache import Cache
from lib.git import Git
from lib.github import GitHub
-from lib.helpers import setup_logging, quote_all, execute, ProcessException, rmtree
+from lib.helpers import setup_logging, quote_all, execute, ProcessException, rmtree, refuse_root
class Builder:
@@ -195,6 +195,8 @@ if __name__ == "__main__":
setup_logging()
try:
+ refuse_root()
+
parser = argparse.ArgumentParser()
parser.add_argument("branch", help="VyOS branch (current, circinus)")
parser.add_argument("--single-package", help="Build only this package")