summaryrefslogtreecommitdiff
path: root/accel-pppd
diff options
context:
space:
mode:
authorVladislav Grishenko <themiron@mail.ru>2021-07-09 22:40:00 +0500
committerVladislav Grishenko <themiron@mail.ru>2021-07-09 22:40:00 +0500
commit2224396d8d184e2c267a9958408e0606541e9d0b (patch)
treeee9e115356098c22cf25672837ec24fe74e20668 /accel-pppd
parentaa9e2eefe4ad51ba6a61ba10abe7dc1ef277700d (diff)
downloadaccel-ppp-xebd-2224396d8d184e2c267a9958408e0606541e9d0b.tar.gz
accel-ppp-xebd-2224396d8d184e2c267a9958408e0606541e9d0b.zip
ipoe: dhcpv4: fix address lost due signed overflow
fixes a1a2b79240511222868a60960d51f12adbe0d7d4
Diffstat (limited to 'accel-pppd')
-rw-r--r--accel-pppd/ctrl/ipoe/dhcpv4.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/accel-pppd/ctrl/ipoe/dhcpv4.c b/accel-pppd/ctrl/ipoe/dhcpv4.c
index ffbbcfe..f1d9c46 100644
--- a/accel-pppd/ctrl/ipoe/dhcpv4.c
+++ b/accel-pppd/ctrl/ipoe/dhcpv4.c
@@ -105,7 +105,7 @@ static struct dhcpv4_iprange *parse_range(const char *str)
pthread_mutex_init(&r->lock, NULL);
end -= start;
- r->free[(end - 1) / ( 8 * sizeof(long))] &= (1l << ((end - 1) % (8 * sizeof(long)) + 1)) - 1;
+ r->free[(end - 1) / ( 8 * sizeof(long))] &= (1ul << ((end - 1) % (8 * sizeof(long)) + 1)) - 1;
r->free[0] &= ~3;
return r;
@@ -1179,7 +1179,7 @@ int dhcpv4_get_ip(struct dhcpv4_serv *serv, uint32_t *yiaddr, uint32_t *siaddr,
for (i = serv->range->pos; i < serv->range->len; i++) {
k = ffsl(serv->range->free[i]);
if (k) {
- serv->range->free[i] &= ~(1l << (k - 1));
+ serv->range->free[i] &= ~(1lu << (k - 1));
serv->range->pos = i;
pthread_mutex_unlock(&serv->range->lock);
*yiaddr = htonl(serv->range->startip + i * 8 * sizeof(long) + k - 1);
@@ -1207,7 +1207,7 @@ void dhcpv4_put_ip(struct dhcpv4_serv *serv, uint32_t ip)
return;
pthread_mutex_lock(&serv->range->lock);
- serv->range->free[n / (8 * sizeof(long))] |= 1l << (n % (8 * sizeof(long)));
+ serv->range->free[n / (8 * sizeof(long))] |= 1lu << (n % (8 * sizeof(long)));
pthread_mutex_unlock(&serv->range->lock);
}