summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author[anp/hsw] <sysop@880.ru>2021-03-13 20:22:05 +0700
committer[anp/hsw] <sysop@880.ru>2021-03-13 20:22:05 +0700
commit6c2fb7f07692ec8d9aad971b177dbb8718bf391a (patch)
tree250d3d5616000bf02188aaa172fdbd3fa9565d3f
parentc914000971063a4500cfb34f4141dfc3c943368d (diff)
downloadaccel-ppp-6c2fb7f07692ec8d9aad971b177dbb8718bf391a.tar.gz
accel-ppp-6c2fb7f07692ec8d9aad971b177dbb8718bf391a.zip
Fix another errors found by cppcheck
[accel-pppd/cli/tcp.c:305]: (error) Uninitialized variable: cln [accel-pppd/cli/telnet.c:642]: (error) Uninitialized variable: cln [accel-pppd/ctrl/l2tp/l2tp.c:4302]: (error) Uninitialized variable: msg_attr [accel-pppd/ctrl/l2tp/l2tp.c:4484]: (error) Uninitialized variable: msg_type [accel-pppd/ctrl/pppoe/disc.c:169]: (error) Uninitialized variable: n [accel-pppd/ctrl/pppoe/pppoe.c:1588]: (error) Uninitialized variable: pado
-rw-r--r--accel-pppd/cli/tcp.c2
-rw-r--r--accel-pppd/cli/telnet.c2
-rw-r--r--accel-pppd/ctrl/l2tp/l2tp.c4
-rw-r--r--accel-pppd/ctrl/pppoe/disc.c2
-rw-r--r--accel-pppd/ctrl/pppoe/pppoe.c2
5 files changed, 6 insertions, 6 deletions
diff --git a/accel-pppd/cli/tcp.c b/accel-pppd/cli/tcp.c
index 270d8cb..87633cb 100644
--- a/accel-pppd/cli/tcp.c
+++ b/accel-pppd/cli/tcp.c
@@ -298,7 +298,7 @@ static int serv_read(struct triton_md_handler_t *h)
static void serv_close(struct triton_context_t *ctx)
{
- struct tcp_client_t *cln;
+ struct tcp_client_t *cln = NULL;
while (!list_empty(&clients)) {
cln = list_entry(clients.next, typeof(*cln), entry);
diff --git a/accel-pppd/cli/telnet.c b/accel-pppd/cli/telnet.c
index 4b5f63b..4ea1839 100644
--- a/accel-pppd/cli/telnet.c
+++ b/accel-pppd/cli/telnet.c
@@ -635,7 +635,7 @@ static int serv_read(struct triton_md_handler_t *h)
}
static void serv_close(struct triton_context_t *ctx)
{
- struct telnet_client_t *cln;
+ struct telnet_client_t *cln = NULL;
while (!list_empty(&clients)) {
cln = list_entry(clients.next, typeof(*cln), entry);
diff --git a/accel-pppd/ctrl/l2tp/l2tp.c b/accel-pppd/ctrl/l2tp/l2tp.c
index 2467189..8567027 100644
--- a/accel-pppd/ctrl/l2tp/l2tp.c
+++ b/accel-pppd/ctrl/l2tp/l2tp.c
@@ -4224,7 +4224,7 @@ static int l2tp_tunnel_store_msg(struct l2tp_conn_t *conn,
static int l2tp_tunnel_reply(struct l2tp_conn_t *conn, int need_ack)
{
- const struct l2tp_attr_t *msg_attr;
+ const struct l2tp_attr_t *msg_attr = NULL;
struct l2tp_packet_t *pack;
struct l2tp_sess_t *sess;
uint16_t msg_sid;
@@ -4430,7 +4430,7 @@ static int l2tp_udp_read(struct triton_md_handler_t *h)
{
struct l2tp_serv_t *serv = container_of(h, typeof(*serv), hnd);
struct l2tp_packet_t *pack;
- const struct l2tp_attr_t *msg_type;
+ const struct l2tp_attr_t *msg_type = NULL;
struct in_pktinfo pkt_info;
char src_addr[17];
diff --git a/accel-pppd/ctrl/pppoe/disc.c b/accel-pppd/ctrl/pppoe/disc.c
index a0a2175..b1119eb 100644
--- a/accel-pppd/ctrl/pppoe/disc.c
+++ b/accel-pppd/ctrl/pppoe/disc.c
@@ -139,7 +139,7 @@ int pppoe_disc_start(struct pppoe_serv_t *serv)
struct rb_node **p, *parent = NULL;
struct tree *t;
int ifindex = serv->ifindex, i;
- struct pppoe_serv_t *n;
+ struct pppoe_serv_t *n = NULL;
if (!net) {
pthread_mutex_lock(&nets_lock);
diff --git a/accel-pppd/ctrl/pppoe/pppoe.c b/accel-pppd/ctrl/pppoe/pppoe.c
index 045a638..6d87649 100644
--- a/accel-pppd/ctrl/pppoe/pppoe.c
+++ b/accel-pppd/ctrl/pppoe/pppoe.c
@@ -1577,7 +1577,7 @@ void _server_stop(struct pppoe_serv_t *serv)
void pppoe_server_free(struct pppoe_serv_t *serv)
{
- struct delayed_pado_t *pado;
+ struct delayed_pado_t *pado = NULL;
pthread_rwlock_wrlock(&serv_lock);
list_del(&serv->entry);