diff options
| author | Christian Poessinger <christian@poessinger.com> | 2019-10-03 22:51:34 +0200 |
|---|---|---|
| committer | Christian Poessinger <christian@poessinger.com> | 2019-10-03 22:51:34 +0200 |
| commit | 6f954ab56768af9a07d8a1dc086f54ddefa58da7 (patch) | |
| tree | ddadd5f2adef902223efa275f15d7d6315960019 | |
| parent | bdf890cca40157b3f2a2386685e043e0fa220fac (diff) | |
| download | vyos-1x-6f954ab56768af9a07d8a1dc086f54ddefa58da7.tar.gz vyos-1x-6f954ab56768af9a07d8a1dc086f54ddefa58da7.zip | |
dhcp-server: T1707: remove DHCP static-mappings from address pool
Previously when static-mappings have been created the address was still within
the DHCP pool resulting in log entries as follows:
dhcpd: Dynamic and static leases present for 192.0.2.51
dhcpd: Remove host declaration DMZ_PC2 or remove 192.0.2.51
dhcpd: from the dynamic address pool for DMZ
| -rwxr-xr-x | src/conf_mode/dhcp_server.py | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/src/conf_mode/dhcp_server.py b/src/conf_mode/dhcp_server.py index 84ab7ec97..504a9c35e 100755 --- a/src/conf_mode/dhcp_server.py +++ b/src/conf_mode/dhcp_server.py @@ -523,6 +523,7 @@ def get_config(): # Static DHCP leases if conf.exists('static-mapping'): + addresses_for_exclude = [] for mapping in conf.list_nodes('static-mapping'): conf.set_level('service dhcp-server shared-network-name {0} subnet {1} static-mapping {2}'.format(network, net, mapping)) mapping = { @@ -540,6 +541,7 @@ def get_config(): # IP address used for this DHCP client if conf.exists('ip-address'): mapping['ip_address'] = conf.return_value('ip-address') + addresses_for_exclude.append(mapping['ip_address']) # MAC address of requesting DHCP client if conf.exists('mac-address'): @@ -558,6 +560,13 @@ def get_config(): # append static-mapping configuration to subnet list subnet['static_mapping'].append(mapping) + # Now we have all static DHCP leases - we also need to slice them + # out of our DHCP ranges to avoid ISC DHCPd warnings as: + # dhcpd: Dynamic and static leases present for 192.0.2.51. + # dhcpd: Remove host declaration DMZ_PC1 or remove 192.0.2.51 + # dhcpd: from the dynamic address pool for DMZ + subnet['range'] = dhcp_slice_range(addresses_for_exclude, subnet['range']) + # Reset config level to matching hirachy conf.set_level('service dhcp-server shared-network-name {0} subnet {1}'.format(network, net)) |