ethernet: T3891: honor auto-negotiation support per NIC

Not all drivers/NICs or combination of NIC + transceiver support auto-
negotiation. The current auto-negotiation capability is evaluated and taken
into account when applying spped/duplex settings. If auto-negotiation is
not supported - we skip the setting to avoid errors during configuration.

2 files changed, 23 insertions, 6 deletions

diff --git a/python/vyos/ethtool.py b/python/vyos/ethtool.py
index bc3402059..9d016e5cc 100644
--- a/python/vyos/ethtool.py
+++ b/python/vyos/ethtool.py
@@ -51,6 +51,7 @@ class Ethtool:
     _ring_buffers_max = { }
     _driver_name = None
     _auto_negotiation = False
+    _auto_negotiation_supported = None
     _flow_control = False
     _flow_control_enabled = None
 
@@ -80,7 +81,13 @@ class Ethtool:
                             self._speed_duplex.update({ speed : {}})
                         if duplex not in self._speed_duplex[speed]:
                             self._speed_duplex[speed].update({ duplex : ''})
-            if 'Auto-negotiation:' in line:
+            if 'Supports auto-negotiation:':
+                # Split the following string: Auto-negotiation: off
+                # we are only interested in off or on
+                tmp = line.split()[-1]
+                self._auto_negotiation_supported = bool(tmp == 'Yes')
+            # Only read in if Auto-negotiation is supported
+            if self._auto_negotiation_supported and 'Auto-negotiation:' in line:
                 # Split the following string: Auto-negotiation: off
                 # we are only interested in off or on
                 tmp = line.split()[-1]
@@ -132,8 +139,12 @@ class Ethtool:
             # ['Autonegotiate:', 'on']
             self._flow_control_enabled = out.splitlines()[1].split()[-1]
 
+    def check_auto_negotiation_supported(self):
+        """ Check if the NIC supports changing auto-negotiation """
+        return self._auto_negotiation_supported
+
     def get_auto_negotiation(self):
-        return self._auto_negotiation
+        return self._auto_negotiation_supported and self._auto_negotiation
 
     def get_driver_name(self):
         return self._driver_name
diff --git a/python/vyos/ifconfig/ethernet.py b/python/vyos/ifconfig/ethernet.py
index 5080144ff..6a49c022a 100644
--- a/python/vyos/ifconfig/ethernet.py
+++ b/python/vyos/ifconfig/ethernet.py
@@ -1,4 +1,4 @@
-# Copyright 2019-2021 VyOS maintainers and contributors <maintainers@vyos.io>
+# Copyright 2019-2023 VyOS maintainers and contributors <maintainers@vyos.io>
 #
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
@@ -14,9 +14,10 @@
 # License along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
 import os
-import re
 
 from glob import glob
+
+from vyos.base import Warning
 from vyos.ethtool import Ethtool
 from vyos.ifconfig.interface import Interface
 from vyos.util import run
@@ -118,7 +119,7 @@ class EthernetIf(Interface):
             cmd = f'ethtool --pause {ifname} autoneg {enable} tx {enable} rx {enable}'
             output, code = self._popen(cmd)
             if code:
-                print(f'Could not set flowcontrol for {ifname}')
+                Warning(f'could not change "{ifname}" flow control setting!')
             return output
         return None
 
@@ -134,6 +135,7 @@ class EthernetIf(Interface):
         >>> i = EthernetIf('eth0')
         >>> i.set_speed_duplex('auto', 'auto')
         """
+        ifname = self.config['ifname']
 
         if speed not in ['auto', '10', '100', '1000', '2500', '5000', '10000',
                          '25000', '40000', '50000', '100000', '400000']:
@@ -143,7 +145,11 @@ class EthernetIf(Interface):
             raise ValueError("Value out of range (duplex)")
 
         if not self.ethtool.check_speed_duplex(speed, duplex):
-            self._debug_msg(f'NIC driver does not support changing speed/duplex settings!')
+            Warning(f'changing speed/duplex setting on "{ifname}" is unsupported!')
+            return
+
+        if not self.ethtool.check_auto_negotiation_supported():
+            Warning(f'changing auto-negotiation setting on "{ifname}" is unsupported!')
             return
 
         # Get current speed and duplex settings: