diff options
| author | Daniel Watkins <oddbloke@ubuntu.com> | 2020-05-14 15:39:19 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-14 15:39:19 -0400 |
| commit | 09492b1d0f4b1826a7a98709c61d48bf14a1ec64 (patch) | |
| tree | 9150f282f7925c331235d1bb7199ba5b778c146e /cloudinit/config/tests | |
| parent | 4261ae538563d262bc76b8c55f7cc0c8abb14b00 (diff) | |
| download | vyos-cloud-init-09492b1d0f4b1826a7a98709c61d48bf14a1ec64.tar.gz vyos-cloud-init-09492b1d0f4b1826a7a98709c61d48bf14a1ec64.zip | |
cloudinit: minor pylint fixes (#360)
We recently discovered that pylint is failing to report some errors when
invoked across our entire codebase (see
https://github.com/PyCQA/pylint/issues/3611). I've run pylint across
every Python file under cloudinit/[0], and this commit fixes the issues
so-discovered.
[0] find cloudinit/ -name "*.py" | xargs -n 1 -t .tox/pylint/bin/python -m pylint
Diffstat (limited to 'cloudinit/config/tests')
| -rw-r--r-- | cloudinit/config/tests/test_snap.py | 2 | ||||
| -rw-r--r-- | cloudinit/config/tests/test_ubuntu_drivers.py | 7 |
2 files changed, 8 insertions, 1 deletions
diff --git a/cloudinit/config/tests/test_snap.py b/cloudinit/config/tests/test_snap.py index cbbb173d..70676942 100644 --- a/cloudinit/config/tests/test_snap.py +++ b/cloudinit/config/tests/test_snap.py @@ -345,7 +345,7 @@ class TestSchema(CiTestCase, SchemaTestCaseMixin): def test_duplicates_are_fine_array_array(self): """Duplicated commands array/array entries are allowed.""" self.assertSchemaValid( - {'commands': [["echo", "bye"], ["echo" "bye"]]}, + {'commands': [["echo", "bye"], ["echo", "bye"]]}, "command entries can be duplicate.") def test_duplicates_are_fine_array_string(self): diff --git a/cloudinit/config/tests/test_ubuntu_drivers.py b/cloudinit/config/tests/test_ubuntu_drivers.py index 46952692..0aec1265 100644 --- a/cloudinit/config/tests/test_ubuntu_drivers.py +++ b/cloudinit/config/tests/test_ubuntu_drivers.py @@ -16,6 +16,13 @@ OLD_UBUNTU_DRIVERS_ERROR_STDERR = ( "(choose from 'list', 'autoinstall', 'devices', 'debug')\n") +# The tests in this module call helper methods which are decorated with +# mock.patch. pylint doesn't understand that mock.patch passes parameters to +# the decorated function, so it incorrectly reports that we aren't passing +# values for all parameters. Instead of annotating every single call, we +# disable it for the entire module: +# pylint: disable=no-value-for-parameter + class AnyTempScriptAndDebconfFile(object): def __init__(self, tmp_dir, debconf_file): |